mirror of
https://gerrit.wikimedia.org/r/mediawiki/extensions/Cite
synced 2024-12-11 14:46:11 +00:00
25e7aa44dd
This is a mistake that exists in this codebase for who knows how long. Cite mis-uses the messaging system a lot for internal things we still want to customize somehow, but are not labels that will ever be shown on the screen. The prefix/suffix messages in this patch are meant to be part of the HTML in id="…" attributes. Prefix/suffix must be a static plain text strings. Using e.g. {{GENDER}} or {{PLURAL}} in these messages is not even possible because there is no $1 parameter to use. Note how all other similar messages already use ->plain(). A few wikis override these messages, but stick to the plain-text convention, as they should: https://global-search.toolforge.org/?q=.®ex=1&namespaces=8&title=Cite.*reference.*fix This will continue to work. This has minor performance implications. Fetching these messages is faster if we can skip transformations. Bug: T321217 Change-Id: I7969c255fe4ce897e904897081da5f52678721aa |
||
---|---|---|
.. | ||
AnchorFormatterTest.php | ||
CiteTest.php | ||
FootnoteMarkFormatterTest.php |