Commit graph

2799 commits

Author SHA1 Message Date
Translation updater bot 046297f360 Localisation updates from https://translatewiki.net.
Change-Id: I8a99726d84ae5de1b6f1df83d388039032d3889d
2018-07-12 22:38:29 +02:00
Translation updater bot e4902524b2 Localisation updates from https://translatewiki.net.
Change-Id: Ia0cc70db00cffa075aeec1d8e0a686c7110af1b5
2018-07-11 22:39:30 +02:00
Translation updater bot c1b77b092e Localisation updates from https://translatewiki.net.
Change-Id: I3f00282a3860cee11e976aa4171ff3562fbfe7db
2018-07-07 22:52:28 +02:00
Translation updater bot bd02bf9557 Localisation updates from https://translatewiki.net.
Change-Id: I4d7c0a80e98b2bf5a37632035c695fb6d8eb65b5
2018-07-05 22:43:39 +02:00
Translation updater bot 65ebb13131 Localisation updates from https://translatewiki.net.
Change-Id: If0c256f33f98baf86c296c35e2a3d22aeb76b809
2018-07-02 22:10:23 +02:00
Translation updater bot a59f8a085d Localisation updates from https://translatewiki.net.
Change-Id: I3e04c8cceae727e5470d4ae4fdb2404639f9bfb8
2018-06-30 22:30:17 +02:00
Translation updater bot 270b1b56ba Localisation updates from https://translatewiki.net.
Change-Id: I3cbf13202bc9fa6053325d3c69600fdbc40f1741
2018-06-29 22:25:43 +02:00
Translation updater bot d0073f4060 Localisation updates from https://translatewiki.net.
Change-Id: I1d70595d17590a80d48f20b878a34f57c7e6e49b
2018-06-28 22:20:58 +02:00
Translation updater bot 3ba755bdd2 Localisation updates from https://translatewiki.net.
Change-Id: I01e328cba818b428b7705df1e896f25f50e60c9c
2018-06-27 22:18:23 +02:00
Translation updater bot c58160888f Localisation updates from https://translatewiki.net.
Change-Id: I3164a5fe13f745279010e2888811ab85aadcf9eb
2018-06-25 22:22:03 +02:00
Translation updater bot 6904eae490 Localisation updates from https://translatewiki.net.
Change-Id: Idd9310f79493db305959bb42439abff880e42731
2018-06-24 22:25:28 +02:00
Translation updater bot 859302a150 Localisation updates from https://translatewiki.net.
Change-Id: I53b320ee8919b9b798dfc35fda2344563f39c6de
2018-06-21 22:42:24 +02:00
Ed Sanders 3b53f6906b Use getHtmlMessage for DiffElement
Bug: T195243
Depends-On: Ib4ad16858e4241d33d018830dbcfded63ff703af
Depends-On: Ib5fa39e4f2f529948354b03a141542e23d169fe0
Change-Id: I4b01904d48a9520c8bb1451e0978aaa404ca858c
2018-06-20 15:31:46 +00:00
Translation updater bot 73ca14bb7d Localisation updates from https://translatewiki.net.
Change-Id: I17d832a454d3f64f1bbeeab8df666bd322bc830a
2018-06-15 22:35:36 +02:00
Translation updater bot 0a0dae10d6 Localisation updates from https://translatewiki.net.
Change-Id: Iaae6fc6de3940e7f1e0d79cded597125500a625d
2018-06-14 22:44:29 +02:00
Translation updater bot 72572ba8a0 Localisation updates from https://translatewiki.net.
Change-Id: I65609ee5a741c0356659b48098d602efe1cf5bcc
2018-06-11 22:33:37 +02:00
libraryupgrader 19b7c6dced build: Updating mediawiki/mediawiki-phan-config to 0.3.0
Change-Id: Id67e06150da6ba5b470957b3d6dd1a974847be89
2018-06-08 06:54:15 +00:00
Translation updater bot 3c6aeebccf Localisation updates from https://translatewiki.net.
Change-Id: I2c2e27f177f3091d909a1fcadc9d8e5840510e85
2018-06-03 22:36:06 +02:00
Translation updater bot 63dbdbf482 Localisation updates from https://translatewiki.net.
Change-Id: I0542ffd798b80596c89486f5e401d5b1cc41a7f2
2018-06-02 22:41:16 +02:00
Translation updater bot 85015573ea Localisation updates from https://translatewiki.net.
Change-Id: If23a26a389b0ba77082b4490538092e104af987f
2018-06-01 22:27:22 +02:00
Ed Sanders 6c38c009d7 Add preview mode converter tests
Change-Id: I2e9dc615a82b725d4061b39e6bdc56350e5d3d1d
Depends-On: I3f1a4772cbf67091b5fd52bab610390ebd9b16ef
2018-05-31 16:27:14 +01:00
Translation updater bot c3363cadae Localisation updates from https://translatewiki.net.
Change-Id: I4070d78d1e7e5ef425ac86294be6e81f9d8583d5
2018-05-29 22:24:43 +02:00
Translation updater bot 7ba27bb832 Localisation updates from https://translatewiki.net.
Change-Id: Ibc4dad7b91176083fc8fb721f960eaaee6f593a8
2018-05-28 22:41:56 +02:00
libraryupgrader ccc3bd2b60 build: Updating mediawiki/mediawiki-codesniffer to 20.0.0
Change-Id: Id797b943c9362b9a327d831284c22838d449d8c0
2018-05-26 01:25:02 +00:00
Translation updater bot 18a2b83694 Localisation updates from https://translatewiki.net.
Change-Id: Id04df14cbc15cda40051955fea054f2842a92d87
2018-05-25 22:14:06 +02:00
Translation updater bot fda8af39b3 Localisation updates from https://translatewiki.net.
Change-Id: Ib69d038dd60ede84108f48c7f1fcacc8a3f8b160
2018-05-24 22:24:44 +02:00
Translation updater bot e6506cdd08 Localisation updates from https://translatewiki.net.
Change-Id: I9f3f34ac163664fcbffe7b1d20d58813bd9c25f4
2018-05-23 22:20:08 +02:00
Translation updater bot 5b5824dabe Localisation updates from https://translatewiki.net.
Change-Id: I35ab3e7ab5ee261eb361da2cd0d3fe1ffaa3a196
2018-05-22 22:20:38 +02:00
Translation updater bot 3640f87085 Localisation updates from https://translatewiki.net.
Change-Id: I9056184ec924f3fa96031ba318041de48470fc3a
2018-05-20 22:44:17 +02:00
Umherirrender 2e4222bd04 Remove reference to archived InlineEditor
Change-Id: Ie549357942a321962e5886c767d36975074f6cb6
2018-05-17 19:24:39 +02:00
Thiemo Kreuz 0fe9dbb366 Don't expect objects by reference in hook handlers
The motivation for this patch is to make the code less complex, better
readable, and less brittle.

Example:

public function onExampleHook( Parser &$parser, array &$result ) {
    /* This is the hook handler */
}

In this example the $result array is meant to be manipulated by the
hook handler. Changes should become visible to the caller. Since PHP
passes arrays by value, the & is needed to make this possible.

But the & is misplaced in pretty much all cases where the parameter is
an object. The only reason we still see these & in many hook handlers
is historical: PHP 4 passed objects by value, which potentially caused
expensive cloning. This was prevented with the &.

Since PHP 5 objects are passed by reference. However, this did not
made the & entirely meaningless. Keeping the & means callees are
allowed to replace passed objects with new ones. The & makes it look
like a function might intentionally replace a passed object, which is
unintended and actually scary in cases like the Parser. Luckily all
Hooks::run I have seen so far ignore unintended out-values. So even if
a hook handler tries to do something bad like replacing the Parser
with a different one, this would not have an effect.

Removing the & does not remove the possibility to manipulate the
object. Changes done to public properties are still visible to the
caller.

Unfortunately these & cannot be removed from the callers as long as
there is a single callee expecting a reference. This patch reduces the
number of such problematic callees.

Change-Id: Ib3a9da257b50326d569ab1973b523c952963c16b
2018-05-17 17:09:55 +00:00
Translation updater bot 9c2789ca6e Localisation updates from https://translatewiki.net.
Change-Id: Iba93fe20dc568ccf33dff04bcc5e3f6fbef738e7
2018-05-16 23:07:37 +02:00
Translation updater bot ddcd9e644a Localisation updates from https://translatewiki.net.
Change-Id: I6c0ddba62a4ec75192123b9c9a685ce21be1632b
2018-05-15 22:24:26 +02:00
Thiemo Kreuz 8a42f61697 Remove all default "return true" from all hook handlers
This is the default for many years now. Returning true does nothing. It's
identical to returning nothing (null). The only meaningful value a hook
handler can return is false, and even this is meaningful only for very
few hooks.

TL;DR: A "return true" in a hook handler is always meaningless, dead code.

I'm interested in this because we (WMDE) might start working on this
extension soon and I want the code to be small and easy to maintain.

Change-Id: If4f32a55cdc38a3cc8af286d1cca7c0089bbfc43
2018-05-15 10:43:23 +02:00
Translation updater bot 440d3678e8 Localisation updates from https://translatewiki.net.
Change-Id: Ibf12746b038b4424107565fa2d423cc55bc61638
2018-05-14 22:44:11 +02:00
jenkins-bot 1629de5222 Merge "Use MWPreviewElement in view mode, instead of building a view node" 2018-05-14 09:27:50 +00:00
Translation updater bot c97dcc221a Localisation updates from https://translatewiki.net.
Change-Id: I61973e8c86c466095d1193a5c240f9807a31bd61
2018-05-13 22:17:53 +02:00
Ed Sanders 475d825918 Use MWPreviewElement in view mode, instead of building a view node
Also "unwrap" paragraphs using CSS instead of DOM manipulation.

Change-Id: I5565c2c43580d5d47bc65ee06d9d14fccace90c6
Depends-On: Ibbf989dcebf2d21fd2ac481f17062f366ff29e41
Depends-On: I284bcd5dd25cdbb883427ebacb41af1bbf50b60f
2018-05-13 20:01:19 +01:00
Ed Sanders a08febb0af Simplify toolbar registration
VE-MW toolbars now define a placeholder for reference toolbars.

Depends-On: I0bace5e5fe05f9c214d57a74c478b48a7dcaec3b
Change-Id: I7cb0f1f1affbfd7a4013f396b1423b6f84da52ab
2018-05-12 16:42:08 +01:00
Ed Sanders bc20690b88 Give Cite a version number
This allows other extensions to depend on it (e.g. Citoid).

Change-Id: I27eba2c693cad98ee2a854ac7a52329e19d2fa71
2018-05-12 13:28:50 +01:00
jenkins-bot fc0fd39389 Merge "Use ve.ce.nodeFactory.createFromModel" 2018-05-11 19:32:59 +00:00
Ed Sanders 2ae4cfe0ab Use ve.ce.nodeFactory.createFromModel
Also use ve.dm.nodeFactory.createFromElement

Depends-On: I259face33154b795143c8820abdfb6b4a495f141
Depends-On: I7fc539f75a1c9d672efc139b7884ecdfdff5f301
Change-Id: I032182616c409e65138b16fe7b238e7f7b3a8710
2018-05-11 17:08:12 +00:00
Translation updater bot a852fee21b Localisation updates from https://translatewiki.net.
Change-Id: I534fdcb01f79036b4bb29e400ebe1bb2b23a81e8
2018-05-10 22:20:22 +02:00
Translation updater bot 9e9a23add4 Localisation updates from https://translatewiki.net.
Change-Id: Iccef4a5f068d266f56ed73e3735bd0c9be03a248
2018-05-08 22:19:42 +02:00
Translation updater bot 54c889b4c2 Localisation updates from https://translatewiki.net.
Change-Id: I25634cea0854ffb10a9942a59c407c9965b6b9fd
2018-05-06 22:22:01 +02:00
Translation updater bot d3b4d73201 Localisation updates from https://translatewiki.net.
Change-Id: Id19a881da2e6b70783b40d6fb52386bef2670e0a
2018-05-05 22:14:25 +02:00
Translation updater bot f5c07a40b7 Localisation updates from https://translatewiki.net.
Change-Id: I415dc8c4f86f22defca2dc364093ef31a086b749
2018-05-04 22:14:35 +02:00
Translation updater bot 7e45271f56 Localisation updates from https://translatewiki.net.
Change-Id: I02b760d6e176e114a0306d169829cfe4497037f7
2018-05-03 22:20:57 +02:00
Translation updater bot 142ea1ebf1 Localisation updates from https://translatewiki.net.
Change-Id: I3851beadeb78ef407be7914704fd4a41bb661787
2018-05-02 22:16:15 +02:00
jenkins-bot cfd18814be Merge "Support directionality for reference" 2018-05-02 15:59:33 +00:00