Commit graph

1073 commits

Author SHA1 Message Date
thiemowmde fd90304b23 Make auto-generated reference names like name=":0" visible in VE
This is a prerequisite before any work related to T52568 (being able
to manually name references in VisualEditor) can start.

Why these names should not be hidden:
* We don't know if the name is actually part of the auto-generated
  sequence in the current article or copy-pasted from somewhere else.
* Manually given names that start with a colon are currently hidden
  even if they are unrelated to the auto-generated sequence.
* The information is highly relevant for users switching between VE
  and wikitext. Especially when a reference is used multiple times
  the relevant wikitext can be as short as <ref name=":0" />. The
  literally only information in this case is the number.

Since these numbers are still more technical than anything we make
them very dim to emphasize the contrast to non-numeric names.

Bug: T52568
Bug: T92432
Change-Id: I65cb6998cb5f8659cd9043f3d4aaeac1c5f69da8
2023-02-23 12:28:02 +01:00
jenkins-bot d1ed02e21d Merge "Fix icon of re-use reference tool" 2023-02-22 17:58:49 +00:00
Translation updater bot d190578c9c Localisation updates from https://translatewiki.net.
Change-Id: I3e7da01af17e7aa9dca3344cd89277fa67072549
2023-02-20 09:46:06 +01:00
Subramanya Sastry fa1cb6c6cd Parsoid CSS: Remove list-style-type styles added in e5a8b3ec
I copied these from the visualdiffing repo, but I may have
over-generalized these from some wiki that might have customized
this to all wikis. enwiki doesn't use this, for example.

In any case, this styling should be left to individual wikis.
similar to the argument in 8412fb64 where I removed CSS rules
for standard refgroups as overreach.

Change-Id: Ie37408d7a92af88e39e345eb464c6fa2210d57e3
2023-02-13 22:18:45 -06:00
Translation updater bot 88bbaba129 Localisation updates from https://translatewiki.net.
Change-Id: I7f37d8bb63a41c98f845e4c21e06a88223b3649c
2023-02-13 08:29:40 +01:00
Ed Sanders f292da4254 Fix icon of re-use reference tool
Also update documentation in qqq.json with newer icon names.

Change-Id: I3cefe65c78e9438a7d29fbcd436ffad043d500e2
2023-02-11 14:07:01 +00:00
Subramanya Sastry eee7a43d77 Parsoid CSS: Use more W3C-supported counter types
* This ensures that Safari can also render these counter styles
  since Safari doesn't support @counter-style CSS rules yet.

Change-Id: Ib104a6d22197037bae0c58766d3363176022add3
2023-02-08 13:20:47 -06:00
jenkins-bot 6427249c8b Merge "Parsoid CSS: mw-ref-linkback counter inits to -1, not 0" 2023-02-08 16:19:36 +00:00
jenkins-bot 951a5f4a34 Merge "Parsoid CSS: Remove default rendering for "standard" ref groups" 2023-02-08 16:18:30 +00:00
Translation updater bot 5cd7fa82a0 Localisation updates from https://translatewiki.net.
Change-Id: Idce3d50dfbd235dafede1c6238da70335415e21e
2023-02-08 08:39:25 +01:00
Subramanya Sastry b9400d1bf0 Parsoid CSS: mw-ref-linkback counter inits to -1, not 0
* This has always been a bug but was hidden because enwiki
  uses lower-alpha custom rendering and so we never noticed it
  when we tested this on enwiki.

* Fixing the default gets rid of the need to override this for
  every single language that defined a non-decimal counter.

* This also eliminates the need for some rules where the overrides
  were identical to the baseline definitions (counter-type is
  decimal and separator is '.').

Bug: T86782
Bug: T156350
Change-Id: I51f8a06c80bb897b66a0978b117fbc5560efd6cb
2023-02-07 20:59:23 -06:00
Subramanya Sastry 8412fb6406 Parsoid CSS: Remove default rendering for "standard" ref groups
* This was obviously a mistake for 'decimal' since the previous CSS
  would have rendered refs with the "decimal" group and refs without
  any group identically making it hard to distinguish between the
  two ref types.

* But, not all wikis define custom messages for these "standard"
  ref groups. So, by providing default rendering for these, we would
  need custom overrides for wikis that didn't define them (the vast
  majority). Instead, for wikis that define them, define wiki-specific
  CSS for these groups that can be added to their Common.css pages.

* Discovered as I set about trying to update CSS on wikis and my
  test wikitext with different groups were rendering decimal groups
  differently and I had no custom CSS for it anywhere.

Bug: T86782
Change-Id: I5598580e96eead94bb09574b2af5cef3ce4241c5
2023-02-07 20:45:29 -06:00
jenkins-bot b85fcb759c Merge "Mark config parameter as optional in context classes" 2023-02-02 17:08:53 +00:00
Translation updater bot 466f5331b1 Localisation updates from https://translatewiki.net.
Change-Id: Ie72e35230204399a3b2668dd2ef86ed5584595e4
2023-01-30 08:29:23 +01:00
Translation updater bot bfd01b97fe Localisation updates from https://translatewiki.net.
Change-Id: I744faafaa4a4824e1ae9ece7cef7e36a341452c9
2023-01-26 08:50:53 +01:00
Bartosz Dziewoński a845923a65 Specify document base URLs in more test cases
Depends-On: I0e301bef38d97fa2234aa901c787360d9fbde8a3
Change-Id: I07a8c097dba0f5572c0aedf4febdf1434063ea6f
2023-01-22 16:00:09 +01:00
jenkins-bot 0771532b25 Merge "Remove 'origTitle' in tests" 2023-01-09 18:50:12 +00:00
Translation updater bot 8c50157d78 Localisation updates from https://translatewiki.net.
Change-Id: I31fa4326793e8ea398af83fb2c6db03b5a5756cf
2023-01-09 09:25:43 +01:00
Subramanya Sastry d044c0c166 Parsoid CSS counters: Use child selectors instead of descendent selectors
In both cases:
(a) ref counter display for .mw-ref sups
(b) backlink labels in the references section for multiple named refs
the a-tags are direct children of the <sup>/<span> tag.

The child selectors are more precise. I am not really sure why we
went with descendant selectors in the first place.

Bug: T156350
Change-Id: If5be7cd14de40c2372f27ae5e2f32671c0a4e20c
2023-01-09 01:28:34 +00:00
Subramanya Sastry ea4c16c037 Ensure Parsoid's linkback ref CSS counters are properly incremented
* Turned out there were 2 counters defined on references li nodes.
* One was added as part of the extends functionality added by WMDE's
  book referenceing project.
* The other one was added as part of Parsoid's Cite CSS work.
* Since the counter increments were defined separately and applied
  to the same node, only one of the increments would apply.
  This breaks counter rendering on wikis where custom wiki-specific
  rules aren't defined in that wiki's Mediawiki:Common.css
* Discovered after running visual diff tests after ad919e37
  was deployed.

Change-Id: I826faac3564d63b8a4fbd80015fd5cc8f0069b7a
2023-01-07 19:36:55 -06:00
eranroz fef36c2da9 Remove lower-alpha hack
Lower-alpha is enwiki/community specific preference and as such should
be defined in Common.css of that wiki.

Bug: T326467

Change-Id: I1c254031185b130de90fad2410a21533e8c3ba96
Signed-off-by: eranroz <eranroz89@gmail.com>
2023-01-07 12:37:09 +02:00
Translation updater bot c42c4b88f1 Localisation updates from https://translatewiki.net.
Change-Id: I8d9b60ed936428cc9d79cb0ed5526f1f468ecd36
2022-12-29 10:01:01 +01:00
Bartosz Dziewoński c0746c7fa8 Remove 'origTitle' in tests
Depends-On: I0ad0a655380eb2fb29b5ac01e2e399ac550ce34a
Bug: T325766
Change-Id: Ib5c33aceb9430aba49c692552b54427e64a787f3
2022-12-22 17:57:41 +00:00
Bartosz Dziewoński b89db98b7a Use more realistic fake data in test cases
Change-Id: Ie5a30fe254bd69db4f8fe363baeb926282897d00
2022-12-22 10:47:15 +00:00
Translation updater bot ccaaec68f0 Localisation updates from https://translatewiki.net.
Change-Id: I8bf6a0f67c44f1e66580fcbd93b58f560b955cad
2022-12-21 09:14:24 +01:00
Translation updater bot 8013badd20 Localisation updates from https://translatewiki.net.
Change-Id: I3e4071ba144218f06ffc988ba0e66cdbf310626b
2022-12-19 09:03:36 +01:00
Translation updater bot 560e8a74e9 Localisation updates from https://translatewiki.net.
Change-Id: I3f9e9943956ed972003fc1c55296dba72a6341fa
2022-12-15 11:35:20 +01:00
Translation updater bot 5ac0d123f6 Localisation updates from https://translatewiki.net.
Change-Id: I2fd3796f7762743252982796ff9b861d181910b7
2022-12-13 08:16:41 +01:00
jenkins-bot 04427c2886 Merge "Parsoid CSS: Add (script-generated) language-specific counters" 2022-12-12 16:34:04 +00:00
jenkins-bot 6b6804e695 Merge "Parsoid CSS: Don't make enwiki's default the default for all languages" 2022-12-12 16:34:02 +00:00
Translation updater bot e94f6060fe Localisation updates from https://translatewiki.net.
Change-Id: I4d0c5f3f49d15ae98c64a037b7238dd28c1bc0d3
2022-12-01 08:15:07 +01:00
Translation updater bot eaf1c8d8c0 Localisation updates from https://translatewiki.net.
Change-Id: I83ad0d014dc01687256e1cd0c3ce3f6327dd9862
2022-11-21 08:15:32 +01:00
Subramanya Sastry ad919e3730 Parsoid CSS: Add (script-generated) language-specific counters
* These files were generated with the script in
  I3623e42d4cad7975813892a8f0f7765b74a638c5

* These styles mimic the behavior of Language::formatNumNoSeparators
  and Language::localizeSeparators used by a couple of methods.

  ReferencesFormatter:referencesFormatEntryNumericBacklinkLabel
  calls ReferenceMessageLocalizer::localizeDigits which calls
  that core Language method.

  FootnoteMarkFormatter::linkRef calls localizeDigits as well.

  - '.reference a*' CSS rules mimic linkRef localization
  - 'span[rel="mw:referencedBy" ]*' rule mimics localization
     of referencesFormatEntryNumericBacklinkLabel

* Overrode all hand-crafted language CSS files from previous
  patches. The content of some of those hand-crafted CSS files
  will end up in those wikipedia's Common.css -- specifically
  for es, fr, sv wikipedias.

  sv and es have non-canonical formatting strings that aren't
  handled by the script right now and so leaving them behind.

  I need to look at fr output more carefully, so leaving that
  behind as well. But the generated ones are more accurate when
  combined with the wiki-specific CSS files genreated by the other
  script that processes site messages.

* Some files could potentially be removed by looking at
  language fallback chains, but the redundancy is not a
  problem for now.

* Tweak the resource loader script to use "_" instead of "-"
  when looking for a resource file.

Bug: T156350
Change-Id: I000b4538bf2be681b85df5813efed083458a4281
2022-11-18 11:50:20 -06:00
Subramanya Sastry 8cfad38705 Parsoid CSS: Don't make enwiki's default the default for all languages
* The default formatting for linkbacks for multiple named refs is
  determined by the "cite_references_link_many_format" message.
  It is only defined in en.json as "<sup>[[$1|$2]]</sup>". $2 is
  the output of referencesFormatEntryNumericBacklinkLabel.

  So, change the default Parsoid CSS rule to match that.

* But, since we have shipped Parsoid CSS all this while with the enwiki
  default, temporarily add "ext.cite.style.en.json" with that enwiki
  default so that on deploy, enwiki citations in VE continue to display
  as before.

Change-Id: I6f4b0e25189284ad0950977752739e7dc2951fec
2022-11-18 11:43:50 -06:00
Bartosz Dziewoński 731b162d4e Undo use of .reference instead of .mw-ref in CSS counter rules
When these styles are loaded on a normal MediaWiki page containing
output from the old parser, they cause references to be duplicated.
Use .mw-ref for now, which is only present in Parsoid output.

This partially reverts d6705eb3f8.

Bug: T323343
Change-Id: I6f2d43a060bea7aa175bed80f1be2c3d8a4924b0
2022-11-18 15:56:53 +00:00
Bartosz Dziewoński 14bb8d8fa1 VE: Use <sup> instead of <span> in CE HTML
Parsoid now uses <sup> tags instead of <span>.
We already changed it in DM HTML a long time ago
(see ve.dm.MWReferenceNode.static.toDomElements).

Bug: T323343
Change-Id: If04a8bd36e0bb0c31e5f60ae54cb54f13fa65720
2022-11-18 13:11:23 +01:00
Translation updater bot 24c3102fa6 Localisation updates from https://translatewiki.net.
Change-Id: I9f58b7d79190b7801d01f30b6207fc266b5285b5
2022-11-18 09:17:44 +01:00
Translation updater bot 83158b3505 Localisation updates from https://translatewiki.net.
Change-Id: I7e93ffd351034791727ac0f86160722235c5e9d5
2022-11-17 08:26:39 +01:00
Translation updater bot 5e5949a539 Localisation updates from https://translatewiki.net.
Change-Id: Ia319e88d1c5cee3c7d7334ebe9fa97a836682e9e
2022-11-07 08:33:35 +01:00
Subramanya Sastry 47a622c001 Parsoid CSS: Fix counters needed for ol.mw-references
* Some wikis need a X.Y style numbering where X is the
  counter for the reference number in the list (mw-references),
  and Y is the named-ref counter (mw-ref-linkback).

* Rather than have the mw-references counter be defined for
  specific languages, it is useful to have defined for all
  wikis and use it where needed.

* Not sure why the ol.mw-references reset the mw-ref-linkback
  counter. It needed to be reset for every item.

* While at it, made a couple CSS rules in kn and fa be more
  specific so it is clearly what they are used for.

Change-Id: I6dd35303f134cc4996e134867ecc2c0db7a5411f
2022-11-04 10:17:09 -05:00
Translation updater bot ae70af75ad Localisation updates from https://translatewiki.net.
Change-Id: I1eef1bba32cb6ff3b5c5653e6a816b9ebb7f91aa
2022-11-04 09:02:03 +01:00
Subramanya Sastry 08263ecad5 Tweak CSS defaults to handle Cite_references_link_many_sep properly
* The default separator (' ') should be set up as an :after selector
  and individiual wikis that define the _many_sep and/or _many_and
  messages can override this appropriately.

* Update frwiki overrides accordingly. It has an additional <sup>
  in the Cite_references_link_many message. frwiki also defines the
  Cite_references_link_many_and message.

Change-Id: Ia9ce6ac8eaa5b8386d4a586c620959465da73ef1
2022-11-02 18:48:17 -05:00
Subramanya Sastry b588a548bf Parsoid CSS: Add language specific overrides for es, hu, it, sv
* These styles are biased towards Wikipedia.

Bug: T156350
Change-Id: I417c9182fad7dcab85bdca48d4043cd65cd06ca1
2022-11-01 15:45:32 -05:00
Subramanya Sastry d6705eb3f8 Parsoid CSS: Migrate to using .reference instead of .mw-ref
* As part of T265930, in order to reduce the CSS rules that needed
  to be added, we started using the .reference class that the
  original Cite implementation uses.

* Let us migrate styles to using that original class as well.

* Since Parsoid emits a <sup>, we no longer need some of the
  CSS rules on .reference. With the class name change, the
  other rules are duplicates since we inherit the rules from
  ext.cite.styles.css. This effectively eliminated all CSS
  rules for ".reference" from ext.cite.style.css

* Admins on wikis will get the following guidance:
  - where similar styles apply to legacy output and Parsoid output,
    use the .reference class in Commons.css
  - where specific styles apply to Parsoid output but not legacy,
    use the .mw-ref class in Commons.css

* Once we have fully migrated all wikis to Parsoid output, we can
  migrate all the ".mw-ref" rules to ".reference". We then stop
  emitting the ".mw-ref" class in Parsoid output.

Change-Id: I5a8c540dc5b045ffff8c280262595f5281cd167d
2022-11-01 15:43:16 -05:00
Translation updater bot 30a3cb2737 Localisation updates from https://translatewiki.net.
Change-Id: Id717073d71df9469c6a32127ebf1fe2670fbdb2e
2022-11-01 08:51:34 +01:00
Translation updater bot be3432202f Localisation updates from https://translatewiki.net.
Change-Id: Ide0a0d079b900fb3714ce683c9d42a3d5046fdf6
2022-10-31 09:45:26 +01:00
jenkins-bot 46366167e5 Merge "Restore styling for cite warnings" 2022-10-24 20:52:50 +00:00
mainframe98 b6e5601eb1 Restore styling for cite warnings
This broke as a result of T280766.

Bug: T321450
Change-Id: I4673b769612b280dde1943d79aa16dcd7d6a8052
2022-10-24 18:14:19 +00:00
Translation updater bot 16c6aeb54d Localisation updates from https://translatewiki.net.
Change-Id: If27620aea637c88c337e19580fee03f7be445bfe
2022-10-24 08:22:19 +02:00
jenkins-bot ba468aaf14 Merge "Add language specific CSS overrides for a few languages" 2022-10-22 03:27:48 +00:00