4 commits

Author	SHA1	Message	Date
Thiemo Kreuz	f94b400474	Make most existing Cite tests pure unit tests ... 1. Most existing CiteTests can be unit tests. They run so much faster this way. 2. I modified some test cases to cover all trim() in the code. 3. The strict type hint in CiteHooks is removed because the parameter is not used. Having a hard type hint for what is effectively dead code makes the code more brittle for changes done outside of this codebase. Change-Id: I1bff1d6e02d9ef17d5e6b66aeec3ee42bba99cf4	2019-11-12 14:56:40 +01:00
Thiemo Kreuz	042a4ecf7a	Add basic unit tests for all 3 hook classes ... Change-Id: Ib444717465f8dda96c89afd8b2d60336e8bcdeec	2019-11-12 11:11:45 +00:00
Thiemo Kreuz	7ce10d7539	Remove lazy registration of Parser related hooks ... To be honest I don't get why this lazy registration was done in the first place. None of the 4 other hooks should ever be called before the ParserFirstCallInit hook got called. Also, under which circumstances can the ParserFirstCallInit hook be called more than once? Both scenarios would be wrong, as far as I'm concerned. Either I'm missing something, or this code can indeed be simplified. Maybe it was something to make it more compatible with older MediaWiki versions? The only reason I can think of is: in all situations that do not involve a parser, having the 4 extra hooks registered is pointless. Does this waste space and/or runtime in the $wgHooks registry? Change-Id: I5ef1495f4ce7bce940fa5f8e700af3d2c4851a01	2019-11-12 11:47:55 +01:00
Thiemo Kreuz	ae01d35bf2	Add basic test coverage for all CiteHooks code ... This also updates an existing test to cover all trim() in the code. Change-Id: I0f0b4f8154004f941f4eaa5a9b2c3be0598fb137	2019-11-08 15:59:01 +01:00