Commit graph

3887 commits

Author SHA1 Message Date
Timo Tijhof fb2c7c37db Combine ext.cite.visualEditor.data into ext.cite.visualEditor
Rather than depending on a separate module with one line of generated
JS code, generate it as a prepended statement to the same module.

Should be a no-op.

Depends-On: I809951d34feb2dbd01b7ae0f4bd98dac7c3f6fe2
Change-Id: I5886bf9f82025048976b7750e8cb751681021fb4
2021-11-19 16:56:51 +00:00
Ed Sanders 1a2ae0682f ve-cite: Use proper method for comparing linear data (attempt 2)
In Ifb0ba3caf8d we removed this reference equality check and replaced
it with a deep object comparison, however due to the fact that
hashes for MWReferenceNodes were simplified in I8c26686d7b to
improve visual diffs, this resulted in a overly simplified comparison
that couldn't distinguish references with the same "name".

Instead do a deep object comparions of the standard node hash object.

Tests added in Ia0bbd40528 assert that this doesn't result in the
regression that caused T296044.

Bug: T296086
Change-Id: I7b37fb54e14bfe28a07f722a2c45fd4e4a2d44f2
2021-11-19 14:24:42 +00:00
Ed Sanders e539a60fb9 ve-cite: Add test for simple case of re-used reference
In our first case we have a reference re-used before it
is defined, but that doesn't trigger the bug that caused
T296044.

Change-Id: Ia0bbd40528228275f0a978a0a459388a04ea2e79
2021-11-19 13:51:21 +00:00
Ed Sanders 638dbbff60 ve-cite: Update CSS classes in tests
Change-Id: I4546a71d541e1d22a4c34e6d0f5173a993792ff9
2021-11-19 13:51:21 +00:00
jenkins-bot ea7f9bf0d3 Merge "Revert "Use proper method for comparing linear data"" 2021-11-19 00:59:20 +00:00
Bartosz Dziewoński 4fcc4bc42d Revert "Use proper method for comparing linear data"
This reverts commit bad697bd32.

Bug: T296044
Change-Id: Ie442e482aa3b60754fe457d835c4cf6400f42d94
2021-11-19 00:35:28 +00:00
Translation updater bot d4c853e0f0 Localisation updates from https://translatewiki.net.
Change-Id: I5bd94ff0d6f6e71046889e3537a6199d1451df0b
2021-11-18 08:41:50 +01:00
Ed Sanders c8b691b8d1 Follow-up cf95dbd: Fix incorrect scope in loop
Change-Id: Iae5ec0321e19bfa1c5f53326bf9d9a3082d96f77
2021-11-15 14:39:15 +00:00
Translation updater bot 021e456751 Localisation updates from https://translatewiki.net.
Change-Id: Ife5dc45d0f4935586ce37027758a887ee8f1c626
2021-11-15 08:11:20 +01:00
Timo Tijhof 635850aae8 build: Remove unused npm package fields
The name/version/desc keys are not used and usually not set when the
repo package is marked "private", as the case for repos where npm is
only used for development purposes.

Change-Id: Idf796dfa5cc269109c7be397764850ee4ffe04e6
2021-11-10 20:28:30 +00:00
jenkins-bot 0a8a7d41d4 Merge "build: Update eslint-config-wikimedia to 0.21.0" 2021-11-09 18:18:09 +00:00
jenkins-bot cc111ca5fd Merge "Move eslint client config to modules, fix warnings" 2021-11-09 18:14:37 +00:00
jenkins-bot a11cf9858c Merge "Move var declarations inline" 2021-11-09 18:14:35 +00:00
Ed Sanders cb60e7aa04 build: Update eslint-config-wikimedia to 0.21.0
Change-Id: I86a44d7c73a107fb318abeda9e503e99083f48db
2021-11-09 14:25:34 +00:00
jenkins-bot a90c67b6e8 Merge "Use proper method for comparing linear data" 2021-11-09 14:00:01 +00:00
Translation updater bot 06938337e5 Localisation updates from https://translatewiki.net.
Change-Id: I6c12f73274cbc10ed9d2103baffde73b4b66c68c
2021-11-05 08:16:57 +01:00
libraryupgrader 434462a7e5 build: Updating validator to 13.7.0
* https://npmjs.com/advisories/1004784 (CVE-2021-3765)

Change-Id: Idc38efc79e39f019e555aedfab71ea6edf5e3563
2021-11-04 10:17:23 +00:00
Ed Sanders 0d4bb626f1 Move eslint client config to modules, fix warnings
Change-Id: I86857b82fa7d5c47c0056da4ad270fcb2a4d965f
2021-11-03 16:38:31 +00:00
Ed Sanders cf95dbd4be Move var declarations inline
Change-Id: I824a65e72a72e5acf65c54a63299469f7acb649d
2021-11-03 16:38:31 +00:00
Adam Wight 3c02ee38b2 Clean up javascript code smells
These were discovered using SonarCloud.

Change-Id: Ie36fa248e4b395bb97b8969ece6688ec055afb55
2021-11-03 12:28:07 +00:00
Translation updater bot cb957cc565 Localisation updates from https://translatewiki.net.
Change-Id: Ie359d7a24f9bf10835464c75e97cfb33e515a1a7
2021-11-03 08:20:21 +01:00
Ed Sanders bad697bd32 Use proper method for comparing linear data
Previously we checked the elements were reference-equal
which is fragile and breaks when linear data freezing is
enabled in debug mode.

Change-Id: Ifb0ba3caf8d3e5a67c9694358cac12cc412fe723
2021-11-02 23:15:13 +00:00
Translation updater bot a0ffa6c3f9 Localisation updates from https://translatewiki.net.
Change-Id: I0441ed2deb270c9e9f7bab23269375672fe32826
2021-10-29 08:21:30 +02:00
Translation updater bot 38ba46ffed Localisation updates from https://translatewiki.net.
Change-Id: Id1fd289a871be6def14619a4e94e062d93414bfa
2021-10-28 08:27:19 +02:00
Translation updater bot ffe592653e Localisation updates from https://translatewiki.net.
Change-Id: I876d53a92164714647e9c960ce15c01a2a5971c6
2021-10-26 08:16:57 +02:00
libraryupgrader 4a615fe4e9 build: Updating mediawiki/mediawiki-codesniffer to 38.0.0
Change-Id: I26ab18b7e156c7598f50eb2b15030a132abdbb0d
2021-10-24 00:42:12 +00:00
Translation updater bot 67f8c5cd23 Localisation updates from https://translatewiki.net.
Change-Id: I9157ceb33818cacdd23cee8fd24ced0a864bbf54
2021-10-22 08:14:44 +02:00
Translation updater bot 9a94b09f0c Localisation updates from https://translatewiki.net.
Change-Id: Id4131a628619feefb12f07019c23b02565d4bd2f
2021-10-20 08:36:29 +02:00
Translation updater bot b5f979db1b Localisation updates from https://translatewiki.net.
Change-Id: I6dac2823513fee31b0252cda244e7a6d05a09c95
2021-10-18 15:19:34 +02:00
Adam Wight 53d055d1e4 Only the "show/hide options" button should be hidden
We added this line in order to make the sidebar show/hide behavior
the same as the new VisualEditor template dialog, but it should have
only affected this one button.  When additional actions are added,
such as Citoid's "change reference type" button, these should still
be available.

Bug: T293280
Change-Id: I6b2c716fff991781e36ba21b541ea2ff918cfeb3
2021-10-15 13:42:48 +02:00
C. Scott Ananian 30cfb7c05a Rename deprecated usage of ParserOutput::{get,set}Property()
Bug: T287216
Depends-On: Ie963eea5aa0f0e984ced7c4dfa0fd65d57313cfa
Change-Id: Id4581c6c45f9fc4690900a30d8172951bc461a1b
2021-10-08 10:12:05 -04:00
Translation updater bot 4c55bcbd94 Localisation updates from https://translatewiki.net.
Change-Id: I15bdf21a6913116a26f0db2d35c41bff9189b8d2
2021-10-06 09:28:06 +02:00
libraryupgrader 33e2ff79b5 build: Updating npm dependencies
* @wdio/mocha-framework: 7.4.6 → 7.13.2
  * https://npmjs.com/advisories/5197 (CVE-2021-3807)
* ansi-regex: 5.0.0 → 5.0.1
  * https://npmjs.com/advisories/5197 (CVE-2021-3807)

Additional changes:
* composer.json: Updated phpcs command in composer test (T280592).
* composer.json: Added phpcs command to scripts (T280592).

Change-Id: I9aa26cf3664857fac671dc15718e5341798625d2
2021-10-04 13:21:21 +00:00
Translation updater bot 00c1a28db6 Localisation updates from https://translatewiki.net.
Change-Id: I1e3932d60abf27cdab341530ce2f948b9dc65f98
2021-10-04 08:55:28 +02:00
Translation updater bot ca7e992234 Localisation updates from https://translatewiki.net.
Change-Id: Id817e900b7a78973f3b3f99bbd366668d8ec3513
2021-10-01 09:29:40 +02:00
Subramanya Sastry ed59e2ac38 Sync up with Parsoid citeParserTests.txt
This now aligns with Parsoid commit 29f8e7051529ecbb62fc52bff6726a4df8bf20c2

Change-Id: I165ee24e1b78bdf181fa45430fdec1549310c359
2021-09-30 15:00:56 -05:00
WMDE-Fisch a8ea95de72 Fix class doc block for VE action
Seems to be a copy&paste leftover.

Change-Id: Ie5c06dd0d880663a0a4f1bfeb082a106811f03e7
2021-09-30 10:13:39 +00:00
Translation updater bot 79fc5b898e Localisation updates from https://translatewiki.net.
Change-Id: Id4eae6b5d47b9657088d5766c23b09ef534462b2
2021-09-30 08:57:12 +02:00
Translation updater bot 8ad00930a0 Localisation updates from https://translatewiki.net.
Change-Id: I44760079ed1dc6e51c65ccae2454f75c7643f629
2021-09-29 09:01:33 +02:00
jenkins-bot ecf603a5fd Merge "Make citation dialog behave more like VE" 2021-09-28 09:14:05 +00:00
Translation updater bot c62d362b61 Localisation updates from https://translatewiki.net.
Change-Id: I5e52490d75ef5ad89f7ea670716009ac0015eb88
2021-09-28 08:18:31 +02:00
Thiemo Kreuz 8902cea828 Use .containsValuableData() method from transclusion model
This is even more reliable because it also considers auto-values,
for example.

Depends-On: I522b888e366f066b28983a18041a8728d11623df
Change-Id: If83b9da65be9a759a82e8512ae171f802da9f597
2021-09-27 11:19:28 +02:00
Translation updater bot 6d512c7667 Localisation updates from https://translatewiki.net.
Change-Id: I4c470c517972cbe8322cddf93d99ba1df24f689d
2021-09-27 08:34:25 +02:00
Translation updater bot 3d14044c4e Localisation updates from https://translatewiki.net.
Change-Id: Ie8333fbd6f24dfb6422229a0648788f9ddc241f8
2021-09-23 12:27:21 +02:00
Adam Wight ca2ffa4853 Make citation dialog behave more like VE
Applies new sidebar features to the Cite dialog, according to the VE
feature flags.

Bug: T291241
Change-Id: I1b7c191ae8fd1fa01808ea1e84ba72551f3d2331
2021-09-20 11:44:51 +02:00
Translation updater bot 408786d3ca Localisation updates from https://translatewiki.net.
Change-Id: I10a1fb9928638e0f554b45f850a6ec67912ca5e8
2021-09-17 08:45:09 +02:00
Translation updater bot 01acd4f775 Localisation updates from https://translatewiki.net.
Change-Id: I8ad6037c5b00e14e4a825db085752a1ff42c6968
2021-09-16 08:11:25 +02:00
Translation updater bot 0938867c6d Localisation updates from https://translatewiki.net.
Change-Id: Iff6f56cb0848ea3690131c6385e4735e4c0298a4
2021-09-14 08:32:28 +02:00
Translation updater bot c72760da66 Localisation updates from https://translatewiki.net.
Change-Id: I6a165a1d30035e3c8e00c5147d86bb34442c7dd7
2021-09-10 08:15:19 +02:00
Translation updater bot 40aa379b43 Localisation updates from https://translatewiki.net.
Change-Id: I2a537a3cb9be4d7f09889404634115e561845d56
2021-09-09 08:17:17 +02:00