Commit graph

29 commits

Author SHA1 Message Date
Adam Wight 9535126304 [lint] Satisfy max-len rule
These changes mostly improve the code, and align the lint rules with
the MediaWiki base.

Change-Id: Ib4b0595fd9a9298039b8b44a0f1d4a9e90731527
2024-01-30 12:18:52 +01:00
mareikeheuer 1eb405eb54 Convert Cite extention to ES6
Bug: T343220
Change-Id: I769f0bfaa5af14d6ea4861ea738b44c98feb6193
2023-08-23 12:39:29 +00:00
Tim Starling 5315297f38 Migrate CiteVisualEditorModule to a virtual file callback
Depends-On: I97d61b5793159cea365740e0563f7b733e0f16de
Bug: T47514
Change-Id: Iabfbb6751707813b7ec68f49b35441ab5dbb5622
2023-05-05 16:25:14 +10:00
Ed Sanders d69f467482 CitationContextItem: Manually suppress the generic context item
Instead of relying on these classes always being descendants
of MWReferenceContextItem (which requires downstreams hacks
in Citoid).

Bug: T310290
Depends-On: I72daa1c5d2490c71591658f186c089ab899b5683
Change-Id: Idbd475a68efd1aff14217de3a05fa3dedc744487
2022-06-09 14:44:27 +00:00
Timo Tijhof bee357337c ve-cite: Export citationTools as native object instead of JSON string message
* Remove the overhead of serializing and then re-parsing client-side,
  instead assign it directly as native object literal.

* Move code for array slicing to PHP.

Change-Id: Iedcc8d57d3bddd3fa32a78b4e7ecc25615d94277
2021-12-07 12:53:24 +00:00
Timo Tijhof 471e73a7db ve-cite: Remove redundant check for visualeditor-cite-tool-definition.json
The server always defines this message as `cite-tool-definition.json`
in CiteVisualEditorModule.php, including a transparent fallback that
defines it with the content of `visualeditor-cite-tool-definition.json`.

Change-Id: I27426ed1947c1665e5284e64ec1946b1abeff7d1
2021-12-07 12:53:13 +00:00
Ed Sanders cf95dbd4be Move var declarations inline
Change-Id: I824a65e72a72e5acf65c54a63299469f7acb649d
2021-11-03 16:38:31 +00:00
Ed Sanders 309645a7ca eslint: Fix and enable the 'no-shadow' rule
Change-Id: I887003beaa3ee2e984b6f854b777485ca9e49049
2020-09-18 14:37:07 +00:00
Bartosz Dziewoński 1c4d5fd0de ve.ui.MWReference.init: Fix check for mobile target
This stopped working correctly after T218946, when we merged
MobileFrontendArticleTarget with its parent class MobileArticleTarget.

Bug: T233181
Change-Id: I9ec3f42508809431aef86157c20d8d6bb2fb12e5
2019-09-18 04:11:51 +02:00
Ed Sanders 625047f513 Define default icons for core citation types
Duplicating these icon names across every wiki
makes it harder to change the icons when changes
are made to the OOUI icon set.

Bug: T217132
Change-Id: Iba19f92cdadc64865b9c4d9d2c2c74e0e2a66348
2019-04-12 15:01:35 +01:00
Ed Sanders 367e7a2803 Use upstream OOUI icons
Provide a mapping from the old icons to the new defaults
as the names are defined on-wiki.

Bug: T217132
Change-Id: I7fd22078789f4a06c5ed165a0c979fb543801af2
2019-04-12 14:11:47 +01:00
Ed Sanders a6c8d9b8bc Expose the list of citation tools
Bug: T219510
Change-Id: If848a7fbebf050cd1ba376e45c9be95a9ad98290
2019-03-28 15:47:46 +00:00
Ed Sanders 89dd1faa11 Remove generated cite-dialogs stubs
We generate stub MWCitationDialog sub-classes for each citation
type, e.g. cite-web, cite-news. The only override these sub-classes
provide is for the dialog title, providing "Website" instead of
"Cite web", however because of code in MWTemplateDialog, this override
isn't even used.

1. Make the 'citation' dialog (now 'cite') concrete by registering
   it, and allow a 'title' argument to be passed it.
2. Actually override the title, using the passed in argument.
3. Remove the stub generated citation dialogs.

This will also fix our tracking data. Current we are getting
window-open actions with the argument being a localised citation
type name, e.g. cite-Literatur, cite-אתר.

These will now all be tracked as 'cite' as we use the parent dialog.

Bug: T216248
Depends-On: I355e7fe4c2ea965f2ca91f0ab0430cfb95e56e0a
Change-Id: I661707b5f9d3d810e9391ad63bef546d4fcb29e4
2019-02-15 22:44:17 +00:00
Ed Sanders e0781b0c58 Fix typo in documentation
Change-Id: I25407db3025dace825afd0ca083eba4fc600955d
2018-11-13 23:42:35 +00:00
Ed Sanders a08febb0af Simplify toolbar registration
VE-MW toolbars now define a placeholder for reference toolbars.

Depends-On: I0bace5e5fe05f9c214d57a74c478b48a7dcaec3b
Change-Id: I7cb0f1f1affbfd7a4013f396b1423b6f84da52ab
2018-05-12 16:42:08 +01:00
Thiemo Mättig bbc1f2c91d Use standard form for @license tags
See https://spdx.org/licenses/

Change-Id: Ic091ebc3844abcd6de90b3241382fb4732200a6d
2018-03-20 03:18:37 +00:00
James D. Forrester 0999d771b6 doc: Bump copyright year
Also make the overly-terse statement clearer.

Change-Id: I752bb82444bf7cb41480076bace42331dc35a598
2018-01-02 17:05:50 -08:00
James D. Forrester 0d20873fa6 doc: Bump copyright year notice, 'team' name
Change-Id: Ia090c417a1aa716b255613199b5e49616bf0517a
2017-04-20 16:50:43 +00:00
Ed Sanders 04fca616e9 eslint: Re-enable wrap-iife and partially enable dot-notation
Change-Id: I8f5e8d7b4547337943ec6df8ffb3d8db9f466217
2016-11-15 12:59:21 +00:00
Ed Sanders a42c656c53 build: Replace jscs+jshint with eslint
Change-Id: Ibcfab289a6dd4dcac853aa2e5338516994067cd5
2016-11-02 12:50:48 +00:00
Ed Sanders f4240f13f9 Use 'super' to call parent methods
Change-Id: Iba051a1e84b2ea805d0b3795933587c735ec0d88
2016-11-02 12:43:14 +00:00
Ed Sanders 5f4b86a9be Use 'demote' only to move cite tools to insert group
Leave include as '*' as changing it to an array currently breaks
the wildcard functionality.

Also rewrite the hack slightly so it only modifies the list,
rather than overwriting it.

Bug: T139727
Change-Id: I041bad6346a4f39e967dca8cc610100463be0ded
2016-07-11 18:32:00 +00:00
Alex Monk 724d890541 Make it possible to send VE cite toolbar items to the 'insert' (other) group
To be merged with Ifd688ae6

Bug: T133727
Change-Id: Ic87f996f2a95ffe89999384c48f11745f251db0e
2016-06-29 13:36:14 +01:00
Alex Monk e284811889 Follow-up I454380c3: Update/fix some things I missed
Per Krinkle's comment

Change-Id: I527a694116939d0303a06556eb479201852e227d
2016-06-28 23:01:20 +01:00
Alex Monk 24f2d64edd Make visualeditor-cite-tool-definition.json always exist, rename to cite-tool-definition.json
Bug: T138573
Change-Id: I454380c392feea55483d00d4b7eec45bce04ff53
2016-06-25 00:37:20 +01:00
Ed Sanders 8a278dbb82 Remove icon properties from windows
Windows stopped supporting icons a while ago.

Change-Id: I2651a8e1e6b22515701d35a4684d1ed7bd858658
2016-03-29 12:33:13 +01:00
Ed Sanders 666beded00 VE: Lookup the correct command for the node
Bug: T128198
Change-Id: I564b0b3e8cf6906d108ee876cff03196065bd164
2016-03-02 18:23:11 +00:00
Ed Sanders f641f44628 VE: Fix toolbar hack
Change-Id: I2cad81a89ae0c55d4209bfef3a1db239381996ca
2016-02-04 23:06:06 +00:00
Ed Sanders 18f616b9b8 VisualEditor: Move code for Cite into this repo
This code has been developed over three years now in the repo of MediaWiki's
integration of VisualEditor. It has grown and developed significantly during
that time, but now is pretty stable. A number of hacks inside the MediaWiki-
VisualEditor code base have been used to prevent this code from being loaded
on wikis where the Cite extension is not deployed, but this state of affairs
is and always was meant to be temporary.

This code is under the MIT licence which is a tad messy, but not impossible.
It's clearly labelled as such. The list of authors has been updated to take
into account the influx of new functionality.

Bug: T41621
Bug: T104928
Change-Id: I39936ed83d5a60471a0a75da753f498e80aef234
2016-02-04 08:41:54 -08:00