105 commits

Author	SHA1	Message	Date
Adam Wight	ec091fe906	Reorder keys ... This doesn't make any functional difference, but helps minimize later patch Ida9612d14 Change-Id: Ice89bad02e077437d0df6fa9f51f90b4cab4837c	2019-11-26 17:06:01 +01:00
Adam Wight	38d7c09495	Tweak comment ... This makes it show up nicely in my IDE. Change-Id: Ic203a9dcb83c96c3324996e183b4dfc239f65eca	2019-11-26 17:03:40 +01:00
Adam Wight	55099a7b0c	Remove impossible condition ... Numeric `$name` is caught during validation. Change-Id: Id1c3e6717af38b0b1393c135732e084d261b53f6	2019-11-26 16:43:21 +01:00
Adam Wight	d1e0e6309b	Add some comments ... Change-Id: I012ad6cc52dc65f1b329febdc8e6441ac03c6463	2019-11-26 11:07:48 +01:00
Adam Wight	8453e3ecd7	Extract stack and state to a new class ... Most of this state is used to manage interactions with other state, and encapsulation allows us to hide data structures and access behind self-explanatory function names. The interface is still much wider than I'd like, but it can be improved in future work. There is one small behavior change in here: in the `follows` edge case demonstrated by I3bdf26fd14, we prepend if the splice point cannot be used because it has a non-numeric key. I believe this was the original intention of the logic, and is how the numeric case behaves. I've verified that when array_splice throws a warning about non-numeric key, it fails to add anything to the original array, so the broken follows ref disappeared. Bug: T237241 Change-Id: I091a0b71ee9aa78e841c2e328018e886a7217715	2019-11-25 14:06:32 +01:00