Commit graph

994 commits

Author SHA1 Message Date
Translation updater bot bc6eb2d680 Localisation updates from https://translatewiki.net.
Change-Id: Ic72e9519b4c54b6df486faf31a5f97e21d209387
2022-02-17 08:11:32 +01:00
Bartosz Dziewoński 25d474b866 Remove hack that hides ref errors unnecessarily
It was originally added in I661493ab2f in 2013, to hide errors that
would appear when templates containing re-uses of references were
previewed separately from the rest of the page.

It has been made unnecessary when VisualEditor was changed to render
wikitext fragments (such as previewing templates) using Parsoid rather
than legacy parser, in 2014: I8a61d2fab8.

However it wasn't removed then, and then Ide82c96db4 changed the
selector and made it more difficult to understand its purpose (and
caused T301845, seven years later), and then Iba0f25b3eb / I39936ed83d
moved it to this repo in 2016, and then everyone forgot about it.

Bug: T53141
Bug: T301845
Change-Id: I7ac5ed6544575877fe1b6f09951e58b35df9648d
2022-02-16 06:14:01 +00:00
Translation updater bot e241bcc287 Localisation updates from https://translatewiki.net.
Change-Id: If6ec86237901dc3db874e1e5184e6d74c1a86de4
2022-02-15 08:17:03 +01:00
Translation updater bot db4d981822 Localisation updates from https://translatewiki.net.
Change-Id: I1ea2425799f5a2423e9e837f6d33b9f5cc91ca24
2022-02-03 08:43:45 +01:00
Translation updater bot 1678a55352 Localisation updates from https://translatewiki.net.
Change-Id: Ife79d2aad37f1dd29d2f62987f5d8472872fe237
2022-02-01 08:26:46 +01:00
jenkins-bot 8e7093c865 Merge "ve-cite: Ensure references are always unique by generating originalDomElementsHash" 2022-01-31 18:58:03 +00:00
Ed Sanders 1e6968b5c0 ve-cite: Ensure references are always unique by generating originalDomElementsHash
This is a bit of an abuse of the originalDomElementsHash property.
In future we could add a 'uniqueId' attribute, but this would need
to be ignored in a few places in core.

Bug: T299378
Change-Id: I7d1eb362aeb74ba93f5225330226a95535746b92
2022-01-27 01:14:52 +00:00
Ed Sanders b677a88fcc ve-cite: Update diff tests with new ref list HTML
Depends-On: If4ca99fa4532b33f164e298b53cfa1e202035015
Change-Id: I8e45941401448b826fec37d3dba4d6b1d8e53671
2022-01-25 20:46:29 +00:00
Bartosz Dziewoński c22f35964a Update tests for the removal of doc-child-change wrappers
Depends-On: Ib29f23625de9151d50e0f3b7796b15ca9ed89133
Change-Id: I73efd3c581cbb561be3dfc9eeb3524d9f949ea83
2022-01-24 21:58:01 +01:00
Translation updater bot f2c7ac4622 Localisation updates from https://translatewiki.net.
Change-Id: I2c111266e09421c1d07ede4d99a1b3d32d2a6820
2022-01-21 08:13:44 +01:00
Ed Sanders a2c927f8b8 ve-cite: Handle ref nodes with mw:Error RDFa
Bug: T299378
Bug: T299672
Change-Id: I7bc7dfb4fb9c0c9b140b793e6e0b2d00b7fe67e0
2022-01-21 00:00:34 +00:00
Translation updater bot 76858930e2 Localisation updates from https://translatewiki.net.
Change-Id: I3449ea91fd9dc222614dcb6872693424a38ec5bd
2022-01-17 08:11:44 +01:00
jenkins-bot 7fb11b981e Merge "VE tests: Suppress XML warnings" 2022-01-11 18:15:55 +00:00
Translation updater bot 5fa2e7ff97 Localisation updates from https://translatewiki.net.
Change-Id: I4ce8c3d08786f663c219631f0a5b8364e2d76a7a
2022-01-11 08:22:53 +01:00
Ed Sanders 0ef557a509 VE tests: Suppress XML warnings
The XML validator can't handle unescaped < in attributes
so always throws a warning.

Change-Id: Ie49e4080c049dea6eea714abdeb37f6764baaa2a
2022-01-10 14:21:44 +00:00
Translation updater bot cc6ed9e306 Localisation updates from https://translatewiki.net.
Change-Id: Id060c827a35f49994be5f36369ce95d4acd89d3d
2022-01-10 08:11:04 +01:00
Translation updater bot 5045d7ef93 Localisation updates from https://translatewiki.net.
Change-Id: If16fc8280d464b315d9e290a0b8cb8d0493b23d0
2022-01-07 08:24:40 +01:00
jenkins-bot 5802551bae Merge "Use .test() instead of .match()" 2022-01-04 22:09:31 +00:00
Translation updater bot d050c6f48c Localisation updates from https://translatewiki.net.
Change-Id: I69e36c43f9efde457f3b419af36671c3f6b408f3
2021-12-31 09:41:58 +01:00
Thiemo Kreuz 7a2f271ce6 Use .test() instead of .match()
.match() returns the matches. But these are not needed here. The
boolean method is .test().

Change-Id: I9e6f13f25fb8ccc6d3e873288d1100f4a2a56b15
2021-12-29 18:24:22 +01:00
Translation updater bot c9a5442ee4 Localisation updates from https://translatewiki.net.
Change-Id: I1bd8c35a6a24c28b1c002e60eb495d04ce78c09b
2021-12-27 09:29:44 +01:00
Translation updater bot e6180d68fa Localisation updates from https://translatewiki.net.
Change-Id: I2b907c6460ac77b19566e7261897983ded694080
2021-12-23 08:37:48 +01:00
Ed Sanders 84489c15b3 Don't attach DOM nodes from the DM store to the main document
Bug: T298147
Change-Id: I194ff1d576547dc717c523a490083fbcf903d87c
2021-12-21 20:32:05 +00:00
Translation updater bot 378f031a00 Localisation updates from https://translatewiki.net.
Change-Id: Id8df69cf761472ac5807c16a5aead70a0e76dcee
2021-12-20 08:20:51 +01:00
Translation updater bot 32f7e6dbd6 Localisation updates from https://translatewiki.net.
Change-Id: I0579d423942ddbed2296cb72656a7b31a2e9b531
2021-12-17 08:16:52 +01:00
Translation updater bot 01df31ecef Localisation updates from https://translatewiki.net.
Change-Id: I640a4c2fc55d66789319918b3ed9c93b93623637
2021-12-14 08:42:30 +01:00
Translation updater bot b28834ebbd Localisation updates from https://translatewiki.net.
Change-Id: I6c138aab2d247c3a7dce5b1d5b3964dd9c12e524
2021-12-10 08:23:34 +01:00
Bartosz Dziewoński 90fb1eba04 ve.ui.MWReferencesListDialog: Fix exception caused by a copy-paste mistake
Follow-up to cf95dbd4be.

Bug: T297418
Change-Id: I7c3970cf5a9b3632438e96513e9e983a5527aa21
2021-12-09 20:53:50 +01:00
Timo Tijhof bee357337c ve-cite: Export citationTools as native object instead of JSON string message
* Remove the overhead of serializing and then re-parsing client-side,
  instead assign it directly as native object literal.

* Move code for array slicing to PHP.

Change-Id: Iedcc8d57d3bddd3fa32a78b4e7ecc25615d94277
2021-12-07 12:53:24 +00:00
Timo Tijhof 471e73a7db ve-cite: Remove redundant check for visualeditor-cite-tool-definition.json
The server always defines this message as `cite-tool-definition.json`
in CiteVisualEditorModule.php, including a transparent fallback that
defines it with the content of `visualeditor-cite-tool-definition.json`.

Change-Id: I27426ed1947c1665e5284e64ec1946b1abeff7d1
2021-12-07 12:53:13 +00:00
Translation updater bot db02766664 Localisation updates from https://translatewiki.net.
Change-Id: I877a7076611026b88529810919f35c888888f43e
2021-12-06 08:18:45 +01:00
jenkins-bot a55f2b97cc Merge "ve-cite: Use proper method for comparing linear data (attempt 2)" 2021-11-30 22:22:35 +00:00
jenkins-bot 345766683c Merge "ve-cite: Add test for simple case of re-used reference" 2021-11-30 21:59:59 +00:00
jenkins-bot ca53985924 Merge "ve-cite: Update CSS classes in tests" 2021-11-30 21:59:57 +00:00
Translation updater bot b8e80d9c11 Localisation updates from https://translatewiki.net.
Change-Id: Ie3e73467398dd5b684cbb006727cfbe316b70922
2021-11-29 08:11:20 +01:00
Translation updater bot 2594ab60f8 Localisation updates from https://translatewiki.net.
Change-Id: I18ecafb1930e6abcd1f269d0ce6475c970cfb8ca
2021-11-25 08:24:01 +01:00
Ed Sanders 1a2ae0682f ve-cite: Use proper method for comparing linear data (attempt 2)
In Ifb0ba3caf8d we removed this reference equality check and replaced
it with a deep object comparison, however due to the fact that
hashes for MWReferenceNodes were simplified in I8c26686d7b to
improve visual diffs, this resulted in a overly simplified comparison
that couldn't distinguish references with the same "name".

Instead do a deep object comparions of the standard node hash object.

Tests added in Ia0bbd40528 assert that this doesn't result in the
regression that caused T296044.

Bug: T296086
Change-Id: I7b37fb54e14bfe28a07f722a2c45fd4e4a2d44f2
2021-11-19 14:24:42 +00:00
Ed Sanders e539a60fb9 ve-cite: Add test for simple case of re-used reference
In our first case we have a reference re-used before it
is defined, but that doesn't trigger the bug that caused
T296044.

Change-Id: Ia0bbd40528228275f0a978a0a459388a04ea2e79
2021-11-19 13:51:21 +00:00
Ed Sanders 638dbbff60 ve-cite: Update CSS classes in tests
Change-Id: I4546a71d541e1d22a4c34e6d0f5173a993792ff9
2021-11-19 13:51:21 +00:00
jenkins-bot ea7f9bf0d3 Merge "Revert "Use proper method for comparing linear data"" 2021-11-19 00:59:20 +00:00
Bartosz Dziewoński 4fcc4bc42d Revert "Use proper method for comparing linear data"
This reverts commit bad697bd32.

Bug: T296044
Change-Id: Ie442e482aa3b60754fe457d835c4cf6400f42d94
2021-11-19 00:35:28 +00:00
Ed Sanders c8b691b8d1 Follow-up cf95dbd: Fix incorrect scope in loop
Change-Id: Iae5ec0321e19bfa1c5f53326bf9d9a3082d96f77
2021-11-15 14:39:15 +00:00
Translation updater bot 021e456751 Localisation updates from https://translatewiki.net.
Change-Id: Ife5dc45d0f4935586ce37027758a887ee8f1c626
2021-11-15 08:11:20 +01:00
jenkins-bot cc111ca5fd Merge "Move eslint client config to modules, fix warnings" 2021-11-09 18:14:37 +00:00
jenkins-bot a11cf9858c Merge "Move var declarations inline" 2021-11-09 18:14:35 +00:00
jenkins-bot a90c67b6e8 Merge "Use proper method for comparing linear data" 2021-11-09 14:00:01 +00:00
Ed Sanders 0d4bb626f1 Move eslint client config to modules, fix warnings
Change-Id: I86857b82fa7d5c47c0056da4ad270fcb2a4d965f
2021-11-03 16:38:31 +00:00
Ed Sanders cf95dbd4be Move var declarations inline
Change-Id: I824a65e72a72e5acf65c54a63299469f7acb649d
2021-11-03 16:38:31 +00:00
Adam Wight 3c02ee38b2 Clean up javascript code smells
These were discovered using SonarCloud.

Change-Id: Ie36fa248e4b395bb97b8969ece6688ec055afb55
2021-11-03 12:28:07 +00:00
Ed Sanders bad697bd32 Use proper method for comparing linear data
Previously we checked the elements were reference-equal
which is fragile and breaks when linear data freezing is
enabled in debug mode.

Change-Id: Ifb0ba3caf8d3e5a67c9694358cac12cc412fe723
2021-11-02 23:15:13 +00:00
Translation updater bot a0ffa6c3f9 Localisation updates from https://translatewiki.net.
Change-Id: I0441ed2deb270c9e9f7bab23269375672fe32826
2021-10-29 08:21:30 +02:00
Translation updater bot ffe592653e Localisation updates from https://translatewiki.net.
Change-Id: I876d53a92164714647e9c960ce15c01a2a5971c6
2021-10-26 08:16:57 +02:00
Translation updater bot 67f8c5cd23 Localisation updates from https://translatewiki.net.
Change-Id: I9157ceb33818cacdd23cee8fd24ced0a864bbf54
2021-10-22 08:14:44 +02:00
Translation updater bot 9a94b09f0c Localisation updates from https://translatewiki.net.
Change-Id: Id4131a628619feefb12f07019c23b02565d4bd2f
2021-10-20 08:36:29 +02:00
Translation updater bot b5f979db1b Localisation updates from https://translatewiki.net.
Change-Id: I6dac2823513fee31b0252cda244e7a6d05a09c95
2021-10-18 15:19:34 +02:00
Adam Wight 53d055d1e4 Only the "show/hide options" button should be hidden
We added this line in order to make the sidebar show/hide behavior
the same as the new VisualEditor template dialog, but it should have
only affected this one button.  When additional actions are added,
such as Citoid's "change reference type" button, these should still
be available.

Bug: T293280
Change-Id: I6b2c716fff991781e36ba21b541ea2ff918cfeb3
2021-10-15 13:42:48 +02:00
Translation updater bot 4c55bcbd94 Localisation updates from https://translatewiki.net.
Change-Id: I15bdf21a6913116a26f0db2d35c41bff9189b8d2
2021-10-06 09:28:06 +02:00
Translation updater bot 00c1a28db6 Localisation updates from https://translatewiki.net.
Change-Id: I1e3932d60abf27cdab341530ce2f948b9dc65f98
2021-10-04 08:55:28 +02:00
Translation updater bot ca7e992234 Localisation updates from https://translatewiki.net.
Change-Id: Id817e900b7a78973f3b3f99bbd366668d8ec3513
2021-10-01 09:29:40 +02:00
WMDE-Fisch a8ea95de72 Fix class doc block for VE action
Seems to be a copy&paste leftover.

Change-Id: Ie5c06dd0d880663a0a4f1bfeb082a106811f03e7
2021-09-30 10:13:39 +00:00
Translation updater bot 79fc5b898e Localisation updates from https://translatewiki.net.
Change-Id: Id4eae6b5d47b9657088d5766c23b09ef534462b2
2021-09-30 08:57:12 +02:00
Translation updater bot 8ad00930a0 Localisation updates from https://translatewiki.net.
Change-Id: I44760079ed1dc6e51c65ccae2454f75c7643f629
2021-09-29 09:01:33 +02:00
jenkins-bot ecf603a5fd Merge "Make citation dialog behave more like VE" 2021-09-28 09:14:05 +00:00
Thiemo Kreuz 8902cea828 Use .containsValuableData() method from transclusion model
This is even more reliable because it also considers auto-values,
for example.

Depends-On: I522b888e366f066b28983a18041a8728d11623df
Change-Id: If83b9da65be9a759a82e8512ae171f802da9f597
2021-09-27 11:19:28 +02:00
Translation updater bot 6d512c7667 Localisation updates from https://translatewiki.net.
Change-Id: I4c470c517972cbe8322cddf93d99ba1df24f689d
2021-09-27 08:34:25 +02:00
Translation updater bot 3d14044c4e Localisation updates from https://translatewiki.net.
Change-Id: Ie8333fbd6f24dfb6422229a0648788f9ddc241f8
2021-09-23 12:27:21 +02:00
Adam Wight ca2ffa4853 Make citation dialog behave more like VE
Applies new sidebar features to the Cite dialog, according to the VE
feature flags.

Bug: T291241
Change-Id: I1b7c191ae8fd1fa01808ea1e84ba72551f3d2331
2021-09-20 11:44:51 +02:00
Translation updater bot 01acd4f775 Localisation updates from https://translatewiki.net.
Change-Id: I8ad6037c5b00e14e4a825db085752a1ff42c6968
2021-09-16 08:11:25 +02:00
Translation updater bot 40aa379b43 Localisation updates from https://translatewiki.net.
Change-Id: I2a537a3cb9be4d7f09889404634115e561845d56
2021-09-09 08:17:17 +02:00
Translation updater bot efd8590420 Localisation updates from https://translatewiki.net.
Change-Id: I38cfab8051a01449caab2253b4b3fc9ef3ff484e
2021-09-06 08:20:27 +02:00
Translation updater bot a4e65b96ba Localisation updates from https://translatewiki.net.
Change-Id: I3dbbd6824a2ca5b0449574ce95e02267b8e60c6f
2021-09-02 08:26:01 +02:00
jenkins-bot 6f2c6d4ef8 Merge "Show empty reflist message on initial load and after switching too" 2021-09-01 16:48:10 +00:00
Translation updater bot b16f0d9e68 Localisation updates from https://translatewiki.net.
Change-Id: I99a39c2d7f759d03aaa890fa1365f7deab5c0d6f
2021-08-26 08:35:40 +02:00
Bartosz Dziewoński 28a8739ce5 Show empty reflist message on initial load and after switching too
The message was only shown when a new reflist was inserted, or when
any references were changed.

Bug: T284472
Change-Id: I7c1e981c93bf7e163f9fb747aad30a24e9a497f1
2021-08-24 12:24:07 +02:00
Translation updater bot 66125caae0 Localisation updates from https://translatewiki.net.
Change-Id: I633634a17f619b770828aebe952a8b4b922fbeb7
2021-08-19 08:13:13 +02:00
Translation updater bot ace7aff1db Localisation updates from https://translatewiki.net.
Change-Id: Id674072833a1dff7c4f15876a96109eb6c232992
2021-08-16 08:16:00 +02:00
Translation updater bot 095d3bf6a9 Localisation updates from https://translatewiki.net.
Change-Id: I56527e34a9a4bf2ef75f5e26a0b075d1253d31b9
2021-08-11 08:19:06 +02:00
Translation updater bot 60b3124734 Localisation updates from https://translatewiki.net.
Change-Id: I43fbe0ee2818205c821ecb892a86e0f019e90891
2021-08-09 08:23:37 +02:00
Translation updater bot ba7bfbd2a5 Localisation updates from https://translatewiki.net.
Change-Id: Ia05fa0aa665dbf29f72480f844c62264bd56029c
2021-08-04 08:14:41 +02:00
Translation updater bot c28ec1a826 Localisation updates from https://translatewiki.net.
Change-Id: I2d64466bde6b5ffc3514f702fdb0518c0b59c3aa
2021-07-27 08:13:14 +02:00
Translation updater bot 6beb1d25ba Localisation updates from https://translatewiki.net.
Change-Id: I7cb03d491de452ec6285775254c3d3d962d4a67b
2021-07-23 08:08:06 +02:00
Translation updater bot 34dbb86730 Localisation updates from https://translatewiki.net.
Change-Id: I9e1ce120c7fb87350262661a4785a561c26bdad8
2021-07-20 08:20:22 +02:00
Translation updater bot 0219e5b715 Localisation updates from https://translatewiki.net.
Change-Id: Id0d08c66442d0f420a884e899c35b599fe7e019e
2021-07-16 08:43:19 +02:00
Translation updater bot 6b5afb1088 Localisation updates from https://translatewiki.net.
Change-Id: I8b5d1c377d3245d60531893599a47176149949c2
2021-07-12 08:06:14 +02:00
Translation updater bot d435430956 Localisation updates from https://translatewiki.net.
Change-Id: I27fa58c4888cea3b095b082a174ff0b04dc6d5fc
2021-07-08 08:46:33 +02:00
Translation updater bot 28e4d02e10 Localisation updates from https://translatewiki.net.
Change-Id: Ib864ded260d8dd6546f8aea2969b7b0062bbf7cf
2021-07-07 08:07:46 +02:00
Translation updater bot 38e6af7c41 Localisation updates from https://translatewiki.net.
Change-Id: Ia5dcb95a46c67ec5b5e83eab930c8fdf2b4ca69d
2021-06-29 08:13:33 +02:00
Translation updater bot 647842b6ff Localisation updates from https://translatewiki.net.
Change-Id: Ie906c92e1940e848228d3f3c5e0af39717b87904
2021-06-28 09:22:51 +02:00
Translation updater bot 3cfbf69464 Localisation updates from https://translatewiki.net.
Change-Id: I93593aa14530128f3afdd34aa475fe9bfb3aa0a4
2021-06-21 14:11:27 +02:00
Translation updater bot c241590737 Localisation updates from https://translatewiki.net.
Change-Id: Ieab4d5bcf1d5cea1bfe90419221fb250d701c07c
2021-06-18 08:20:35 +02:00
Translation updater bot 30a5b3e5fd Localisation updates from https://translatewiki.net.
Change-Id: Iea7383e6802469716e4adada45c18d3140a3e2d8
2021-06-17 08:20:24 +02:00
Translation updater bot 617724f839 Localisation updates from https://translatewiki.net.
Change-Id: I3ffdf667f6b6a38819f49c4b37e73c6d0dbf9e84
2021-06-10 08:34:07 +02:00
Translation updater bot fc263cf08b Localisation updates from https://translatewiki.net.
Change-Id: I40a6662a2aa0224ec8a5a7c9e243a8016bedbcec
2021-06-08 08:35:45 +02:00
Translation updater bot 0898540621 Localisation updates from https://translatewiki.net.
Change-Id: I622fd7f4e41531b8203c684b9689c2bfebd180e9
2021-06-07 08:41:36 +02:00
jenkins-bot b8e2187f77 Merge "Localisation updates from https://translatewiki.net." 2021-06-04 06:39:44 +00:00
Translation updater bot a8ffbc4191 Localisation updates from https://translatewiki.net.
Change-Id: Ifbd996c3e636cf28bd219b615ca73a663d29b3ef
2021-06-04 08:36:06 +02:00
Ed Sanders 299e5d3655 Avoid exceptions if node teardown happens before setup
Change-Id: I7f55091023a3c0e92ce216e51f24bbc423f136c7
2021-06-03 22:50:44 +01:00
Translation updater bot f4257fadd4 Localisation updates from https://translatewiki.net.
Change-Id: I8001f064b67374fb15bdf7821a72352dd6f335bd
2021-06-02 14:34:54 +02:00
jenkins-bot 2ce4860bce Merge "Change the button "Basic form" to "Basic"" 2021-06-01 13:59:28 +00:00
Translation updater bot cb002e220f Localisation updates from https://translatewiki.net.
Change-Id: I77f398ccbadbe9f1e8d9ef964e26287b89aa341d
2021-06-01 08:34:51 +02:00