Commit graph

30 commits

Author SHA1 Message Date
Robert Rohde 75004e338f Extends Cite to allows <ref> content to be defined within a <references> block
See comments on Bug 5997, Bug 15724, and discussion at:
 http://en.wikipedia.org/w/index.php?title=Wikipedia_talk:Citing_sources&oldid=304222618#Improving_.3Cref.3E
2009-07-26 22:15:13 +00:00
Andrew Garrett 43a4822175 Improve Cite references caching by making it dependent on a config setting, which defaults to off.
This way, we can still use it as emergency optimisation if the need arises.
2009-02-12 18:02:27 +00:00
Tim Starling 813c686a03 Don't double-parse messages, it breaks lots of things. Fixes bug #17442. 2009-02-11 06:34:39 +00:00
Andrew Garrett 598202b229 Re-implementation of r46725 (caching of Cite <references /> output).
This time, I've written a Parser method called serialiseHalfParsedText, which, as the name implies, grabs some half-parsed text, and fixes up all of the strip
markers, and link comments, and makes it safe to import some other time with unserialiseHalfParsedText. I tested it by live-hacking the cache key to be a constant,
and then putting <references /> on a completely different page, where it worked perfectly.
2009-02-03 04:58:08 +00:00
Andrew Garrett 4f0b501f07 Fix profiling mistake. 2009-02-03 04:57:48 +00:00
Andrew Garrett d35dbd9f50 Cache cite <references /> output by contents. That way, changes that don't affect Cite references won't cause a re-parsing of Cite, which is a big CPU hog on Wikimedia. 2009-02-03 04:57:28 +00:00
Brion Vibber 439ba88a51 Revert r46725, r46726 "Cache cite <references /> output by contents. That way, changes that don't affect Cite references won't cause a re-parsing of Cite, which is a big CPU hog on Wikimedia."
Causes data corruption in output due to misaligned strip markers.
2009-02-02 21:49:10 +00:00
Andrew Garrett 782b1a20c0 Fix profiling mistake. 2009-02-02 19:34:51 +00:00
Andrew Garrett fedbf8ccc8 Cache cite <references /> output by contents. That way, changes that don't affect Cite references won't cause a re-parsing of Cite, which is a big CPU hog on Wikimedia. 2009-02-02 19:29:02 +00:00
Robert Rohde b7b5f80537 revert of r46520 2009-01-29 10:13:12 +00:00
Robert Rohde 047c89b2c0 Move cite_error formatting wrapper into Mediawiki: space rather than hard coded in Cite_body.php 2009-01-29 05:10:07 +00:00
Alex Z. ca5c36c9b5 (bug 16854) Show an error message when a page has <ref> tags and no <references/>. Patch by Brad Jorsch. 2009-01-26 18:02:28 +00:00
Alex Z. 76837d57ea partial revert of 45771, mistaken commit? 2009-01-16 18:30:29 +00:00
Raimond Spekking f5f2927be5 Localisation updates for extension messages used by WMF from Betawiki 2009-01-15 16:45:03 +00:00
Tim Starling c3048a5e92 Reverting r45379 as per comment 5 on bug 16854, i.e. it doesn't work with section editing. 2009-01-07 13:10:29 +00:00
Chad Horohoe a82380d2a6 (bug 16854) Provide explicit error when <references /> is omitted. Patch by Brad Jorsch. 2009-01-03 18:59:22 +00:00
Aryeh Gregor f7969c9d4b Improve ugly interface for Sanitizer::escapeId()
Calling it with no extra arguments will now assume that you're escaping
a whole id, not an id fragment, which is safer.  Also, instead of ugly
bitfield-based options, I've changed the options to use an array of
strings.  I fixed all callers in trunk.  Out-of-tree callers that were
using Sanitizer::NONE will get correct behavior, while those that were
calling it with no arguments will get slightly changed behavior (an x
will be prepended).  I think this is harmless enough that we can skip
back-compat cruft here.

This should cause no visible changes.  No parser test regressions.
2008-12-30 00:22:14 +00:00
Steve Sanbeg 62c5542980 update comment 2008-10-04 22:26:45 +00:00
Steve Sanbeg 2cd561ea0e fix for bug 15770, allow <ref name=whatever></ref> for compatability with #tag 2008-10-01 19:56:40 +00:00
Aryeh Gregor 2cd995f73c Fix for last commit
My last commit didn't catch anything but plain <ref>: <ref name="foo"> would be allowed.  Fixed using a regex from the patch on bug 12757 by Max Semenik.
2008-09-18 17:21:13 +00:00
Aryeh Gregor 1c902f410c (bug 6199) Generate error for unbalanced <ref>s
This basically uses the patch I posted to that bug two years ago.  It's crude, but it should avoid the most common false positives while hopefully not causing too many false negatives.  It should be possible to refine it to avoid even more false negatives, but for the time being, this will at least prevent most of the constant headaches that newbies get when chunks of articles vanish because they forgot a closing </ref>.
2008-09-18 17:16:10 +00:00
Siebrand Mazeland 5bca5776eb * Fix common spelling error (seperate -> separate)
* Fix two more spelling errors in Translate extension messages
2008-09-15 20:28:25 +00:00
Aaron Schulz 6c824fd58d Consistent return array to avoid notices 2008-09-12 14:41:23 +00:00
Alex Z. e7454069b6 (bug 15517) - Use correct error message if group parameter is allowed (message already existed but was apparently unused). 2008-09-09 03:55:54 +00:00
Brion Vibber e8786ea9b5 Revert r38669 for now (Cite extension "add format=a option for alphabetic format").
It isn't obviously clear how this is meant to be used, and there are no test cases for the newly added mode.
Newly added code doesn't match our code standards, making it harder to read, and contains mysterious things like "$argv=array_merge($argv);" which seem a bit odd.
2008-08-08 19:11:31 +00:00
Steve Sanbeg a4ce1077d1 add format=a option for alphabetic format 2008-08-05 21:52:26 +00:00
Aryeh Gregor 9fcce4febe Delete Cite::validateName(). Use Xml::escapeId() instead. All parser tests pass. 2008-07-30 21:23:43 +00:00
Shinjiman c2d03f184b * (bug 14216) Grouping references link displays are urlencoded instead rendering the normal text
patch by fdcn
2008-06-18 18:42:52 +00:00
Roan Kattouw 2986a5a8d2 Cite: Fix bug 11224 (finally): in some obscure cases (notably when parsing for an anon without edit rights), Parser::clearState() somehow got in the call path of Cite::ref(), clearing the Cite state in mid-parse every time. I've worked around this by refusing to clear state if the state indicates we're in the middle of parsing something, but this is probably not a proper fix as there seems to be something deeply evil going on in the Parser (big surprise) causing it to clear state haphazardly. Anyone interested in further investigation should read the backtrace I posted on bug 11224 2008-06-16 14:04:39 +00:00
Brion Vibber 933caf85db Update a bunch of extensions to avoid unstubbing $wgParser early for setHook() on current MW versions. 2008-06-06 20:38:04 +00:00