Commit graph

32 commits

Author SHA1 Message Date
thiemowmde 2a8fdf3d81 Hide wrong "this reference is used 0 times" in citation dialog
This fixes a minor regression introduced in Ib003b8a. The problem is
that undefined is not equal to anything in JavaScript, and not smaller
than 2 either.

Bug: T241885
Bug: T335410
Change-Id: Ia6deb291d923b88a08ceac8fbc0efb682e14f358
2023-04-26 16:42:08 +02:00
thiemowmde ce63522726 Fix wrong "this reference is used twice" in VisualEditor
This patch also updates a second place that does almost the same.

That other place also excludes placeholders. We intentionally don't
do this in this new place.

Bug: T241885
Change-Id: Ib003b8a7bbe247db6f7da0a4efcfd4e5967fd033
2023-04-12 15:19:11 +02:00
Ed Sanders cf95dbd4be Move var declarations inline
Change-Id: I824a65e72a72e5acf65c54a63299469f7acb649d
2021-11-03 16:38:31 +00:00
Ed Sanders 85a4e23008 build: Update devDependencies
Change-Id: I38b506d6e058f639e0e7d95c3e60616dbef5af10
2020-06-09 11:29:03 +01:00
Bartosz Dziewoński 54bdd85060 ve.ui.MWReferenceDialog: Avoid exception when destroying
Bug: T236949
Change-Id: I430415d4c0921103af0939d087c2d066cd57369f
2019-11-28 19:49:16 +01:00
Ed Sanders 2a222b61d0 Remove deprecated TargetWidget APIs
Change-Id: Ib7feb57ce19f2db47a41561281d51aebd063f408
2019-11-15 16:30:27 +00:00
David Lynch eb37c893ea Extra tracking for VisualEditor's feature use
Bug: T221305
Change-Id: I1c681ec2da5fd7701d6c6b53f1f8a160dc885610
2019-07-08 11:04:52 -05:00
jenkins-bot dbf08269a6 Merge "Dialogs: Use close flag for close actions" 2019-07-02 19:01:35 +00:00
Ed Sanders 6af3bc1fe4 Remove citefromid alias support
Change-Id: I20aa82a3fdc16897abcb36874c17be31d41fda43
2019-06-20 16:08:58 +01:00
Ed Sanders d92e930bb6 Dialogs: Use close flag for close actions
Bug: T225021
Change-Id: I7915656896b502d6f2e19e38aae09d09d2bb8c49
Depends-On: I67b8474b0662f8dbc23c1b5ff883e3d4093bdbd4
2019-06-10 16:00:38 +01:00
jenkins-bot 64234cb793 Merge "Rename 'citefromid' to 'citoid'" 2019-04-11 11:00:58 +00:00
Ed Sanders 01ef641a66 VE: Use new object format for importRules
Add in missing mwTable types.

Change-Id: I4b2e81f8cd78c61d208a3ef6fdab43d0cc720cb5
Depends-On: I366a091ff4def66cc25200b3d1b2c23ba6b716f7
2019-04-09 19:03:49 +01:00
Ed Sanders e7a7f2107b Rename 'citefromid' to 'citoid'
Backwards compatible change can be merged ahead of change
in Citoid repo.

Bug: T219512
Change-Id: If4b920ba743030341e9cf6987c3d2ddc490992c9
2019-04-03 13:20:36 +01:00
Bartosz Dziewoński 17555dd934 ve.ui.MWReferenceDialog: Remove 'Use an existing reference' button
The same functionality is available using the 'Cite → Re-use' tool
on the toolbar (T214991).

We want to use the same location for a new 'Replace reference' button,
to be implemented in the Citoid extension (T208981).

Bug: T208981
Bug: T214991
Change-Id: I511e3c27a7d2175bdc2b6bdb648f04ac96cd1e0b
2019-02-26 00:30:56 +01:00
Ed Sanders 03711dfea8 Add support for read-only mode
Depends-On: Iedd1bd9ce17750ad8528c1a053293c4a7321c5de
Change-Id: I83bec9ea5b71aca0b4ef23237fad84aa6ea8a508
2019-02-22 14:13:57 +00:00
Ed Sanders e4efddbd0d Use new upstream defaults for actions
Allows us to remove action lists identical to the parent,
and also the default this.actions.setMode call.

Rename #canApply to #isModified for consistency.

Change-Id: I026feb291cd64474557d1f9df30604a7bbbb0bd2
2019-02-22 14:12:52 +00:00
Bartosz Dziewoński 2286e5fde1 Improve warning that reference is reused
* Show the warning in the context menu (on desktop only) in addition
  to the reference dialog.
* Add more details to the warning in reference dialog, and adjust
  spacing around it to make it more noticeable.

Bug: T208981
Bug: T212609
Depends-On: I6ca605ddd580d6259952c8799ecdca08da07474a
Change-Id: I23cc02f651c15b3276613d32a0c2537032f731c2
2019-01-10 02:01:09 +01:00
Volker E a30925d229 Replace deprecated 'advanced' by renamed to 'settings' icon
Bug: T190581
Change-Id: I2151c9d6b1b3f7306ed4e049a6bd2efb59787100
2018-09-07 19:59:40 -07:00
Ed Sanders fdc8107306 Use cog icon for options
Bug: T191099
Change-Id: I17783d02e154311dffafb9e9314d13b0e5cadff0
2018-04-04 13:15:56 +01:00
Thiemo Mättig bbc1f2c91d Use standard form for @license tags
See https://spdx.org/licenses/

Change-Id: Ic091ebc3844abcd6de90b3241382fb4732200a6d
2018-03-20 03:18:37 +00:00
James D. Forrester 0999d771b6 doc: Bump copyright year
Also make the overly-terse statement clearer.

Change-Id: I752bb82444bf7cb41480076bace42331dc35a598
2018-01-02 17:05:50 -08:00
James D. Forrester 9764bbb04e Replace constructive with progressive UI flag
Change-Id: I0edfb7ad13b12a0695f6cdc4afc9afcc82265183
2017-09-26 15:35:55 -04:00
James D. Forrester 347f21d11e VisualEditor: Add a placeholder to MWReferenceDialog to make it less awful when empty
Change-Id: I086d7243127ee411ea043bf29f4d4a5ae5d657a0
2017-06-17 01:21:48 +00:00
James D. Forrester 0d20873fa6 doc: Bump copyright year notice, 'team' name
Change-Id: Ia090c417a1aa716b255613199b5e49616bf0517a
2017-04-20 16:50:43 +00:00
Ed Sanders ee40877e83 Re-use target widgets
Depends-On: I5ed0591048a17e84077bde5490e05c0467d0394a
Depends-On: I5decb918f398704d4b6c108a16fbc1cc073ef077
Change-Id: Icba13d84e10cf18a6c68e26448b2efe93b8c42b8
2016-11-29 19:50:09 +00:00
Ed Sanders 43f56c81a8 Fix MWReferenceGroupInputWidget and uses
Now it is an actual input widget, remove references
to .input property.

Bug: T150491
Change-Id: I826a2cb5ecf98d0e35ccab804f2aa90bbff7ada2
2016-11-10 23:23:58 +00:00
Ed Sanders a42c656c53 build: Replace jscs+jshint with eslint
Change-Id: Ibcfab289a6dd4dcac853aa2e5338516994067cd5
2016-11-02 12:50:48 +00:00
Ed Sanders 1505000fe5 Use target widget factory method
Change-Id: I107afbb4f7e8ae97bdb27f3b5f7acd357dada414
2016-06-29 17:14:43 +01:00
Ed Sanders 96922a2aa0 Use commandRegistry from current surface, not target
This shouldn't make a difference for any current implementations
but in the future different surfaces my have different commands.

Change-Id: I383a4a76cda142107da2f8aa1c6a90c4307e3b97
2016-05-30 22:36:45 +01:00
David Lynch b92a32e08c Dialog: When reusing a reference, avoid popping up the group menu
The group picker menu will open momentarily when the input is changed, unless
it's disabled when the change happens. This was mostly visible when selecting
a reference from the "use an existing reference dialog", as a flash of the
menu in the top-left of the screen.

Bug: T125862
Change-Id: Ib6d3715f7d123545ba688bfbe850fe3c26ccb6e1
2016-04-26 11:08:14 -05:00
Ed Sanders 8a278dbb82 Remove icon properties from windows
Windows stopped supporting icons a while ago.

Change-Id: I2651a8e1e6b22515701d35a4684d1ed7bd858658
2016-03-29 12:33:13 +01:00
Ed Sanders 18f616b9b8 VisualEditor: Move code for Cite into this repo
This code has been developed over three years now in the repo of MediaWiki's
integration of VisualEditor. It has grown and developed significantly during
that time, but now is pretty stable. A number of hacks inside the MediaWiki-
VisualEditor code base have been used to prevent this code from being loaded
on wikis where the Cite extension is not deployed, but this state of affairs
is and always was meant to be temporary.

This code is under the MIT licence which is a tad messy, but not impossible.
It's clearly labelled as such. The list of authors has been updated to take
into account the influx of new functionality.

Bug: T41621
Bug: T104928
Change-Id: I39936ed83d5a60471a0a75da753f498e80aef234
2016-02-04 08:41:54 -08:00