Commit graph

5265 commits

Author SHA1 Message Date
Ed Sanders dca26d905d Disable mw-body-content clearfix in reflist
Bug: T337415
Change-Id: Ic94414a4b0e483b6f8945525d07ae7cbcb42045c
2023-05-24 17:22:28 +01:00
David Lynch 03bac936be Register a HelpCompletionAction group alias for cite
Bug: T66905
Depends-On: I7bc614c81ae3fc1e16d8fffd9f733186bdc9c472
Change-Id: I4a0242386bb595e04a9d72a8efcff9e8949260d4
2023-05-24 15:42:36 +00:00
jenkins-bot dc243e48aa Merge "Streamline/minimize duplicate code in reference node classes" 2023-05-23 14:09:22 +00:00
thiemowmde edcb4ddd0b Streamline/minimize duplicate code in reference node classes
E.g. reducing indention and utilizing convenient jQuery features.

Change-Id: I08fe9d4a09630042b28fc5e35cab4460be44a0d9
2023-05-23 10:54:56 +00:00
Translation updater bot 083cea9036 Localisation updates from https://translatewiki.net.
Change-Id: Idbc606f99ad61159eb4663196fdd83771c8ff59a
2023-05-23 08:22:23 +02:00
Ed Sanders d107f3d5a8 Fix ref list click-to-edit on mobile
On mobile, the first action is always 'mobileActions', so
ignore it.

Bug: T54750
Change-Id: I06e3f6225bf7a185680d89dee5b204a19a7a4fd7
2023-05-22 18:22:05 +01:00
Translation updater bot b8af25b157 Localisation updates from https://translatewiki.net.
Change-Id: I46e1d6e57aafc5081a838bbc4bc10261e922f2c7
2023-05-22 08:45:03 +02:00
jenkins-bot 933e7070b3 Merge "tests: Make PHPUnit data providers static" 2023-05-20 12:49:37 +00:00
jenkins-bot c9abd842a5 Merge "Add missing space to reference list rendering" 2023-05-20 10:29:49 +00:00
Umherirrender 66159e5b78 tests: Make PHPUnit data providers static
Initally used a new sniff with autofix (T333745)

Bug: T332865
Change-Id: Ib86d0fb2d3ea734db46b266faede7b4588fae075
2023-05-20 12:03:41 +02:00
Arlo Breault c37977aad2 Assume strings for dataMw->body properties in ref handlers
The diffHandler already has this expectation.

Bug: T337036
Change-Id: I0c3a3532c655df6777407a1e0af2d9bac9495037
2023-05-19 13:28:41 -04:00
Translation updater bot 12eba5384d Localisation updates from https://translatewiki.net.
Change-Id: I1a883f8d631c390e1ea72ae6aff5f83204868b53
2023-05-19 10:43:04 +02:00
Ed Sanders 744cbdb56b Launch reference editors from ve.ce.MWReferencesListNode
Bug: T54750
Depends-On: I502358a3229fbda44950f7f7513548d49d25e0c9
Change-Id: Idea26ffbc5ee859f6ad9456029af4180226c1a07
2023-05-17 16:05:02 +00:00
jenkins-bot 2ab7c55748 Merge "Render reference list on first load in idle callback" 2023-05-17 14:01:02 +00:00
Ed Sanders 8587e445a1 Render reference list on first load in idle callback
This means the reference list is always in sync with the model's
understanding of which references are available to edit.

An exception is left in if there are no references in the model
at all, as will be the case on he.wiki, as all references are
template generated. In this case we continue to use the Parsoid
DOM, so that there is a static rendering of the reference list.

Bug: T336865
Change-Id: Iaf1089c9de532e7749c9cb70a9e697917955dca8
2023-05-17 13:34:15 +00:00
thiemowmde e4e1a38e1e Add missing space to reference list rendering
Minimal test case:
 <ref name=a>a</ref>
 <ref name=a/>
 <references/>

This renders as "1. ↑ 1.0 1.1 a" in both the legacy parser as well
as Parsoid. The moment you start editing this in VisualEditor the
space before "a" disappears. This patch fixes this inconsistency.

Change-Id: Idfea1a445fc98a0433640b4f706fafcc4e236c18
2023-05-16 15:43:16 +00:00
thiemowmde b9d5ce7730 Document config flags in extension.json
Change-Id: Ife0c18b8e06980cdd23dae976749afdfb0cbd7e5
2023-05-16 09:57:54 +02:00
Translation updater bot 46a2205f5f Localisation updates from https://translatewiki.net.
Change-Id: Id06f53e8ab8d0b70388cf155419f84e493bdcf9d
2023-05-16 08:18:33 +02:00
jenkins-bot c985d9b0d0 Merge "Sync up Cite repo with Parsoid" 2023-05-16 04:38:24 +00:00
Translation updater bot a0ee5c363a Localisation updates from https://translatewiki.net.
Change-Id: Id62fcd146e13c46e3edb69c358561565fd720a6a
2023-05-15 08:32:01 +02:00
Arlo Breault 9177b50feb Sync up Cite repo with Parsoid
This now aligns with Parsoid commit 7b724ddc6c4abd44de2e1f67f64ca1d9685c6b4f

Change-Id: If24ad064d7d84fb070cb0c7976d56373e8a9db3a
2023-05-12 09:59:44 -04:00
jenkins-bot 78f02e22e3 Merge "Disabled tests to break circular dependency" 2023-05-11 18:41:59 +00:00
jenkins-bot fd8db433a6 Merge "Fix empty previews in reference reuse dialog" 2023-05-11 09:43:54 +00:00
Translation updater bot 79c3edaa3e Localisation updates from https://translatewiki.net.
Change-Id: If653baf2bc9e95fddc85f7e9e1dc693e32a10831
2023-05-11 09:13:41 +02:00
Arlo Breault 6ed2daec12 Disabled tests to break circular dependency
html/php sections are added since otherwise it complains that the
"Test lacks html or metadata section on lines"

Change-Id: Ib1c47be09bdbe1e84b595373ad71772f2a983fc9
2023-05-10 19:47:13 -04:00
thiemowmde 889c2ea011 Fix empty previews in reference reuse dialog
This fixes a minor inconsistency: A reference that comes from a
template and is already reused outside of the template is only
partially available to VE, and previewed with a warning message
because of this:

"This reference is defined in a template or other generated block,
and for now can only be previewed in source mode."

This was missing in the reuse dialog.

Note this patch is not meant to make any design decision, but to use
the existing design consistently.

You can test this with and without the Citoid extension. It works in
both cases.

Bug: T336372
Change-Id: I962cf111b1882bcd736f1090ca17d2b176495d2f
2023-05-10 13:03:24 +00:00
jenkins-bot d886cbd70f Merge "Migrate CiteVisualEditorModule to a virtual file callback" 2023-05-10 04:57:57 +00:00
Translation updater bot d6fbd0cc11 Localisation updates from https://translatewiki.net.
Change-Id: Ic98e2df23aabe41eb558fc8028334309661d2367
2023-05-05 10:38:10 +02:00
Tim Starling 5315297f38 Migrate CiteVisualEditorModule to a virtual file callback
Depends-On: I97d61b5793159cea365740e0563f7b733e0f16de
Bug: T47514
Change-Id: Iabfbb6751707813b7ec68f49b35441ab5dbb5622
2023-05-05 16:25:14 +10:00
libraryupgrader 421287cd58 build: Updating eslint-config-wikimedia to 0.25.0
Change-Id: I1ee4a9eb03e7e8dc22e1f69a87029a50d63e8d83
2023-05-05 02:11:54 +00:00
Translation updater bot b81e7bd0c5 Localisation updates from https://translatewiki.net.
Change-Id: I01c920c74716fc99c2d36de87239a65a15173df9
2023-05-01 09:57:21 +02:00
libraryupgrader 8ebcd80b46 build: Updating dependencies
composer:
* mediawiki/mediawiki-phan-config: 0.12.0 → 0.12.1

npm:
* grunt-eslint: 24.0.0 → 24.0.1

Change-Id: Ib701545627fe7b0ba9c6219f67693ae586d72e77
2023-04-29 00:59:28 +00:00
jenkins-bot 5acf1b54b8 Merge "Update parsertests with new media classes" 2023-04-26 17:44:00 +00:00
Arlo Breault 1c8a0115e9 Update parsertests with new media classes
Depends-On: Ifd4001e312a5fa4b7beaad63ba8c4e79e3201b9b
Change-Id: I80b76e2f4f538eba323f47cb2bf831016e2b2dc2
2023-04-26 13:19:58 -04:00
thiemowmde 2a8fdf3d81 Hide wrong "this reference is used 0 times" in citation dialog
This fixes a minor regression introduced in Ib003b8a. The problem is
that undefined is not equal to anything in JavaScript, and not smaller
than 2 either.

Bug: T241885
Bug: T335410
Change-Id: Ia6deb291d923b88a08ceac8fbc0efb682e14f358
2023-04-26 16:42:08 +02:00
Translation updater bot ad830cce16 Localisation updates from https://translatewiki.net.
Change-Id: Ibc776022544a8f73e77735dc1256135598fb676c
2023-04-25 08:47:26 +02:00
Translation updater bot 3c902a8f34 Localisation updates from https://translatewiki.net.
Change-Id: Ifb96b94e80763ea5e5e7d9f3582ca835f5a17823
2023-04-24 09:15:43 +02:00
Arlo Breault 984aa7750c Disable tests to break circular dependency
Needed-By: Ifd4001e312a5fa4b7beaad63ba8c4e79e3201b9b
Change-Id: Ie85ee7048273023a2c51f42a333a9c1493360404
2023-04-20 16:00:43 -04:00
jenkins-bot 23d7c3d3bf Merge "Fix wrong "this reference is used twice" in VisualEditor" 2023-04-17 06:40:44 +00:00
Translation updater bot a93bf69abc Localisation updates from https://translatewiki.net.
Change-Id: Iddc47ad6255118a105e89f824599f0311e758511
2023-04-13 08:45:53 +02:00
Ed Sanders ec88bde672 Drop IE CSS hacks
IE is no longer supported

Change-Id: I27901e87301a4ce0993f789913c83d151f264562
2023-04-12 16:33:23 +01:00
thiemowmde ce63522726 Fix wrong "this reference is used twice" in VisualEditor
This patch also updates a second place that does almost the same.

That other place also excludes placeholders. We intentionally don't
do this in this new place.

Bug: T241885
Change-Id: Ib003b8a7bbe247db6f7da0a4efcfd4e5967fd033
2023-04-12 15:19:11 +02:00
thiemowmde 4ac067c0fa Fix broken selector in MWReferenceNode.less
This issue was introduced in I7a8ec9f. I tried to understand what this
does but can't see an effect. The behavior and appearence seems to be
identical with and without this code. In case it turns out this is dead
code (e.g. not needed any more with our current browser requirements)
it should be removed. Otherwise the selector fixed.

Change-Id: I0bfae951aa4543c528dd7e04c00a0e978f1ce49e
2023-04-11 20:39:51 +02:00
jenkins-bot bada094fb2 Merge "Localisation updates from https://translatewiki.net." 2023-04-10 07:57:44 +00:00
Translation updater bot f36497ed62 Localisation updates from https://translatewiki.net.
Change-Id: I454ab89ca402b97535f5ba8d0a6918d0f5605912
2023-04-10 09:44:46 +02:00
Translation updater bot 545491a21f Localisation updates from https://translatewiki.net.
Change-Id: Iefcf05de017e0fa4d10b81414051e1aae8efc22d
2023-04-10 09:20:22 +02:00
Translation updater bot faa8173d40 Localisation updates from https://translatewiki.net.
Change-Id: Ie541a2a6701a64d712245e959a2acfdb142e618e
2023-04-03 09:17:11 +02:00
Subramanya Sastry fc240841c4 ParsoidExtensionAPI: Simplify extTagToDOM
* leadingWS is always '' in all the uses so far and it originally
  came from Cite when we first extracted the extension API.

* It is unnecessarily confusing and serves no real purpose.

Change-Id: I5f2f0f123dc6938735c09b96a42c1923b0a49085
2023-03-28 15:44:06 -05:00
Ed Sanders 9b9eccc21b ve-cite: Simplify LESS files with nesting
Change-Id: I7a8ec9fceb3563a4561afd95e18a5667a363a1ab
2023-03-28 11:06:14 +00:00
Ed Sanders ca9ef93409 ve-cite: Convert .css files to .less
Change-Id: If831c23721cc2c3ec3cc17d4cd9c9533a0aa4cb4
2023-03-27 15:01:45 +01:00