Commit graph

8 commits

Author SHA1 Message Date
Ed Sanders bac8dd6be7 Add stylelint and make required style fixes
Change-Id: I8a9def8056a72c3da0c066413e94311a1d839f5b
2016-05-17 18:21:30 +01:00
Amir E. Aharoni 52293b1749 Add lang and dir attributes to cite errors
This is needed when the error appears in an element with
a direction that is different from the UI language.

Change-Id: I583c9cc30f5bec24ab92e97ab938463ea0e45c15
2016-04-30 16:16:58 +03:00
Amire80 1b1350491f Don't allow a reference that includes a group name to break in the end of the line
A reference that has a group name appears as "[group 1]".
Because of the added space in the middle, this can break in the end
of a line. white-space: nowrap prevents it.

Change-Id: Icfbc8b7e37b77b93b621e424d1f4e1759ac644cd
2016-03-19 13:55:04 +02:00
cenarium 469217073a Use span with css instead of strong for cite errors
Change-Id: I9b8954b56646ca9c4632788824346e6116de3146
2016-02-24 18:57:37 +00:00
Bartosz Dziewoński 04ac55ed52 Revert "Use display: inline-block instead of unicode-bidi"
I think this change causes too many issues on non-LTR wikis
(see the associated tasks) to be acceptable in the current form.

Maybe it should be redone to apply to RTL text only if it's
worth it there (apologies, but I don't quite understand the issue).

This reverts commit e9c1521fca
and commit 59ef3c8678 (which was
the previous attempt to fix it and caused different issues).

Bug: T108493
Bug: T110057
Change-Id: I205400c59a342dcc4cdf89791bc1c761805cd2a8
2015-08-24 20:33:28 +00:00
Ebrahim Byagowi e9c1521fca Use display: inline-block instead of unicode-bidi
On I16a701f3b962b5e7f63554be2f28888a938548b0 we incorporated
unicode-bidi: embed; instead isolate but it caused regression on
* https://fa.wikipedia.org/?oldid=15565588
* https://fa.wikipedia.org/?oldid=15552160
where references ([۱]) comes before number with Persian digits.

Using unicode-bidi: isolate; is the clean solution for fixing this
however due to Firefox bug https://bugzilla.mozilla.org/1185987
it is not going to fix the regression on Firefox so using
display: inline-block; in hope to get same effect with Chrome
on unicode-bidi: isolate; but also support IE and older browsers.

Change-Id: I1d62c1fb282acc72ab20d71cc8cd21e3e1d71493
2015-08-02 14:02:26 +00:00
Amir E. Aharoni 59ef3c8678 Change unicode-bidi: isolate to embed
"embed" works just as well in modern browsers.

Also fix the comment to be more correct.

Change-Id: I16a701f3b962b5e7f63554be2f28888a938548b0
2015-07-11 22:47:30 +03:00
Derk-Jan Hartman 05cb5cc1a0 Cleanup style RL modules for Cite
Move the JS which is purely for accessibility purposes into a separate
JS RL module named ext.cite.a11y. Move all pure CSS, which is not dependant
on accompanying JS into a separate ext.cite.styles module

Bug: T101559
Change-Id: I58adcfbcf9af2bb3b6d5dabb6c38c42af78e0416
2015-06-06 15:43:27 +02:00