Commit graph

4705 commits

Author SHA1 Message Date
Translation updater bot 285e293fa1 Localisation updates from https://translatewiki.net.
Change-Id: I2355c18dac5574a95e1579bfa2479949802cb136
2019-08-27 11:03:11 +02:00
Translation updater bot 793d9e6151 Localisation updates from https://translatewiki.net.
Change-Id: I796a30d0981431845069be4a22174db57e100f9a
2019-08-25 10:29:30 +02:00
libraryupgrader f3288434f2 build: Updating eslint-utils to 1.4.2
* https://npmjs.com/advisories/1118

Additional changes:
* Added .eslintcache to .gitignore.

Change-Id: I449ebbd4e784eddfaad61c5777c162b02260b7e9
2019-08-24 06:04:37 +00:00
Translation updater bot 1ea0cb2f13 Localisation updates from https://translatewiki.net.
Change-Id: I759a7c581e2bdb42ed6fbb566c59cd0c348ffd1a
2019-08-23 09:47:32 +02:00
Translation updater bot 3defa1dfd4 Localisation updates from https://translatewiki.net.
Change-Id: Iadf29120f99a46a18f136f3fc5aa752ca09e3e3e
2019-08-22 10:08:43 +02:00
Translation updater bot 8e7b401a34 Localisation updates from https://translatewiki.net.
Change-Id: I6b06118055c9bd18ccd509fc76016f16c3ba9662
2019-08-21 10:01:44 +02:00
Translation updater bot ee8a1f74d6 Localisation updates from https://translatewiki.net.
Change-Id: I41423fe53e45aad4ea01de2eeaf87b4cd31afd53
2019-08-20 10:19:23 +02:00
Translation updater bot 616c19d16c Localisation updates from https://translatewiki.net.
Change-Id: I0b5a68b8343f7e4c2754c577c2b73960a7b6d720
2019-08-17 10:02:58 +02:00
jenkins-bot 152dde909a Merge "Remove warning about hard-coded class name" 2019-08-15 08:38:24 +00:00
Translation updater bot 6635317198 Localisation updates from https://translatewiki.net.
Change-Id: I603b5506449a7c7f11bc8f7198c6dbdace6c83d1
2019-08-15 09:15:31 +02:00
Arlo Breault e6204a1561 Test against ref name length instead of coercing to bool
Since "0" is falsy in php.

Couple tests now pass.

Change-Id: I9b62b9f78680de6e1d5c31723af7212a58a535f3
2019-08-14 18:59:28 -04:00
Arlo Breault dc7d19a1a8 Avoid normalizing fragment being passed to newFromText
Matches what we're doing on the JS side.

Change-Id: I93a0770b84e496ddf3290a36fa6b8073919ed183
2019-08-14 22:23:53 +00:00
WMDE-Fisch e0602be6a9 Remove warning about hard-coded class name
Core now uses the extension name to check if the Cite extension is
loaded. Therefore the class name could be changed in that regard.

Change-Id: Ibdc0725045f7a0b0afcbf6cb94ccdab9509ad672
Depend-On: I35e5aa9955141b575de68a5be2c0d5b87585eb77
2019-08-14 19:17:24 +02:00
Translation updater bot b83cf32383 Localisation updates from https://translatewiki.net.
Change-Id: Ie631a35d3ffd0fb605d6b4437c4a0e78c60f81f5
2019-08-14 09:12:29 +02:00
Translation updater bot 001753ec5f Localisation updates from https://translatewiki.net.
Change-Id: If10c751c1a378bd971f0eb9aacf794594953e3cf
2019-08-10 22:48:09 +02:00
Arlo Breault b202964b5a Fix dropping nested refs
The extension handler expects a `null` for this, `false` is an
indication not to use the toDOM handler.

php bin/parserTests.php tests/citeParserTests.txt --filter "CircularRef" --wt2html

Change-Id: I849a9aca1133f8a793c9d77e05f192a6af5d78f9
2019-08-09 16:48:03 -04:00
Translation updater bot 1267e39ff1 Localisation updates from https://translatewiki.net.
Change-Id: Ide154bef58da09cc2f508b258d9a48e8423df257
2019-08-08 09:31:50 +02:00
Tim Starling b002802b4b Workaround for PHP bug involving constant arrays cast to objects
Introduce PHPUtils::arrayToObject() which duplicates the array before
converting it to an object. Workaround for
https://bugs.php.net/bug.php?id=78379

Bug: T228346
Change-Id: If9ef35e9e5183117025bc9cd705b695f270aa244
2019-08-07 02:33:44 +00:00
libraryupgrader 9fc70c9bc1 build: Updating npm dependencies
* lodash: 4.17.11 → 4.17.15
  * https://npmjs.com/advisories/1065
  * CVE-2019-10744
* wdio-mediawiki: 0.2.0 → 0.4.0

Change-Id: Ie56e31c17f01be978c43a35ec488969262a4934e
2019-08-01 17:53:38 +00:00
Translation updater bot b3d8bef264 Localisation updates from https://translatewiki.net.
Change-Id: I95ea07e506adbed0ab20a472ba360cddc17595ba
2019-08-01 09:15:56 +02:00
Subramanya Sastry c7e6c2d0f8 Bug fixes in Cite.php + Parsoid Extension API
Two classic PHP errors
- string '0' is a falsy value in if conditions and so we need an
  explicit === '' check for empty strings
- arrays need to be passed by reference to capture modifications
  in callers.

Change-Id: I07d0e39c44a923ac1faeb2de01433e951c3de914
2019-07-29 13:24:17 -05:00
Translation updater bot 650873c77a Localisation updates from https://translatewiki.net.
Change-Id: Ie516fd9b47ffc6d9d170cd143fd7704cf509c3b0
2019-07-29 09:14:02 +02:00
Translation updater bot 9430c6f82a Localisation updates from https://translatewiki.net.
Change-Id: I58b2b8276b9841aea0c97368aabd2836709d8a93
2019-07-26 08:54:58 +02:00
Translation updater bot 7a4f2dc7f3 Localisation updates from https://translatewiki.net.
Change-Id: Ic320fd6e19a6033c5be9fc2c4409201cd6b10dac
2019-07-24 22:28:26 +02:00
jenkins-bot 39b6dd00d7 Merge "Tracking for change events in citation-templates" 2019-07-22 21:32:02 +00:00
Translation updater bot 8604f48ea4 Localisation updates from https://translatewiki.net.
Change-Id: If723a7d49df24ced6fa830d88b3a7db09da14b61
2019-07-22 22:40:29 +02:00
David Lynch ba9b0c280b Tracking for change events in citation-templates
Bug: T221305
Change-Id: I4aa099ae1f7a6a2bb49b28c6d1452d077ffa61b7
2019-07-22 12:03:34 -05:00
jenkins-bot f180a30405 Merge "Remove parser test with mw-editsection" 2019-07-22 01:57:49 +00:00
Subramanya Sastry 13cbce41c5 Assorted fixes for problems found from parserTest runs
Change-Id: I75b158df00f54ff163455c630b51f2c00af24888
2019-07-18 09:01:46 -05:00
Translation updater bot 52a404cc35 Localisation updates from https://translatewiki.net.
Change-Id: I55156b2b1ac53124a612d9b1be9f0423f34865e4
2019-07-18 08:52:52 +02:00
Subramanya Sastry 8757e89e21 Assorted fixes after running PHP parser tests in different modes
* Fixes crashers, notices emitted during parser test runs.

Change-Id: I0e337f22594f6cd36a7dff21afaa7a9dc9c862cf
2019-07-15 17:00:45 -05:00
Translation updater bot 797b80748d Localisation updates from https://translatewiki.net.
Change-Id: I66224e4fb1755da5d8e012a56f04610e0906de50
2019-07-15 08:33:46 +02:00
jenkins-bot 02c0637d48 Merge "Split apihelp messages to a separate file" 2019-07-14 17:46:28 +00:00
libraryupgrader 8b442be731 build: Updating dependencies
composer:
* mediawiki/mediawiki-codesniffer: 24.0.0 → 26.0.0

npm:
* set-value: 2.0.0 → 2.0.1
  * https://npmjs.com/advisories/1012
  * CVE-2019-10747
* union-value: 1.0.0 → 1.0.1
  * https://npmjs.com/advisories/1012
  * CVE-2019-10747
* mixin-deep: 1.3.1 → 1.3.2
  * https://npmjs.com/advisories/1013
  * CVE-2019-10746

Change-Id: I49cf7e168b40e849d5a497126f5c5631630346f3
2019-07-14 09:46:29 +00:00
Subramanya Sastry d76ac30440 Followup to 0f0d6e0e: Fix sig & return value to match ext-api changes
* The new PS of 0f0d6e0e missed this.

Change-Id: I731bd85dc3ae4522d64c87085f49330691a10e36
2019-07-12 17:32:17 -05:00
Subramanya Sastry 0f0d6e0ed7 Followup to 7b6839ac: Fix crashers during serialization
* Don't unconditionally run fromHTML and before handlers without
  checking if we have a native extension handler.

* Remove unintential implementation of `before` in Ref.php

* Hybrid tests for Cite now passes again.

* Discovered while running native parser tests and isolated those
  crashers to this.

Change-Id: I45b48b595a5aee2b8b8d00b4ebcf73a5ea7bc8a3
2019-07-12 13:48:50 -04:00
C. Scott Ananian 7b6839ac59 Remove SerialHandler interface in favor of default methods on ExtensionTag
Change-Id: I245c4b9393720982654d5f4e944329c9d764e04e
2019-07-11 18:51:55 +00:00
C. Scott Ananian 7e444d6364 All extensions implement Extension; tags all implement ExtensionTag
Restructure ExtensionTag as an abstract class with default do-nothing
implementations of all methods.  So instead of Translate and LST
not implementing ExtensionTag::toDOM, they inherit the default
implementation which returns false, and that has the same effect.

The intention is to move SerialHandler::fromHTML and SerialHandler::before
into this framework as well.  Every "optional" method should have a default
implementation in the base class which returns false.

Change-Id: I0ad5c714601c0cf0b5189d4d282c67c6b53fc760
2019-07-11 18:46:14 +00:00
Amir Aharoni 00c31ffc7e Split apihelp messages to a separate file
Bug: T189982
Change-Id: I7808076245d39fa10d75d67c9a9180dccd708f40
2019-07-11 18:03:42 +03:00
James D. Forrester bceb94ca2a build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1
Change-Id: I909d3cfa726d7b68b5a580baf00f6746d4689404
2019-07-10 16:31:30 +00:00
David Lynch eb37c893ea Extra tracking for VisualEditor's feature use
Bug: T221305
Change-Id: I1c681ec2da5fd7701d6c6b53f1f8a160dc885610
2019-07-08 11:04:52 -05:00
Translation updater bot e3e502e935 Localisation updates from https://translatewiki.net.
Change-Id: I47c46b7c78ed84b9246ed5e2f473473b1705a897
2019-07-07 22:38:08 +02:00
jenkins-bot dbf08269a6 Merge "Dialogs: Use close flag for close actions" 2019-07-02 19:01:35 +00:00
Translation updater bot 4f1b491783 Localisation updates from https://translatewiki.net.
Change-Id: I6fc58232ed2364c85bb2ccc96ca54c0da04454e3
2019-06-30 22:37:03 +02:00
jenkins-bot 028a1828e0 Merge "Remove citefromid alias support" 2019-06-28 18:52:41 +00:00
C. Scott Ananian b84b71af22 Gallery: shift TSRs in the DOM, rather than fibbing about srcOffset
Passing srcOffsets which don't actually correspond to actual regions of
the source wikitext cause problems in the token offset conversion code.
Instead, parse the wikitext as itself, then adjust the TSRs in the DOM
tree.

Since Gallery isn't ported to PHP (yet), update the
automatically-generated Gallery/index.php.  The newly-added
ContentUtils::shiftDSR() was ported, however.

Change-Id: I28f3d3398930733ae2bcf9759e49c45f93bc7190
2019-06-28 14:10:16 +00:00
C. Scott Ananian c790d125de Convert dsr properties to DomSourceRange instances in PHP port
Change-Id: I7795cedf14e6ff56a31eeaba0a32c3c5c3166f08
2019-06-27 15:35:05 -04:00
Subramanya Sastry 720f1db084 Fix exception handling: Don't catch exceptions and suppress them
* Now that we are in sync land, we don't need to catch exceptions
  and log error messages at multiple places. Let them bubble up
  to the top.

* I noticed this was actually getting in the way of debugging because
  with $env->log unimplemented, I was only getting very generic
  failures instead of the root cause that was being suppressed
  and unlogged.

* There are still a couple of places where we have generic Exception
  catching in place where it does make sense currently. For example,
  we aren't interested in what caused a templatedata fetch to fail.
  We simply fall back to regular serialization - the rationale here is
  that it is better to emit a transclusion without the preferred formatting
  (but syntactically correct) instead of losing the edit altogether.

* Minor unrelated fix in Cite/Ref.php: Use !isset() instead of empty()

Change-Id: Iebff6f37dcd8278185c4a74b72a99b528efa20ff
2019-06-26 15:50:49 -05:00
Subramanya Sastry bc72a99fb2 Minor fixes to Cite port
Change-Id: Iccd6823c572059948e5ad1a7c91d567d39494934
2019-06-26 11:59:48 -05:00
Subramanya Sastry 3f0b81b085 Followup to 31d356a5, 005176a3 and assorted fixes
* Source offset fixes: followup to 31d356a5
  - there were instances of $tsr[0] and $tsr[1] that hadn't
    been converted over to $tsr->start, $tsr->end
  - removed dead code

* Cite fixes: followup ot 005176a3
  - Fixes array / object mixups
  - Bug fix

* html2wt/WikiLinkHandler fixes
  - Protect access to missing properties in data-mw opt list

* Other assorted fixes
  - Added missing typehints and improved doc types
  - Simplified some code patterns
  - Cast extension attributes to object since that ends up
    in data-mw which is a stdclass object.

Change-Id: Idd04b0d3819be3660823047a90330fd1213388cf
2019-06-24 16:56:56 +00:00