Commit graph

59 commits

Author SHA1 Message Date
jenkins-bot c9fb272bdf Merge "Converter tests: Use template literals to make HTML more legible" 2023-05-31 23:50:12 +00:00
Ed Sanders 18b0b91f50 Converter tests: Use template literals to make HTML more legible
Depends-On: Iee8184dd6524b6dc12d19ac79761f6bd15990297
Change-Id: Ie5fd3f180dd2f7882ec10477117f4b0cdee374ad
2023-05-31 17:28:30 +01:00
Adam Wight 00eede66f0 Add a test for "extends" round-tripping
Bug: T247922
Change-Id: Iaf8417814aa264fbeca0ad139c1a5f073ea10e8b
2023-05-31 08:15:17 +00:00
thiemowmde e4e1a38e1e Add missing space to reference list rendering
Minimal test case:
 <ref name=a>a</ref>
 <ref name=a/>
 <references/>

This renders as "1. ↑ 1.0 1.1 a" in both the legacy parser as well
as Parsoid. The moment you start editing this in VisualEditor the
space before "a" disappears. This patch fixes this inconsistency.

Change-Id: Idfea1a445fc98a0433640b4f706fafcc4e236c18
2023-05-16 15:43:16 +00:00
Ed Sanders bae4a409a5 Update output of diff test
For I93a88abc8e9ecf38992b396c151215781057a6f4.

Change-Id: Ia743b0c37bbd33b95dd4824018ae59fbb6e45c3e
2023-03-08 15:52:02 +00:00
Bartosz Dziewoński a845923a65 Specify document base URLs in more test cases
Depends-On: I0e301bef38d97fa2234aa901c787360d9fbde8a3
Change-Id: I07a8c097dba0f5572c0aedf4febdf1434063ea6f
2023-01-22 16:00:09 +01:00
Bartosz Dziewoński c0746c7fa8 Remove 'origTitle' in tests
Depends-On: I0ad0a655380eb2fb29b5ac01e2e399ac550ce34a
Bug: T325766
Change-Id: Ib5c33aceb9430aba49c692552b54427e64a787f3
2022-12-22 17:57:41 +00:00
Bartosz Dziewoński b89db98b7a Use more realistic fake data in test cases
Change-Id: Ie5a30fe254bd69db4f8fe363baeb926282897d00
2022-12-22 10:47:15 +00:00
Ed Sanders 0eb0893c96 tests: Use ve.test.utils.newMwEnvironment()
Depends-On: Ib20c1f5277c5d5a99f5117c82b7cbdeab75d3279
Change-Id: Id5ff5d126f3946621ed36c5f79b5f58624931d16
2022-03-04 13:52:06 +00:00
Ed Sanders b677a88fcc ve-cite: Update diff tests with new ref list HTML
Depends-On: If4ca99fa4532b33f164e298b53cfa1e202035015
Change-Id: I8e45941401448b826fec37d3dba4d6b1d8e53671
2022-01-25 20:46:29 +00:00
Bartosz Dziewoński c22f35964a Update tests for the removal of doc-child-change wrappers
Depends-On: Ib29f23625de9151d50e0f3b7796b15ca9ed89133
Change-Id: I73efd3c581cbb561be3dfc9eeb3524d9f949ea83
2022-01-24 21:58:01 +01:00
Ed Sanders 0ef557a509 VE tests: Suppress XML warnings
The XML validator can't handle unescaped < in attributes
so always throws a warning.

Change-Id: Ie49e4080c049dea6eea714abdeb37f6764baaa2a
2022-01-10 14:21:44 +00:00
Ed Sanders e539a60fb9 ve-cite: Add test for simple case of re-used reference
In our first case we have a reference re-used before it
is defined, but that doesn't trigger the bug that caused
T296044.

Change-Id: Ia0bbd40528228275f0a978a0a459388a04ea2e79
2021-11-19 13:51:21 +00:00
Ed Sanders 638dbbff60 ve-cite: Update CSS classes in tests
Change-Id: I4546a71d541e1d22a4c34e6d0f5173a993792ff9
2021-11-19 13:51:21 +00:00
Ed Sanders cf95dbd4be Move var declarations inline
Change-Id: I824a65e72a72e5acf65c54a63299469f7acb649d
2021-11-03 16:38:31 +00:00
James D. Forrester 34199178e1 tests: Align setup/teardown function naming with QUnit 2.x
Bug: T170872
Depends-On: I5bfca33c1d4d920d54c2c54b483be78c61b6d0d7
Change-Id: I992e16fae6fcf4d5e7f2d5109ff16a30b6e73882
2021-02-05 10:58:27 -08:00
Ed Sanders c763fb5cc3 MWReferenceNode: Ignore changes to reference list index
This means that all reference nodes are treated as comparable
in the diff (provided they are in the same group) so will
not show up in the article diff if their index changes.

Changes to the reference list are already handled separately
by the visual diff.

Bug: T170235
Change-Id: I8c26686d7b2fe3bf91af7d4dcab1caf3247dbe47
2021-01-21 14:40:15 +00:00
Ed Sanders b955439be1 ve-cite: Update DiffElement test with fixed output
Change-Id: I9a73d0e0ee3c8b12e0b5c3202eb5882258539920
2021-01-19 23:27:32 +00:00
Bartosz Dziewoński 72f79aae3b Add "reference" class to references in VisualEditor
* Add it to CE HTML, for compatibility with site styles.
* Add it to DM HTML of newly created references only. Existing
  references just use whatever classes we got from Parsoid, to avoid
  unnecessary DOM changes and dirty diffs.

Bug: T265930
Depends-On: I61a2132f3876e2d9567d985358f51eb51c479813
Change-Id: I9d6856f03071c09617b8ae7db938135a3e30fe8e
2020-11-06 18:04:13 +00:00
Ed Sanders a93b3c5185 Remove unused test constant
Change-Id: I1ee23cd4f6ba5a6851d4717f303d2b880da338cd
2020-06-09 11:29:34 +01:00
David Chan 94c6d46ded Fix tests to expect p-wrappers
The ve-mw change I0479116b51cc3135a992fdf36b8edfb2c44916ba removes the
stripping of solitary paragraph wrappers (which is moved into
ve.ce.Surface in VE core).

Depends-On: I0479116b51cc3135a992fdf36b8edfb2c44916ba
Change-Id: I2429b5291d8505d586cf4edc4cae9875f8abc347
2019-09-18 18:26:17 +00:00
Bartosz Dziewoński 80e6db1fde Temporarily remove tests
The ve-mw change I0479116b51cc3135a992fdf36b8edfb2c44916ba removes the
stripping of solitary paragraph wrappers (which is moved into
ve.ce.Surface in VE core). We can't merge it without removing the
failing tests here for a moment.

Change-Id: I8799d51958b966c99307f4c70546ea326e67385c
2019-09-17 22:42:42 +02:00
Bartosz Dziewoński fd11b87c5d Remove "hrefPrefix" from tests
Bug: T206357
Change-Id: I8728f63084902c76d1c61193be4367939b069f1a
2019-04-03 20:09:59 +00:00
Kunal Mehta 0395035789 build: Set "root": true, in .eslintrc.json
This ensures that each repository's "npm test" command is fully
independent of wherever it might be in the filesystem.

Bug: T206485
Change-Id: I54d052bed4ceed175a938896154fd6ad5c89f964
2018-12-18 10:47:31 +00:00
Ed Sanders 4df9bf5f69 Fix wikitext paste test
Bug: T204007
Depends-On: I97a92512d7b114ed46bc48d3d416eebc86df13f7
Change-Id: I06177cb4428798f62b78f5dc48f545a6cb6884fc
2018-10-29 21:39:40 +00:00
jenkins-bot 557e311ab4 Merge "Template reflist: Re-render when converting for preview (e.g. visual diff)" 2018-09-19 23:49:12 +00:00
jenkins-bot 216d85adaf Merge "build: Update linters" 2018-09-13 22:47:59 +00:00
Ed Sanders eb7bed046b Template reflist: Re-render when converting for preview (e.g. visual diff)
Bug: T202324
Change-Id: I33dfb26a8f033f5ee5a89b2c1ad9aa081d3a55d1
2018-09-13 21:04:47 +01:00
James D. Forrester d95dda3f16 Unbreak visual diff results for checking node type change
Bug: T201721
Change-Id: I59fa13324083bfd8c77862d0d88b9b3cea1cfeb8
2018-09-13 11:08:46 -07:00
Ed Sanders 0d866f13c7 build: Update linters
Change-Id: Ia558b35eab54b33e2faac1ae3324a17da18fcb49
2018-09-11 23:54:19 +01:00
Ed Sanders 6c38c009d7 Add preview mode converter tests
Change-Id: I2e9dc615a82b725d4061b39e6bdc56350e5d3d1d
Depends-On: I3f1a4772cbf67091b5fd52bab610390ebd9b16ef
2018-05-31 16:27:14 +01:00
Ed Sanders 475d825918 Use MWPreviewElement in view mode, instead of building a view node
Also "unwrap" paragraphs using CSS instead of DOM manipulation.

Change-Id: I5565c2c43580d5d47bc65ee06d9d14fccace90c6
Depends-On: Ibbf989dcebf2d21fd2ac481f17062f366ff29e41
Depends-On: I284bcd5dd25cdbb883427ebacb41af1bbf50b60f
2018-05-13 20:01:19 +01:00
Ed Sanders 8487745c55 Don't compute ref contents in converter preview mode
Depends-On: I0f1b90056e9d1a4fa0e188700604709297593924
Change-Id: I7f98d7b6609c896f91a6d256d58aeb2ff53bc181
2018-04-30 17:47:43 +01:00
Thiemo Mättig bbc1f2c91d Use standard form for @license tags
See https://spdx.org/licenses/

Change-Id: Ic091ebc3844abcd6de90b3241382fb4732200a6d
2018-03-20 03:18:37 +00:00
Ed Sanders 3590446c2c Fix detection of template-generated ref lists
Bug: T188898
Change-Id: I77333323d8e6a324b1655c10c94ae397aad241b3
2018-03-05 16:11:03 +00:00
Ed Sanders 65d47f53b5 Fix transaction tests
Change-Id: I215c1b060d0758e669b62ba27db96ece56bff2f0
2018-02-24 19:24:11 +00:00
Ed Sanders 8e5ae11be0 Create first unit test for reference diffs
Depends-On: Ia34b535c34aeed933164a18a0be76d7c0ac28bc6
Depends-On: Ic70bd3e8ba090c2d174164fd1ecebdf6f2225254
Change-Id: Ib8b485663dea6fcc50c0197451d0a553e5d89c27
2018-02-13 19:22:58 +00:00
Ed Sanders 495d9420f0 Treat template-generated reference lists as real ones
This will allow them to auto-update, and be used in the
visual diff.

We record a templateGenerated attribute to prevent them
being edited, and to ensure they roundtrip back to
templates.

Bug: T52769
Change-Id: I4460d2c98166581e942e35921b20091990f5f6c7
2018-02-07 10:48:57 +00:00
Ed Sanders f1d1cf38f5 Render ref list from CE node when converterting for clipboard
Bug: T186407
Depends-On: Iee635eaf42e3780da4e46e3c0f12417aa331655b
Depends-On: I1500f42dc0bf761f495e25c2d3d047157292df7d
Change-Id: Ia3b2549eb246fc0af56446a7d6a32ec0f54f4099
2018-02-06 16:47:07 +00:00
Ed Sanders dd2aeb641d Remove metadata from unit tests
Metadata is being removed from VE.

Change-Id: Icc614ed7a9792b7d9475d7a804bb8eea48424043
2018-01-22 14:31:44 -08:00
jenkins-bot 6b1e7e126f Merge "doc: Bump copyright year" 2018-01-03 19:18:07 +00:00
James D. Forrester 0999d771b6 doc: Bump copyright year
Also make the overly-terse statement clearer.

Change-Id: I752bb82444bf7cb41480076bace42331dc35a598
2018-01-02 17:05:50 -08:00
Ed Sanders 366d44926a MWReferenceNode: Generate 'sup' tags by default
Bug: T45094
Change-Id: I8973328095f36cce2cebbf335ee7421187eedfad
2018-01-02 15:39:08 +00:00
Ed Sanders a3a4bd945b VE: Support 'responsive' attribute
Bug: T53260
Change-Id: I1e0ae39e8c30653b7ba0f537723a4bcd79ac3162
2017-09-19 17:03:39 +01:00
David Chan 2efa23e5b5 Fix expected remove data to match actual remove data exactly
Change-Id: I0fb294265fc41015da842f7505bdedb39db7b91a
2017-08-13 11:41:30 -04:00
James D. Forrester bee8160fd8 tests: Use new QUnit 2 module hook names
Replacing QUnit.setup()/QUnit.teardown() with the already-available-
in-qunit-1.x QUnit.beforeEach()/QUnit.afterEach() methods.

Bug: T170873
Change-Id: I5bfca33c1d4d920d54c2c54b483be78c61b6d0d7
2017-07-25 23:46:33 +00:00
Thalia 1a5d90b4e3 Visual diff: Show correct reference indices in diff
Bug: T162819
Change-Id: I7eec4ee12a24ff99388cc0c95a24d50f321511f9
2017-06-26 19:19:03 +00:00
Jforrester 978b098025 Revert "Update ve.ui.MWWikitextStringTransferHandler.test results for <p> wrapping"
This reverts commit ca45349b84.

Change-Id: If4ca5fdb57fbddd0eb89aa8adf4c47a0c005e023
2017-05-21 14:09:06 +00:00
James D. Forrester ca45349b84 Update ve.ui.MWWikitextStringTransferHandler.test results for <p> wrapping
Change-Id: I782d13187e30d9a871b9805ee28e8a43eae6c61e
Depends-On: Ibd21e6a78c3958db1c0ec8f0317c4c07f3fa5735
2017-05-19 19:33:11 +02:00
Ed Sanders 1dcdeae9f6 build: Update eslint to 0.4.0 and make pass
Change-Id: I9f4508345ca6dadf617e8ed0e1dd11d28fa01c79
2017-05-04 21:09:05 +00:00