Commit graph

25 commits

Author SHA1 Message Date
Subramanya Sastry fa1cb6c6cd Parsoid CSS: Remove list-style-type styles added in e5a8b3ec
I copied these from the visualdiffing repo, but I may have
over-generalized these from some wiki that might have customized
this to all wikis. enwiki doesn't use this, for example.

In any case, this styling should be left to individual wikis.
similar to the argument in 8412fb64 where I removed CSS rules
for standard refgroups as overreach.

Change-Id: Ie37408d7a92af88e39e345eb464c6fa2210d57e3
2023-02-13 22:18:45 -06:00
Subramanya Sastry b9400d1bf0 Parsoid CSS: mw-ref-linkback counter inits to -1, not 0
* This has always been a bug but was hidden because enwiki
  uses lower-alpha custom rendering and so we never noticed it
  when we tested this on enwiki.

* Fixing the default gets rid of the need to override this for
  every single language that defined a non-decimal counter.

* This also eliminates the need for some rules where the overrides
  were identical to the baseline definitions (counter-type is
  decimal and separator is '.').

Bug: T86782
Bug: T156350
Change-Id: I51f8a06c80bb897b66a0978b117fbc5560efd6cb
2023-02-07 20:59:23 -06:00
Subramanya Sastry 8412fb6406 Parsoid CSS: Remove default rendering for "standard" ref groups
* This was obviously a mistake for 'decimal' since the previous CSS
  would have rendered refs with the "decimal" group and refs without
  any group identically making it hard to distinguish between the
  two ref types.

* But, not all wikis define custom messages for these "standard"
  ref groups. So, by providing default rendering for these, we would
  need custom overrides for wikis that didn't define them (the vast
  majority). Instead, for wikis that define them, define wiki-specific
  CSS for these groups that can be added to their Common.css pages.

* Discovered as I set about trying to update CSS on wikis and my
  test wikitext with different groups were rendering decimal groups
  differently and I had no custom CSS for it anywhere.

Bug: T86782
Change-Id: I5598580e96eead94bb09574b2af5cef3ce4241c5
2023-02-07 20:45:29 -06:00
Subramanya Sastry ea4c16c037 Ensure Parsoid's linkback ref CSS counters are properly incremented
* Turned out there were 2 counters defined on references li nodes.
* One was added as part of the extends functionality added by WMDE's
  book referenceing project.
* The other one was added as part of Parsoid's Cite CSS work.
* Since the counter increments were defined separately and applied
  to the same node, only one of the increments would apply.
  This breaks counter rendering on wikis where custom wiki-specific
  rules aren't defined in that wiki's Mediawiki:Common.css
* Discovered after running visual diff tests after ad919e37
  was deployed.

Change-Id: I826faac3564d63b8a4fbd80015fd5cc8f0069b7a
2023-01-07 19:36:55 -06:00
Subramanya Sastry 8cfad38705 Parsoid CSS: Don't make enwiki's default the default for all languages
* The default formatting for linkbacks for multiple named refs is
  determined by the "cite_references_link_many_format" message.
  It is only defined in en.json as "<sup>[[$1|$2]]</sup>". $2 is
  the output of referencesFormatEntryNumericBacklinkLabel.

  So, change the default Parsoid CSS rule to match that.

* But, since we have shipped Parsoid CSS all this while with the enwiki
  default, temporarily add "ext.cite.style.en.json" with that enwiki
  default so that on deploy, enwiki citations in VE continue to display
  as before.

Change-Id: I6f4b0e25189284ad0950977752739e7dc2951fec
2022-11-18 11:43:50 -06:00
Bartosz Dziewoński 731b162d4e Undo use of .reference instead of .mw-ref in CSS counter rules
When these styles are loaded on a normal MediaWiki page containing
output from the old parser, they cause references to be duplicated.
Use .mw-ref for now, which is only present in Parsoid output.

This partially reverts d6705eb3f8.

Bug: T323343
Change-Id: I6f2d43a060bea7aa175bed80f1be2c3d8a4924b0
2022-11-18 15:56:53 +00:00
Subramanya Sastry 47a622c001 Parsoid CSS: Fix counters needed for ol.mw-references
* Some wikis need a X.Y style numbering where X is the
  counter for the reference number in the list (mw-references),
  and Y is the named-ref counter (mw-ref-linkback).

* Rather than have the mw-references counter be defined for
  specific languages, it is useful to have defined for all
  wikis and use it where needed.

* Not sure why the ol.mw-references reset the mw-ref-linkback
  counter. It needed to be reset for every item.

* While at it, made a couple CSS rules in kn and fa be more
  specific so it is clearly what they are used for.

Change-Id: I6dd35303f134cc4996e134867ecc2c0db7a5411f
2022-11-04 10:17:09 -05:00
Subramanya Sastry 08263ecad5 Tweak CSS defaults to handle Cite_references_link_many_sep properly
* The default separator (' ') should be set up as an :after selector
  and individiual wikis that define the _many_sep and/or _many_and
  messages can override this appropriately.

* Update frwiki overrides accordingly. It has an additional <sup>
  in the Cite_references_link_many message. frwiki also defines the
  Cite_references_link_many_and message.

Change-Id: Ia9ce6ac8eaa5b8386d4a586c620959465da73ef1
2022-11-02 18:48:17 -05:00
Subramanya Sastry d6705eb3f8 Parsoid CSS: Migrate to using .reference instead of .mw-ref
* As part of T265930, in order to reduce the CSS rules that needed
  to be added, we started using the .reference class that the
  original Cite implementation uses.

* Let us migrate styles to using that original class as well.

* Since Parsoid emits a <sup>, we no longer need some of the
  CSS rules on .reference. With the class name change, the
  other rules are duplicates since we inherit the rules from
  ext.cite.styles.css. This effectively eliminated all CSS
  rules for ".reference" from ext.cite.style.css

* Admins on wikis will get the following guidance:
  - where similar styles apply to legacy output and Parsoid output,
    use the .reference class in Commons.css
  - where specific styles apply to Parsoid output but not legacy,
    use the .mw-ref class in Commons.css

* Once we have fully migrated all wikis to Parsoid output, we can
  migrate all the ".mw-ref" rules to ".reference". We then stop
  emitting the ".mw-ref" class in Parsoid output.

Change-Id: I5a8c540dc5b045ffff8c280262595f5281cd167d
2022-11-01 15:43:16 -05:00
mainframe98 b6e5601eb1 Restore styling for cite warnings
This broke as a result of T280766.

Bug: T321450
Change-Id: I4673b769612b280dde1943d79aa16dcd7d6a8052
2022-10-24 18:14:19 +00:00
Subramanya Sastry e5a8b3ec5f Parsoid CSS: Update default styles to reduce needed overrides
* Most wikis seem to either use lower-alpha or seem to use
  use language-specific custom numbers. decimal usage is lower
  and is better used as CSS override on those wikis.

Change-Id: I3e4c3e7b96ab5a9704fe700f62154e51930c975a
2022-10-20 21:33:05 -05:00
Isabelle Hurbain-Palatin b21aca1d06 Allow multivalued rel attributes
This patch is probably not necessary per se, because Cite creates and
controls the mw:referencedBy rel attributes, but it popped up in my code
search, it is technically more correct and it doesn't hurt.

Bug: T315209
Change-Id: Ie796c8a69988c6a546a15d998028c0e6f4c5b2e9
2022-08-22 15:02:40 +02:00
sbailey 8f42623520 Add a definition for .mw-ref-follow to Parsoid's stylesheet
This lets us remove the inlined style on follow refs.

It will be used in I8bfc4ee3df162e2040e3c6f0c37fbf2a7c30d7f6

Bug: T263052
Change-Id: I351516b81566aba0adb4d298e39806dfb4fc7b03
2020-12-03 22:50:57 +00:00
Subramanya Sastry 12e2bf155c Sync unicode-bidi property for <sup> tags between Parsoid & core impls
* See T251983#6159540 for a more detailed summary, but these should
  have always been in sync in the first place.

Bug: T251983
Change-Id: I92d2ec19c70c31374fabc9540678b1bb6eb2728c
2020-05-22 16:45:37 -05:00
Thiemo Kreuz d18c0871a8 Fix broken reference list numbering in Firefox
Same as Ib6e9de6.

We must reset the build-in "list-item" counter to make this code behave
sane in Firefox. It looks like this is even described in the CSS spec
and it is not Firefox having a bug, but Chrome being "clever" and not
following the spec.

Bug: T229307
Change-Id: I955786e2b68d087c819a962ded3c571946c61f78
2019-12-09 10:10:54 +01:00
Thiemo Kreuz 13598ba11e Render nested references
Forked from Icd933fc983.

Bugs and unimplemented features are documented as TODOs in the parser test
fixtures.

Bug: T237241
Change-Id: I9427e025ea0bcf2fa24fd539a775429cc64767cc
2019-11-29 13:40:34 +01:00
Volker E b9ee8433f4 build: Update 'stylelint-config-wikimedia' to v0.5.0 and make pass
Change-Id: I05e257b3213dd4039455d7e55efeb72b58da67fb
2018-12-10 02:59:11 -08:00
Derk-Jan Hartman a603ef420f Make references not inherit bold or italic styling.
There is almost never a situation where this is desirable, yet it
happens quite a lot due to table headers etc having bold styling.
It confuses editors and tends to be less readable.

These style rules have been in en.wp:MediaWiki:Common.css for over 10
years or so, so probably a keeper.

Change-Id: If3d12383853a83d8ef14f1ec54c8c381b6c8f6a2
2018-08-01 14:57:37 +02:00
Ed Sanders 2992edc996 build: Update linters
Change-Id: I473dec2bb64ce2242eaf7bbb4cc42ac767716ae0
2018-02-04 21:22:04 +00:00
Ed Sanders fbcd9e41df Allow mw-ref rules apply to any element
i.e. span or sub.

Bug: T45094
Change-Id: Ib3fae04300c379727aad81b2c0c2a882d8657fe0
2018-01-02 13:59:31 +00:00
Ed Sanders b58db89aac build: Update stylelint to 0.4.1
Change-Id: Ia7d685d9e10468d2303c68dc88fee8811251ffcb
2017-03-20 14:37:33 +00:00
Ed Sanders 50b57f017a Update stylelint config version and make a pass
Change-Id: Ice5bcec27ae98dcbcb246ae166ed8f04e07dc099
2016-05-24 13:48:46 +01:00
Ed Sanders bac8dd6be7 Add stylelint and make required style fixes
Change-Id: I8a9def8056a72c3da0c066413e94311a1d839f5b
2016-05-17 18:21:30 +01:00
Amir E. Aharoni 3fa0f7fb22 Prevent jumbling up of footnote numbers after LTR words in RTL wikis
This happens while editing in VisualEditor and ContentTranslation.

This is done by adding unicode-bidi: embed to .mw-ref.

Bug: T105605
Change-Id: I1d03063cad1fa0f2ae8cc792aaaefc715066f17e
2015-07-11 22:55:26 +03:00
Marc Ordinas i Llopis aa8fed3a3d Use CSS to style Parsoid's Cite HTML
* Add a new module ext.cite.style to load the new CSS.
* Add a ResourceLoaderFileModule that adds the correct CSS file
  depending on the content language, so that the visual style of
  citations can be changed per-language.

The main ext.cite.style.css file renders similarly to MediaWiki's
default Cite style. Also, an example CSS for Farsi numbering is
included.

Bug: T86782
Change-Id: I487095df8a7c4241a14f7b4480360f6774130bec
2015-06-08 21:58:15 +01:00