Commit graph

69 commits

Author SHA1 Message Date
Brad Jorsch e6c76b5d23 (bug 13073) Work around Tidy confusion
If the <references> tag is wrapped (e.g. <div><references></div>) and
the first ref on the page contains a newline, Tidy will get confused and
insert extra paragraph breaks in the output.

We can avoid this easily enough by inserting a newline between
MediaWiki:cite_references_prefix and the first reference's <li>.

Note since this changes the output we also have to adjust the parser
tests to expect the new output.

Change-Id: I8222d53eaf2b20f842915fe90af724711a20bfc5
2012-11-26 19:29:03 +01:00
eranroz da8e6f3b45 Cite anchors should be numbered starting at 1
Fix for bug 10537: Cite anchors should be numbered starting at 1
On the way a small refactoring (getting rid of redundant variable)

Change-Id: Iee94917f3f860516cc310d1cdb1c4f9065d40984
2012-10-18 01:03:31 +02:00
Siebrand Mazeland 52ca5a1a5a Maintenance for Cite extension.
* Update deprecated calls.
* Remove superfluous newlines.
* Add @todo where uncertain.

Change-Id: Ifc79b199fa551c23fafa190664688c8320059338
2012-08-30 10:41:27 +02:00
Brad Jorsch 4933d7a682 (bug 17865) Fix wikilinking in "refs without references" error
The [[MediaWiki:Cite error refs without references]] message does not
correctly display wikilinks. This is because it takes effect during
ParserBeforeTidy, which misses the call to replaceLinkHolders(). And
parsing directly to HTML (with MessageCache::singleton()->parse()) would
lose categories and such added by the error message.

Gerrit change Iaa2755f994edb081eb1d176f632f7add41640dbf adds a
"ParserAfterParse" hook, which can be used to add this message in time
to be correctly handled by replaceLinkHolders().

Change-Id: I093d85d8f8c2ac3238609d145ae5b985602bb3fd
Depends-On: Iaa2755f994edb081eb1d176f632f7add41640dbf
2012-08-07 13:16:46 -04:00
Sam Reed 714af9033f Many other occurance/occurence typos 2012-03-19 14:59:29 +00:00
Max Semenik 53ae80785a Follow-up r102160: removed arrows from tooltips 2012-01-04 15:00:01 +00:00
Roan Kattouw 2142134491 (bug 17865) Fix double-parsed error messages in Cite. Modified patch by Brad Jorsch 2011-11-14 12:22:07 +00:00
Roan Kattouw 7103224ce0 (bug 20050) References containing numbered lists cause Tidy to corrupt the references list. Patch by Brad Jorsch 2011-11-14 12:02:23 +00:00
Gabriel Wicke f876382e67 Back out accidentally-committed r102967. 2011-11-14 11:14:39 +00:00
Gabriel Wicke 4a2232bbe2 Fixes bug #17865 2011-11-14 11:06:42 +00:00
Sam Reed 607f9bbd27 Whitespace/documentation 2011-09-14 15:07:20 +00:00
Platonides e9dff9d1e2 Follow up r89220. Misleading comment left from r88971 2011-05-31 17:51:30 +00:00
Platonides 9fc91b9899 Remove Cite singleton. Store it inside each associated parser at $parser->extCite
This fixes bug 20748 and bug 15819 without breaking the other tests. Reverts r88971.
The conflict with CategoryTree was the old problem of a message being called inside 
of a parser callback, this time with clearState for which the hook is global.
2011-05-31 17:49:22 +00:00
Sam Reed c48d4b674b Documentation 2011-05-28 20:44:24 +00:00
Kevin Brown 37ff765a58 Fix bug 20748 and bug 15819. 2011-05-27 15:22:36 +00:00
Sam Reed 3e5bbe33e7 Remove whitespace, unneeded globals, and swap and/or for &&/|| 2011-04-27 11:11:54 +00:00
Jan Paul Posma 68ea91084d Followup of r82891 and r82894. Fixes hook for InlineEditor, which forces a page reparse when either a <ref> or <references> tag shows up. Doesn't affect normal behaviour when not using InlineEditor. 2011-03-04 11:45:22 +00:00
Jan Paul Posma 1aac56bb83 Fixed call per http://www.mediawiki.org/wiki/Special:Code/MediaWiki/82891#c14483 2011-02-27 15:30:35 +00:00
Jan Paul Posma efb47a9d90 Added hook to support partial rendering for the InlineEditor extension. Doesn't affect normal behaviour. 2011-02-27 14:50:56 +00:00
Platonides 286a80efc1 Make Cite properly register to any parser instead of just $wgParser.
Makes CiteParserTests work with r82867 code.
2011-02-26 22:39:53 +00:00
Mark A. Hershberger bdf20cb5de Followup r82744 Always grep extensions, even for recent additions to the codebase. 2011-02-24 23:06:12 +00:00
Mark A. Hershberger ab606caf02 w/s cleanups 2011-02-24 23:05:22 +00:00
Tim Starling ef36bb331b * Updates for r82645: isValidHalfParsedData(), ise/ize spelling change
* Fixed inappropriate use of empty()
2011-02-23 07:03:26 +00:00
Aryeh Gregor d951a47cdc Style fixes for Cite_body.php
Tested only with php -l.
2011-02-22 00:07:21 +00:00
Sam Reed 1d7fb709b1 Add some braces, fixup some indenting 2011-02-03 21:40:55 +00:00
Alexandre Emsenhuber 5ab3ac860a Use wfMessage() instead of playing with $wgMessageCache 2011-01-17 08:04:14 +00:00
Sam Reed 2ee798e17f More deprecated method call removals and updates 2010-10-29 15:32:44 +00:00
Niklas Laxström 510fb4f1ce Untested fix, second parameter was ignored 2010-09-02 09:03:00 +00:00
Chad Horohoe 9ad4b8a37e More php4-style constructors. I think thats most of them 2010-08-30 17:11:45 +00:00
ThomasV b7e6f6d278 follow-up to r71157 2010-08-23 08:19:42 +00:00
ThomasV b5883ddc36 Support for references spread on multiple transcluded pages, using the 'follow' parameter. 2010-08-16 12:05:57 +00:00
ThomasV 2c5cb7034a added fixme comment 2010-08-11 14:36:59 +00:00
Alexandre Emsenhuber a015b8f170 Big changes to extensions' documentation:
* changed all @addtogroup to @ingroup
* added some @file where needed
* changed some @package/@subpackage to @ingroup
2010-06-06 15:12:22 +00:00
Chad Horohoe 8889add2cf Revert r66934 (Removing wfLoadExtensionMessages() from everything). I disagree on principle...we branch extensions for this very reason. But people want trunk extensions compatible for several versions back, meh. 2010-05-27 15:56:53 +00:00
Chad Horohoe 695d3db96e Large commit. Removed 800+ references to no-op wfLoadExtensionMessages() 2010-05-26 22:25:32 +00:00
Platonides d9b8f32959 Add lists cite_link_label_group-$group to be used for the groups links names.
Fixes bug 22265
2010-05-22 14:28:48 +00:00
Sam Reed e532ce62cc Stylize on some used extensions etc 2010-04-17 21:07:37 +00:00
Alexandre Emsenhuber f2c3c1450f Fix documentation URL, requested by arseny92 on IRC 2009-12-05 14:28:24 +00:00
Max Semenik 7ceae896fa Fixed numerous problems in extensions found with new features of syntaxChecker. Mostly trailing ?>, but also occasional BOMs and leading whitespace 2009-11-14 13:41:31 +00:00
Robert Rohde 75004e338f Extends Cite to allows <ref> content to be defined within a <references> block
See comments on Bug 5997, Bug 15724, and discussion at:
 http://en.wikipedia.org/w/index.php?title=Wikipedia_talk:Citing_sources&oldid=304222618#Improving_.3Cref.3E
2009-07-26 22:15:13 +00:00
Andrew Garrett 43a4822175 Improve Cite references caching by making it dependent on a config setting, which defaults to off.
This way, we can still use it as emergency optimisation if the need arises.
2009-02-12 18:02:27 +00:00
Tim Starling 813c686a03 Don't double-parse messages, it breaks lots of things. Fixes bug #17442. 2009-02-11 06:34:39 +00:00
Andrew Garrett 598202b229 Re-implementation of r46725 (caching of Cite <references /> output).
This time, I've written a Parser method called serialiseHalfParsedText, which, as the name implies, grabs some half-parsed text, and fixes up all of the strip
markers, and link comments, and makes it safe to import some other time with unserialiseHalfParsedText. I tested it by live-hacking the cache key to be a constant,
and then putting <references /> on a completely different page, where it worked perfectly.
2009-02-03 04:58:08 +00:00
Andrew Garrett 4f0b501f07 Fix profiling mistake. 2009-02-03 04:57:48 +00:00
Andrew Garrett d35dbd9f50 Cache cite <references /> output by contents. That way, changes that don't affect Cite references won't cause a re-parsing of Cite, which is a big CPU hog on Wikimedia. 2009-02-03 04:57:28 +00:00
Brion Vibber 439ba88a51 Revert r46725, r46726 "Cache cite <references /> output by contents. That way, changes that don't affect Cite references won't cause a re-parsing of Cite, which is a big CPU hog on Wikimedia."
Causes data corruption in output due to misaligned strip markers.
2009-02-02 21:49:10 +00:00
Andrew Garrett 782b1a20c0 Fix profiling mistake. 2009-02-02 19:34:51 +00:00
Andrew Garrett fedbf8ccc8 Cache cite <references /> output by contents. That way, changes that don't affect Cite references won't cause a re-parsing of Cite, which is a big CPU hog on Wikimedia. 2009-02-02 19:29:02 +00:00
Robert Rohde b7b5f80537 revert of r46520 2009-01-29 10:13:12 +00:00
Robert Rohde 047c89b2c0 Move cite_error formatting wrapper into Mediawiki: space rather than hard coded in Cite_body.php 2009-01-29 05:10:07 +00:00