Commit graph

4037 commits

Author SHA1 Message Date
Thiemo Kreuz 0cc1ddeccb More robust property initialization in ReferenceStack
I tried many things, but wasn't able to reproduce the error
described in T283755. What probably happens goes like this:
* Somehow $this->refs[$group] is initialized, but
  $this->groupRefSequence[$group] is not.
* There are not many places in the code where this can
  happen. There are a few suspicious lines in rollbackRef(),
  but they are all guarded. The only problematic place is in
  appendText().
* This problematic line is only called for <ref> in
  <references>.
* Somehow a <ref> is valid enough to make it to appendText(),
  but not valid enough to make it to pushRef().
* The next time another <ref> is added to the same group, it
  appears like the group already exists ($this->refs[$group]
  is set), but $this->groupRefSequence[$group] is missing.

I was unable to find a wikitext example that would behave like
this.

This patch just makes sure the initialization is done but
doesn't care why it was missing. The following code is fine
with an existing ref that contains nothing but text (which is
how appendText() leaves it behind).

Bug: T283755
Change-Id: I36ac56ef6ed98676a3e8f430a796826351a5f4e9
2021-05-31 14:10:07 +02:00
Amir Aharoni 94166f93b3 Change the button "Basic form" to "Basic"
This button has the same function as the menu item
"Cite -> Basic" on sites that don't have Citoid configured.

Bug: T108713
Change-Id: I8b419ecdc3b0206974c5f413bfd2e35873fe9850
2021-05-31 11:46:24 +03:00
Translation updater bot 939a2943b2 Localisation updates from https://translatewiki.net.
Change-Id: I026ba46082baa5bb5661fee01140e3f2d484cd79
2021-05-31 08:30:30 +02:00
Translation updater bot d65b9a620b Localisation updates from https://translatewiki.net.
Change-Id: I9fd2b81fe5b1d6b9fd0ce6e4d726da96cce483d8
2021-05-28 08:59:11 +02:00
Translation updater bot c8e3afa54c Localisation updates from https://translatewiki.net.
Change-Id: Iac34f93777290720145d4f9eeabca728b571d019
2021-05-27 12:04:56 +02:00
jenkins-bot 3b5de2ab0c Merge "selenium: Update README.md file" 2021-05-25 14:04:34 +00:00
sahil d2ef9166ae selenium: Update README.md file
Bug: T282237
Change-Id: I45502311712f832f19ab236a9e71081492de224c
2021-05-24 18:24:32 +00:00
Translation updater bot 3fc9a8d583 Localisation updates from https://translatewiki.net.
Change-Id: I0e1ee4a31ae7c25a45aa88840183150879857e93
2021-05-24 09:53:16 +02:00
Translation updater bot d276d52bba Localisation updates from https://translatewiki.net.
Change-Id: I90f7a42cd52ebba37cdeed505d8c5aa60f8f94de
2021-05-20 09:09:56 +02:00
Translation updater bot 6a82f23dd5 Localisation updates from https://translatewiki.net.
Change-Id: Ic1aaa533af2adfd7a0e5f1e095a0cc4d559981d8
2021-05-19 08:42:26 +02:00
Volker E 048a887955 build: Remove 'grunt-svgmin' package
There are no SVGs left in Cite, hence removing package.

Change-Id: I608c1b7a4e9d989fc9d58ac29c57d6d9d18cae96
2021-05-17 17:51:41 -07:00
Translation updater bot 2ae898e5c6 Localisation updates from https://translatewiki.net.
Change-Id: I8b7a9f6b88d677992fe0ba883dbb24915d17082d
2021-05-17 08:41:27 +02:00
libraryupgrader 13e5846770 build: Updating npm dependencies
* hosted-git-info: 2.8.9 → 2.8.9
  * https://npmjs.com/advisories/1677 (CVE-2021-23362)
* postcss: 7.0.35 → 8.2.15
  * https://npmjs.com/advisories/1693 (CVE-2021-23368)

Change-Id: I255cbd76aa9562a23fa2e39dd8e8d8cbd17b8889
2021-05-15 12:22:23 +00:00
Translation updater bot ce7dd73d6c Localisation updates from https://translatewiki.net.
Change-Id: I0742dab88b3bb4fd8a76c13cf6c4eaf6101e62c3
2021-05-14 08:43:14 +02:00
Translation updater bot 88f32b2ac1 Localisation updates from https://translatewiki.net.
Change-Id: I9f4f5b3a8959b39038aa5263715bc26ff81eef4b
2021-05-12 09:21:01 +02:00
Translation updater bot b92ed1068c Localisation updates from https://translatewiki.net.
Change-Id: I1e3eab1a59f561ff18b5a57a55ee8e859588b981
2021-05-11 09:05:46 +02:00
Translation updater bot f8b477ba3f Localisation updates from https://translatewiki.net.
Change-Id: I64fe2c4c7d8b813fc89075bff06486d9455a8fe0
2021-05-10 08:50:48 +02:00
libraryupgrader 76c5a28200 build: Updating npm dependencies
* grunt: 1.3.0 → 1.4.0
* hosted-git-info: 2.8.8 → 2.8.9
  * https://npmjs.com/advisories/1677 (CVE-2021-23362)

Change-Id: I4056ded4526eb670ca29bc270d8f0d41b3296f75
2021-05-09 04:08:47 +00:00
libraryupgrader 2e4d2281f4 build: Updating npm dependencies
* lodash: 4.17.19 → 4.17.21
  * https://npmjs.com/advisories/1673 (CVE-2021-23337)
* hosted-git-info: 2.8.8 → 3.0.8
  * https://npmjs.com/advisories/1677 (CVE-2021-23362)
* ua-parser-js: 0.7.21 → 0.7.28
  * https://npmjs.com/advisories/1679 (CVE-2021-27292)

Change-Id: Ib47623bd9a4d3b6b0baf82eeb9cbd7feceac2f11
2021-05-07 16:16:01 +00:00
Translation updater bot 2dafba1795 Localisation updates from https://translatewiki.net.
Change-Id: I5e016bf501feca6e47f03c6171fba3fb72211582
2021-05-07 08:40:42 +02:00
Translation updater bot 4aa7db0f98 Localisation updates from https://translatewiki.net.
Change-Id: Idc59908bb66085dfe5f3d1cbaf34b81a90536e28
2021-05-06 08:53:39 +02:00
Translation updater bot d2dae398f1 Localisation updates from https://translatewiki.net.
Change-Id: I0a04d538f845172c0d3e6298b93337d7d0601fbd
2021-05-04 08:51:30 +02:00
libraryupgrader 3d79d3518b build: Updating composer dependencies
* mediawiki/mediawiki-codesniffer: 35.0.0 → 36.0.0
* php-parallel-lint/php-parallel-lint: 1.2.0 → 1.3.0

Change-Id: I409d4c564a02f537dbd1ceec1576410aefe0ea64
2021-05-04 01:29:20 +00:00
Translation updater bot 13c0393e0a Localisation updates from https://translatewiki.net.
Change-Id: I73ae3f4151ce6c8cd9670b02ed588cc67e8880f0
2021-05-03 08:36:25 +02:00
Translation updater bot 9fa1a9cbcc Localisation updates from https://translatewiki.net.
Change-Id: I05126c9ae626a8ee587192eaca4cd00e7f056b6e
2021-04-28 16:42:57 +02:00
Translation updater bot 0b7aa9d82e Localisation updates from https://translatewiki.net.
Change-Id: I7d4996d551da07510d9fd382d6bec1866d663153
2021-04-28 08:47:45 +02:00
Translation updater bot e205a29d0d Localisation updates from https://translatewiki.net.
Change-Id: Ib7e594bded142ccb39f632cb815170bd78bcdc23
2021-04-27 08:37:42 +02:00
Translation updater bot 59c129ff3a Localisation updates from https://translatewiki.net.
Change-Id: Ie0ed0a9c40af1a98704b06db67f89ba396f544f9
2021-04-23 08:36:15 +02:00
Translation updater bot fe104cd10b Localisation updates from https://translatewiki.net.
Change-Id: I2828a415522de3648bfd9bb70853bdbcbbae5809
2021-04-22 09:30:56 +02:00
Translation updater bot 0d5a47ddef Localisation updates from https://translatewiki.net.
Change-Id: I42c00f1b2c9f36a8aca0499790fd3c3fbf1583a6
2021-04-19 08:50:04 +02:00
Translation updater bot 2e439e1b04 Localisation updates from https://translatewiki.net.
Change-Id: I4b24bc7d2afe9e7e26024f8359d99fd34019be37
2021-04-16 09:50:03 +02:00
libraryupgrader 45fb9da777 build: Updating eslint-config-wikimedia to 0.20.0
Change-Id: I12ebc779b412ab4277695af932daa53435190005
2021-04-16 05:25:52 +00:00
Translation updater bot fca94768ea Localisation updates from https://translatewiki.net.
Change-Id: Ibd0737f3f8e3f3937067712a57dc140df453947f
2021-04-14 08:37:50 +02:00
Translation updater bot f8f5a5c68d Localisation updates from https://translatewiki.net.
Change-Id: I2f7d6f3a77b0cf2dbb368292351f9c9f9a35439e
2021-04-13 09:19:58 +02:00
Translation updater bot 41a9918870 Localisation updates from https://translatewiki.net.
Change-Id: Id3e44f0538ec51f20f08276187e469461450e404
2021-04-12 08:37:09 +02:00
Translation updater bot a514a71f0b Localisation updates from https://translatewiki.net.
Change-Id: I4bfb73418f0fcec975c078fc16f65a26d17c609d
2021-04-09 08:58:01 +02:00
Translation updater bot d8504ae732 Localisation updates from https://translatewiki.net.
Change-Id: I605306668da0f8abf3388d815ed862b4202275a4
2021-04-08 08:39:37 +02:00
DannyS712 30d2385254 Delete empty translation files
Change-Id: I8d576a84f404e12609b5a0d27a08a55a46134d93
2021-04-07 17:18:05 +00:00
Translation updater bot f4e67321a5 Localisation updates from https://translatewiki.net.
Change-Id: I01b74c9a53989c6be94afcf172fb2ea66b15de8b
2021-04-07 08:51:10 +02:00
Translation updater bot 26873614c9 Localisation updates from https://translatewiki.net.
Change-Id: Ic22a9ca6e1990a8afb5befd169c65b2d0731c107
2021-04-02 09:48:20 +02:00
libraryupgrader 5ec6d645bd build: Updating y18n to 4.0.1
* https://npmjs.com/advisories/1654 (CVE-2020-7774)

Change-Id: I5c0a46c7fb56ce5e81b98e26604737c657b2211f
2021-03-29 23:21:50 +00:00
Translation updater bot 70378981c2 Localisation updates from https://translatewiki.net.
Change-Id: Iffc4284f87254b0e6140f82308376fad2cb11b04
2021-03-29 08:35:34 +02:00
Translation updater bot 69a54351da Localisation updates from https://translatewiki.net.
Change-Id: I1823f96e9af3b29bf034ed6a1330dd3a95db21fd
2021-03-19 08:24:33 +01:00
Translation updater bot f281475233 Localisation updates from https://translatewiki.net.
Change-Id: I076cd8d0ba7be7cd3dd39e53706f08015de55175
2021-03-15 08:39:57 +01:00
libraryupgrader 6f2420d0bd build: Updating eslint-config-wikimedia to 0.19.0
Additional changes:
* eslint: Renamed `wikimedia/client` profile to `client-es5` (T277085).

Change-Id: I676c244a56efc85f6f152e55828e95904e7d44d4
2021-03-13 06:42:20 +00:00
Translation updater bot fa7ea06ae9 Localisation updates from https://translatewiki.net.
Change-Id: I70fc293483381969a59a5adc35b7c09a117979a8
2021-03-11 08:36:36 +01:00
Translation updater bot 94d0ed4a5a Localisation updates from https://translatewiki.net.
Change-Id: I86f11cf415af6026dd32431957c9554ddb8f0821
2021-03-08 08:45:53 +01:00
libraryupgrader d91060fbea build: Updating eslint-config-wikimedia to 0.18.2
Change-Id: I7812606451f4309d422892dab633b55b5394cbf1
2021-03-06 08:43:54 +00:00
Translation updater bot 985c7d17cc Localisation updates from https://translatewiki.net.
Change-Id: Id117fbcb495c745302f260099fd7c42a0aa3a1cb
2021-03-05 08:55:18 +01:00
Translation updater bot 137f234cbe Localisation updates from https://translatewiki.net.
Change-Id: I84de2c0a7bf0753ef42f6a778cc77bad001f5617
2021-03-02 08:49:02 +01:00