By leaving the viewNode around, it would update itself later
(due to updateDebounced in the constructor), which would
modify $reflist, even though the caller was expecting
this to be some finalised DOM sub-tree.
Change-Id: Ia89a98556af26986f8362f5b352378cc321b6345
This was briefly enabled in WMF production in 2009 and found not to work.
As far as I know, it's been disabled since then. Retaining it requires
maintaining the complex "half-parsed serialization" feature in the core
parser, which I'm deprecating in I838d7ac7f9a218. The core feature was
added solely to support this Cite caching experiment and is not used for
anything else.
Change-Id: I446e0c46913a390dbdf7b49b84040bf47ed6c2f9
The summary is the first sentence of the method/class description. In
some cases we're missing a period so our "summary" runs on and on.
Many of these were fixed up automatically by the
`jsdoc/require-description-complete-sentence` eslint rule, but
it has a few bugs yet (especially
https://github.com/gajus/eslint-plugin-jsdoc/issues/62 ) so we
can't yet turn it on by default.
Change-Id: I5163ed2c52b21090ce018573bb3ff06d50620d73
This will stop us from showing meaningless diffs (eg
setting responsive to whatever the default already was).
Logically depends on 13a3d0527f.
Change-Id: I0c6a3385d9a493c3854975607cd75d2bf8c1e990
Lots of doc comment tweaks to better match JSDoc standards. Also use
the latest version of jsdoc-wmf-theme.
Change-Id: I9bf4f22b292b9cff0ad926f31005bccc7c89cbdb
We cannot set this in the normal "require-dev" because the plugin
depends on exactly PHP 7.0, preventing running tests on any other PHP
version.
Instead, CI will read the version number out of the "extra" field to
figure out what version to install.
Bug: T187497
Change-Id: I2e9c1c24e3a78132e71dabd045d7e1a509c3efa5
This helps on wikis where there are no real refs because they
are template-generated, and is a performance improvement elsewhere
as re-rendering long ref lists can be slow.
Bug: T187495
Change-Id: I47a9206ff7ee61f8fd716dc7658b8bfad927f656
Enabling SVGO automation with 'grunt-svgmin' and conservative
plugin settings to build step, among those:
- enable removeRasterImages and sortAttrs,
- disable cleanupIDs, removeDesc, removeTitle, removeViewBox &
removeXMLProcInst and
- make use of pretty and multipass options.
Also updating SVGs accordingly.
Bug: T185596
Change-Id: Iec947431b3549e9f1fa1eaba58340aef96c0647b
