wikimedia/mediawiki-extensions-Cite
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Cite synced 2024-12-26 05:22:49 +00:00
Code Issues Packages Projects Releases Wiki Activity
4738 commits 13 branches 25 tags 43 MiB
Commit graph

4738 commits

This branch
This branch
All branches
Author SHA1 Message Date
Ed Sanders 58db72b0c5 Always use the strict equality flag when using in_array 
Change-Id: I21283adfa1c10916bb0ee0b4e87d530bf19d94b9
 2023-06-06 13:34:15 +01:00
thiemowmde 341847a410 Fix inconsistent usage of lastIndexOf in VE reference code 
I assume the code was using lastIndexOf as some kind of performance
optimization. Certain StackOverflow threads suggest it without going
into detail. It's not correct here. You can actually name a group
"mwReference/", which will result in the (valid) internal name
"mwReference/mwReference/". This works as expected with indexOf but
not with lastIndexOf.

Change-Id: I8e85ae5c11a74016c7720fcdb6ac6478431aaa8e
 2023-06-06 13:37:25 +02:00
jenkins-bot eaa2228afa Merge "Tests: Convert more to template literals" 2023-06-05 22:26:41 +00:00
thiemowmde 5c93bbfd00 Add strict types to all class properties 
A good bunch of PHPDoc comments is obsolete when we use strict types.

Change-Id: Ie0692fae4d96c749e9048f7e7c6931ec97998093
 2023-06-05 20:01:13 +02:00
jenkins-bot 7ab39ba77a Merge "Replace misplaced substr_count" 2023-06-05 15:29:03 +00:00
thiemowmde 269f726cff Remove inline @var type hints that are not needed 
This is mostly because recent IDEs can understand createMock() quite
good. We usually don't add such hints every time we use createMock().
We would have a million of them. ;-)

Change-Id: If9e37807a6945c4408d374fc97664cd636020ffd
 2023-06-05 16:37:03 +02:00
thiemowmde 78658dbdb7 Replace misplaced substr_count 
There is nothing to count here. All we want to know is if the number
is greater than zero.

Change-Id: I12a6d2413ab5b1c152817cd0f3ca3de165b3e2f7
 2023-06-05 16:20:36 +02:00
Translation updater bot f823468e1c Localisation updates from https://translatewiki.net. 
Change-Id: I892f830cc96cd8b9a2b28d6b9fb97fbf1c8220dd
 2023-06-05 08:40:27 +02:00
Translation updater bot 61ae890e2a Localisation updates from https://translatewiki.net. 
Change-Id: I036398ae88af1bd3cf57a94ee1d78472b62d8fc1
 2023-06-02 09:23:25 +02:00
Ed Sanders b7024b6668 Tests: Convert more to template literals 
Change-Id: I68da55d32ee9ac6c09439c04a7d7ed71c5bafd29
 2023-06-01 15:51:43 +01:00
Translation updater bot a54a251e1e Localisation updates from https://translatewiki.net. 
Change-Id: I333c57a82638de816a39946de8b8b49e5f143041
 2023-06-01 08:42:56 +02:00
jenkins-bot c9fb272bdf Merge "Converter tests: Use template literals to make HTML more legible" 2023-05-31 23:50:12 +00:00
Ed Sanders 18b0b91f50 Converter tests: Use template literals to make HTML more legible 
Depends-On: Iee8184dd6524b6dc12d19ac79761f6bd15990297
Change-Id: Ie5fd3f180dd2f7882ec10477117f4b0cdee374ad
 2023-05-31 17:28:30 +01:00
jenkins-bot 04fd532292 Merge "Add a test for "extends" round-tripping" 2023-05-31 08:33:23 +00:00
Adam Wight 00eede66f0 Add a test for "extends" round-tripping 
Bug: T247922
Change-Id: Iaf8417814aa264fbeca0ad139c1a5f073ea10e8b
 2023-05-31 08:15:17 +00:00
Translation updater bot 4dffe6d8e3 Localisation updates from https://translatewiki.net. 
Change-Id: I268098cba51f1cfbb580e9e5ff970ef06c9e69a6
 2023-05-31 08:19:55 +02:00
Ed Sanders 3411ac9c36 build: Update stylelint config 
Change-Id: I653fd5ab4a420eb2264b9bfe714ee2a2002097d0
 2023-05-30 20:18:01 +00:00
WMDE-Fisch 9d2856536b build: Updating npm dependencies 
Change-Id: I78639f81504fbe2bf1c82a41f1a3862d2f726e38
 2023-05-30 19:12:10 +02:00
jenkins-bot fc1e14cae7 Merge "Adding extendsRef to reference model" 2023-05-30 10:20:55 +00:00
Svantje Lilienthal 227b50d964 Adding extendsRef to reference model 
* reads the new attribute extends from wikitext
* saves it into the reference model
* adds a message to the VE popup of an extension as a first demo
* tests will be added in a separate patch

Bug: T247922
Change-Id: If4d309c4678022642f39e21565950dc45e557d47
 2023-05-30 11:56:47 +02:00
Translation updater bot 547fa0a9c6 Localisation updates from https://translatewiki.net. 
Change-Id: Icf1bbec2bfe87d1a5d9de8c6003640599cf360c9
 2023-05-30 08:56:28 +02:00
Translation updater bot 4070b9b54f Localisation updates from https://translatewiki.net. 
Change-Id: If4234742ebf1ffd76c97ac3a51d4b5ff184af66c
 2023-05-29 09:58:47 +02:00
jenkins-bot 1d4997560f Merge "Register a HelpCompletionAction group alias for cite" 2023-05-24 17:51:48 +00:00
Ed Sanders dca26d905d Disable mw-body-content clearfix in reflist 
Bug: T337415
Change-Id: Ic94414a4b0e483b6f8945525d07ae7cbcb42045c
 2023-05-24 17:22:28 +01:00
David Lynch 03bac936be Register a HelpCompletionAction group alias for cite 
Bug: T66905
Depends-On: I7bc614c81ae3fc1e16d8fffd9f733186bdc9c472
Change-Id: I4a0242386bb595e04a9d72a8efcff9e8949260d4
 2023-05-24 15:42:36 +00:00
jenkins-bot dc243e48aa Merge "Streamline/minimize duplicate code in reference node classes" 2023-05-23 14:09:22 +00:00
thiemowmde edcb4ddd0b Streamline/minimize duplicate code in reference node classes 
E.g. reducing indention and utilizing convenient jQuery features.

Change-Id: I08fe9d4a09630042b28fc5e35cab4460be44a0d9
 2023-05-23 10:54:56 +00:00
Translation updater bot 083cea9036 Localisation updates from https://translatewiki.net. 
Change-Id: Idbc606f99ad61159eb4663196fdd83771c8ff59a
 2023-05-23 08:22:23 +02:00
Ed Sanders d107f3d5a8 Fix ref list click-to-edit on mobile 
On mobile, the first action is always 'mobileActions', so
ignore it.

Bug: T54750
Change-Id: I06e3f6225bf7a185680d89dee5b204a19a7a4fd7
 2023-05-22 18:22:05 +01:00
Translation updater bot b8af25b157 Localisation updates from https://translatewiki.net. 
Change-Id: I46e1d6e57aafc5081a838bbc4bc10261e922f2c7
 2023-05-22 08:45:03 +02:00
jenkins-bot 933e7070b3 Merge "tests: Make PHPUnit data providers static" 2023-05-20 12:49:37 +00:00
jenkins-bot c9abd842a5 Merge "Add missing space to reference list rendering" 2023-05-20 10:29:49 +00:00
Umherirrender 66159e5b78 tests: Make PHPUnit data providers static 
Initally used a new sniff with autofix (T333745)

Bug: T332865
Change-Id: Ib86d0fb2d3ea734db46b266faede7b4588fae075
 2023-05-20 12:03:41 +02:00
Arlo Breault c37977aad2 Assume strings for dataMw->body properties in ref handlers 
The diffHandler already has this expectation.

Bug: T337036
Change-Id: I0c3a3532c655df6777407a1e0af2d9bac9495037
 2023-05-19 13:28:41 -04:00
Translation updater bot 12eba5384d Localisation updates from https://translatewiki.net. 
Change-Id: I1a883f8d631c390e1ea72ae6aff5f83204868b53
 2023-05-19 10:43:04 +02:00
Ed Sanders 744cbdb56b Launch reference editors from ve.ce.MWReferencesListNode 
Bug: T54750
Depends-On: I502358a3229fbda44950f7f7513548d49d25e0c9
Change-Id: Idea26ffbc5ee859f6ad9456029af4180226c1a07
 2023-05-17 16:05:02 +00:00
jenkins-bot 2ab7c55748 Merge "Render reference list on first load in idle callback" 2023-05-17 14:01:02 +00:00
Ed Sanders 8587e445a1 Render reference list on first load in idle callback 
This means the reference list is always in sync with the model's
understanding of which references are available to edit.

An exception is left in if there are no references in the model
at all, as will be the case on he.wiki, as all references are
template generated. In this case we continue to use the Parsoid
DOM, so that there is a static rendering of the reference list.

Bug: T336865
Change-Id: Iaf1089c9de532e7749c9cb70a9e697917955dca8
 2023-05-17 13:34:15 +00:00
thiemowmde e4e1a38e1e Add missing space to reference list rendering 
Minimal test case:
 <ref name=a>a</ref>
 <ref name=a/>
 <references/>

This renders as "1. ↑ 1.0 1.1 a" in both the legacy parser as well
as Parsoid. The moment you start editing this in VisualEditor the
space before "a" disappears. This patch fixes this inconsistency.

Change-Id: Idfea1a445fc98a0433640b4f706fafcc4e236c18
 2023-05-16 15:43:16 +00:00
thiemowmde b9d5ce7730 Document config flags in extension.json 
Change-Id: Ife0c18b8e06980cdd23dae976749afdfb0cbd7e5
 2023-05-16 09:57:54 +02:00
Translation updater bot 46a2205f5f Localisation updates from https://translatewiki.net. 
Change-Id: Id06f53e8ab8d0b70388cf155419f84e493bdcf9d
 2023-05-16 08:18:33 +02:00
jenkins-bot c985d9b0d0 Merge "Sync up Cite repo with Parsoid" 2023-05-16 04:38:24 +00:00
Translation updater bot a0ee5c363a Localisation updates from https://translatewiki.net. 
Change-Id: Id62fcd146e13c46e3edb69c358561565fd720a6a
 2023-05-15 08:32:01 +02:00
Arlo Breault 9177b50feb Sync up Cite repo with Parsoid 
This now aligns with Parsoid commit 7b724ddc6c4abd44de2e1f67f64ca1d9685c6b4f

Change-Id: If24ad064d7d84fb070cb0c7976d56373e8a9db3a
 2023-05-12 09:59:44 -04:00
jenkins-bot 78f02e22e3 Merge "Disabled tests to break circular dependency" 2023-05-11 18:41:59 +00:00
jenkins-bot fd8db433a6 Merge "Fix empty previews in reference reuse dialog" 2023-05-11 09:43:54 +00:00
Translation updater bot 79c3edaa3e Localisation updates from https://translatewiki.net. 
Change-Id: If653baf2bc9e95fddc85f7e9e1dc693e32a10831
 2023-05-11 09:13:41 +02:00
Arlo Breault 6ed2daec12 Disabled tests to break circular dependency 
html/php sections are added since otherwise it complains that the
"Test lacks html or metadata section on lines"

Change-Id: Ib1c47be09bdbe1e84b595373ad71772f2a983fc9
 2023-05-10 19:47:13 -04:00
thiemowmde 889c2ea011 Fix empty previews in reference reuse dialog 
This fixes a minor inconsistency: A reference that comes from a
template and is already reused outside of the template is only
partially available to VE, and previewed with a warning message
because of this:

"This reference is defined in a template or other generated block,
and for now can only be previewed in source mode."

This was missing in the reuse dialog.

Note this patch is not meant to make any design decision, but to use
the existing design consistently.

You can test this with and without the Citoid extension. It works in
both cases.

Bug: T336372
Change-Id: I962cf111b1882bcd736f1090ca17d2b176495d2f
 2023-05-10 13:03:24 +00:00
jenkins-bot d886cbd70f Merge "Migrate CiteVisualEditorModule to a virtual file callback" 2023-05-10 04:57:57 +00:00