Commit graph

8 commits

Author SHA1 Message Date
WMDE-Fisch 179d402344 Add ReferencePreviews config checks to Cite extension
PHP classes and test are somewhat copies from the Popups codebase.
Some refactoring was applied. More could be done. Not to sure if
this should happen more in follow ups though.

Could also reduce the complexity of checks on the JS side. Most of
these things can only change on page load. The only dynamic part
left is the anon user setting managed by the Popups extension.

Note, that I needed to add a new PHP config for here although the
other still exists and is needed in the Popups extension. This
will change, when the user settings code also moves.

I guess it's okay for now though. Both settings default to true
and are not overridden in the config repos.

Also needed to add the Gadget extension as phan dependency.

Bug: T362771
Depends-On: Ia028c41f8aaa1c522dfc7c372e1ce51e40933a5e
Change-Id: Ie6e8bc706235724494036c7f0d873f5c996c46e6
2024-04-25 12:50:27 +02:00
Umherirrender e009aa5ee5 build: Remove suppression of PhanUndeclaredProperty for Parser property
Follow-Up: I701a27459704839f9f996a171b6982ed17cdd00b
Change-Id: I23c14835e5e3b60d21100e835039b8c9b39c72d3
2024-04-16 23:08:04 +02:00
Arlo Breault 1ea6f53fde Less tabs in phan config
Change-Id: If9b35b1f1ae6e70917e17e85cb0f9a2b0fa959ee
2024-02-26 16:57:14 -05:00
Umherirrender 8580b73320 build: Resolve MediaWikiNoEmptyIfDefined suppression
Follow-Up: I21a5260f36c4fa0d767ec6bba86fcfa35ff0a369
Change-Id: Ib97140baf68bfcc1fae4d9506f73503307f41719
2024-02-16 10:07:13 +00:00
libraryupgrader dfec4fa9f1 build: Updating dependencies
composer:
* mediawiki/mediawiki-phan-config: 0.12.1 → 0.14.0

npm:
* grunt-banana-checker: 0.11.0 → 0.11.1
* semver: 5.7.1, 7.5.4 → 5.7.2, 7.5.4
  * https://github.com/advisories/GHSA-c2qf-rxjj-qqgw

Change-Id: I21a5260f36c4fa0d767ec6bba86fcfa35ff0a369
2024-02-14 07:41:08 -05:00
C. Scott Ananian b1cc92b9a1 Add DOM stubs; change namespace of imported Parsoid code to Cite\Parsoid
The namespace change avoids a conflict with the existing Parsoid
implementation in Wikimedia\Parsoid\Ext\Cite and matches the current
Cite codebase better.  We also need to add some phan stubs to allow
Cite to use Parsoid's generic DOM implementation classes, and some
type assertions to satisfy phan.

Bug: T354215
Change-Id: Ic904601b29555c9485a804f131061f207970ddd4
2024-01-17 16:04:30 -05:00
James D. Forrester f1eda9b6a9 build: Upgrade mediawiki/mediawiki-phan-config from 0.5.0 to 0.6.0
Change-Id: I45f337fcd6206e119b2126380e66867a45ec19c9
2019-05-19 11:26:43 +00:00
Kunal Mehta 45c01a6b78 Upgrade to newer phan
Bug: T216911
Change-Id: Ib228ac26a9a87c51a107407b6162110681b5e75c
2019-03-17 16:46:06 -07:00