wikimedia/mediawiki-extensions-Cite
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Cite synced 2024-11-27 16:30:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

Hide wrong "this reference is used 0 times" in citation dialog

Browse source 
This fixes a minor regression introduced in Ib003b8a. The problem is
that undefined is not equal to anything in JavaScript, and not smaller
than 2 either.

Bug: T241885
Bug: T335410
Change-Id: Ia6deb291d923b88a08ceac8fbc0efb682e14f358
This commit is contained in:
thiemowmde 2023-04-26 16:34:26 +02:00 committed by Thiemo Kreuz (WMDE)
parent 3c902a8f34
commit fa44741f26
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
modules/ve-cite/ve.ui.MWReferenceDialog.js
View file

@ -264,9 +264,9 @@ ve.ui.MWReferenceDialog.prototype.useReference = function ( ref ) {
var group = this.getFragment().getDocument().getInternalList()
.getNodeGroup( this.referenceModel.getListGroup() );
var nodes = ve.getProp( group, 'keyedNodes', this.referenceModel.getListKey() );
var usages = nodes && nodes.filter( function ( node ) {
var usages = nodes ? nodes.filter( function ( node ) {
return !node.findParent( ve.dm.MWReferencesListNode );
} ).length;
} ).length : 0;
this.$reuseWarning.toggleClass( 'oo-ui-element-hidden', usages < 2 );
this.$reuseWarningText.text( mw.msg( 'cite-ve-dialog-reference-editing-reused-long', usages ) );