wikimedia/mediawiki-extensions-Cite
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Cite synced 2024-11-27 16:30:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use explicit nullable type on parameter arguments (for PHP 8.4)

Browse source 
Implicitly marking parameter $... as nullable is deprecated in PHP
8.4. The explicit nullable type must be used instead.

Bug: T376276
Change-Id: I73a4ce1ecd9b4fe040e5bfd22889e783071fab0d
This commit is contained in:
Andre Klapper 2024-10-26 14:56:14 +02:00 committed by Umherirrender
parent cdb2b8804f
commit f4dd8ea227
4 changed files with 4 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
.phpcs.xml
View file

@ -1,8 +1,6 @@
<?xml version="1.0"?>
<ruleset>
<rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki">
<exclude name="MediaWiki.Usage.NullableType.ExplicitNullableTypes" />
</rule>
<rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki" />
<rule ref="MediaWiki.Commenting.ClassLevelLicense">
<properties>

2
src/Cite.php
View file

@ -305,7 +305,7 @@ class Cite {
private function formatReferences(
Parser $parser,
string $group,
string $responsive = null
?string $responsive = null
): string {
$responsiveReferences = $this->config->get( 'CiteResponsiveReferences' );

2
tests/phpunit/integration/CiteTest.php
View file

@ -28,7 +28,7 @@ class CiteTest extends \MediaWikiIntegrationTestCase {
public function testParseArguments(
array $attributes,
array $expectedValue,
string $expectedError = null
?string $expectedError = null
) {
/** @var Cite $cite */
$cite = TestingAccessWrapper::newFromObject( $this->newCite() );

2
tests/phpunit/unit/ErrorReporterTest.php
View file

@ -100,7 +100,7 @@ class ErrorReporterTest extends \MediaWikiUnitTestCase {
return new ErrorReporter( $mockMessageLocalizer );
}
private function createParser( Language $language, string $expectedCategory = null ): Parser {
private function createParser( Language $language, ?string $expectedCategory = null ): Parser {
$parserOptions = $this->createMock( ParserOptions::class );
$parserOptions->method( 'getUserLangObj' )->willReturn( $language );