wikimedia/mediawiki-extensions-Cite
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Cite synced 2024-11-27 16:30:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "Rename internal BOOK_REF_ATTRIBUTE constant"

Browse source
This commit is contained in:
jenkins-bot 2024-10-07 12:02:13 +00:00 committed by Gerrit Code Review
parent c5607f0205 e8fd6c093f
commit ebf38366e7
2 changed files with 6 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/Cite.php
View file

@ -38,10 +38,8 @@ class Cite {
public const DEFAULT_GROUP = ''; public const DEFAULT_GROUP = '';
/** /** Attribute name for the sub-referencing feature in <ref …> */
* Wikitext attribute name for Book Referencing. public const SUBREF_ATTRIBUTE = 'extends';
*/
public const BOOK_REF_ATTRIBUTE = 'extends';
/** /**
* Message key for the (localized) tracking category for pages using the `extends` attribute. * Message key for the (localized) tracking category for pages using the `extends` attribute.
@ -125,15 +123,15 @@ class Cite {
?string $text, ?string $text,
array $argv array $argv
): string { ): string {
// Tag every page where Book Referencing has been used, whether or not the ref tag is valid. // Tag every page where sub-referencing has been used, whether or not the ref tag is valid.
// TODO: Remove this generic usage tracking once the feature is stable. See T237531. // TODO: Remove this generic usage tracking once the feature is stable. See T237531.
if ( array_key_exists( self::BOOK_REF_ATTRIBUTE, $argv ) ) { if ( array_key_exists( self::SUBREF_ATTRIBUTE, $argv ) ) {
$parser->addTrackingCategory( self::EXTENDS_TRACKING_CATEGORY ); $parser->addTrackingCategory( self::EXTENDS_TRACKING_CATEGORY );
} }
$status = $this->parseArguments( $status = $this->parseArguments(
$argv, $argv,
[ 'group', 'name', self::BOOK_REF_ATTRIBUTE, 'follow', 'dir' ] [ 'group', 'name', self::SUBREF_ATTRIBUTE, 'follow', 'dir' ]
); );
$arguments = $status->getValue(); $arguments = $status->getValue();
// Use the default group, or the references group when inside one. // Use the default group, or the references group when inside one.

2
tests/phpunit/integration/CiteTest.php
View file

@ -418,7 +418,7 @@ class CiteTest extends \MediaWikiIntegrationTestCase {
$spy = TestingAccessWrapper::newFromObject( $cite ); $spy = TestingAccessWrapper::newFromObject( $cite );
$spy->errorReporter = $this->createMock( ErrorReporter::class ); $spy->errorReporter = $this->createMock( ErrorReporter::class );
$spy->guardedRef( $mockParser, 'text', [ Cite::BOOK_REF_ATTRIBUTE => 'a' ] ); $spy->guardedRef( $mockParser, 'text', [ Cite::SUBREF_ATTRIBUTE => 'a' ] );
} }
/** /**