wikimedia/mediawiki-extensions-Cite
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Cite synced 2024-11-27 16:30:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

Rename internal BOOK_REF_ATTRIBUTE constant

Browse source 
This has no user-facing consequences. The constant can be renamed any
time again, if needed. It's not used anywhere else:
https://codesearch.wmcloud.org/search/?q=BOOK_REF_ATTRIBUTE

Bug: T373307
Change-Id: Ia4d588e926bb6e75f96048f2d3782c0f23ece514
This commit is contained in:
thiemowmde 2024-08-26 11:12:48 +02:00
parent 4d8cb0d18a
commit e8fd6c093f
2 changed files with 6 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/Cite.php
View file

@ -38,10 +38,8 @@ class Cite {
public const DEFAULT_GROUP = '';
/**
* Wikitext attribute name for Book Referencing.
*/
public const BOOK_REF_ATTRIBUTE = 'extends';
/** Attribute name for the sub-referencing feature in <ref …> */
public const SUBREF_ATTRIBUTE = 'extends';
/**
* Message key for the (localized) tracking category for pages using the `extends` attribute.
@ -123,15 +121,15 @@ class Cite {
?string $text,
array $argv
): string {
// Tag every page where Book Referencing has been used, whether or not the ref tag is valid.
// Tag every page where sub-referencing has been used, whether or not the ref tag is valid.
// TODO: Remove this generic usage tracking once the feature is stable. See T237531.
if ( array_key_exists( self::BOOK_REF_ATTRIBUTE, $argv ) ) {
if ( array_key_exists( self::SUBREF_ATTRIBUTE, $argv ) ) {
$parser->addTrackingCategory( self::EXTENDS_TRACKING_CATEGORY );
}
$status = $this->parseArguments(
$argv,
[ 'group', 'name', self::BOOK_REF_ATTRIBUTE, 'follow', 'dir' ]
[ 'group', 'name', self::SUBREF_ATTRIBUTE, 'follow', 'dir' ]
);
$arguments = $status->getValue();
// Use the default group, or the references group when inside one.

2
tests/phpunit/integration/CiteTest.php
View file

@ -418,7 +418,7 @@ class CiteTest extends \MediaWikiIntegrationTestCase {
$spy = TestingAccessWrapper::newFromObject( $cite );
$spy->errorReporter = $this->createMock( ErrorReporter::class );
$spy->guardedRef( $mockParser, 'text', [ Cite::BOOK_REF_ATTRIBUTE => 'a' ] );
$spy->guardedRef( $mockParser, 'text', [ Cite::SUBREF_ATTRIBUTE => 'a' ] );
}
/**