wikimedia/mediawiki-extensions-Cite
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Cite synced 2024-11-23 22:45:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

[refactor] InternalList isn't state

Browse source 
We've almost finished decoupling, and the last remaining usages of
InternalList can be inlined.

Change-Id: I0809df9d3c24fdd5fe4c628420d0406e012a3259
This commit is contained in:
Adam Wight 2024-09-03 11:34:47 +02:00
parent 4d8cb0d18a
commit e3398577c1
1 changed files with 8 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
modules/ve-cite/ve.ce.MWReferencesListNode.js
View file

@ -24,8 +24,6 @@ ve.ce.MWReferencesListNode = function VeCeMWReferencesListNode() {
ve.ce.FocusableNode.call( this ); ve.ce.FocusableNode.call( this );
// Properties // Properties
this.internalList = null;
this.listNode = null;
this.modified = false; this.modified = false;
// DOM changes // DOM changes
@ -89,11 +87,11 @@ ve.ce.MWReferencesListNode.prototype.getExtraHighlightClasses = function () {
* Handle setup events. * Handle setup events.
*/ */
ve.ce.MWReferencesListNode.prototype.onSetup = function () { ve.ce.MWReferencesListNode.prototype.onSetup = function () {
this.internalList = this.getModel().getDocument().getInternalList(); const internalList = this.getModel().getDocument().getInternalList();
this.listNode = this.internalList.getListNode(); const listNode = internalList.getListNode();
this.internalList.connect( this, { update: 'onInternalListUpdate' } ); internalList.connect( this, { update: 'onInternalListUpdate' } );
this.listNode.connect( this, { update: 'onListNodeUpdate' } ); listNode.connect( this, { update: 'onListNodeUpdate' } );
// Parent method // Parent method
ve.ce.MWReferencesListNode.super.prototype.onSetup.call( this ); ve.ce.MWReferencesListNode.super.prototype.onSetup.call( this );
@ -106,15 +104,11 @@ ve.ce.MWReferencesListNode.prototype.onTeardown = function () {
// Parent method // Parent method
ve.ce.MWReferencesListNode.super.prototype.onTeardown.call( this ); ve.ce.MWReferencesListNode.super.prototype.onTeardown.call( this );
if ( !this.listNode ) { const internalList = this.getModel().getDocument().getInternalList();
return; const listNode = internalList.getListNode();
}
this.internalList.disconnect( this, { update: 'onInternalListUpdate' } ); internalList.disconnect( this, { update: 'onInternalListUpdate' } );
this.listNode.disconnect( this, { update: 'onListNodeUpdate' } ); listNode.disconnect( this, { update: 'onListNodeUpdate' } );
this.internalList = null;
this.listNode = null;
}; };
/** /**