wikimedia/mediawiki-extensions-Cite
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Cite synced 2024-11-27 16:30:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

Improve function and property documentation

Browse source 
Removed some wrong @param from test function,
the @dataProvider should be a enough here

Change-Id: Ib84ce497fef4d48df7547ebc38515fc377e7de01
This commit is contained in:
Umherirrender 2021-01-16 13:44:19 +01:00
parent 6aa96067ba
commit e30f055226
3 changed files with 2 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
.phpcs.xml
View file

@ -1,8 +1,6 @@
<?xml version="1.0"?> <?xml version="1.0"?>
<ruleset> <ruleset>
<rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki"> <rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki" />
<exclude name="MediaWiki.Commenting.PropertyDocumentation.MissingDocumentationProtected" />
</rule>
<file>.</file> <file>.</file>
<arg name="extensions" value="php" /> <arg name="extensions" value="php" />
<arg name="encoding" value="UTF-8" /> <arg name="encoding" value="UTF-8" />

1
src/ResourceLoader/CiteDataModule.php
View file

@ -16,6 +16,7 @@ use ResourceLoaderContext;
*/ */
class CiteDataModule extends \ResourceLoaderModule { class CiteDataModule extends \ResourceLoaderModule {
/** @inheritDoc */
protected $targets = [ 'desktop', 'mobile' ]; protected $targets = [ 'desktop', 'mobile' ];
/** @inheritDoc */ /** @inheritDoc */

6
tests/phpunit/unit/FootnoteMarkFormatterTest.php
View file

@ -143,12 +143,6 @@ class FootnoteMarkFormatterTest extends \MediaWikiUnitTestCase {
* @covers ::getLinkLabel * @covers ::getLinkLabel
* *
* @dataProvider provideGetLinkLabel * @dataProvider provideGetLinkLabel
*
* @param string|null $expectedLabel
* @param int $offset
* @param string $group
* @param string $label
* @param string|null $labelList
*/ */
public function testGetLinkLabel( $expectedLabel, $offset, $group, $labelList ) { public function testGetLinkLabel( $expectedLabel, $offset, $group, $labelList ) {
$mockMessageLocalizer = $this->createMock( ReferenceMessageLocalizer::class ); $mockMessageLocalizer = $this->createMock( ReferenceMessageLocalizer::class );