wikimedia/mediawiki-extensions-Cite
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Cite synced 2024-11-24 15:04:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "Elaborate comment on invalid keys"

Browse source
This commit is contained in:
jenkins-bot 2019-11-03 10:35:30 +00:00 committed by Gerrit Code Review
parent 164463c090 2ddae75d95
commit e006e9682c
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
includes/Cite.php
View file

@ -319,7 +319,9 @@ class Cite {
}
if ( $key === false ) {
# TODO: Comment this case; what does this condition mean?
# Invalid attribute in the tag like <ref no_valid_attr="foo" />
# or name and follow attribute used both in one tag checked in
# Cite::refArg that returns false for the key then.
$this->mRefCallStack[] = false;
return $this->error( 'cite_error_ref_too_many_keys' );
}
@ -438,7 +440,7 @@ class Cite {
}
if ( $argv !== [] ) {
// Invalid key
// Unexpected invalid attribute.
return [ false, false, false, false ];
}