wikimedia/mediawiki-extensions-Cite
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Cite synced 2024-11-24 15:04:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "Test for numeric extends attribute"

Browse source
This commit is contained in:
jenkins-bot 2019-11-26 14:22:39 +00:00 committed by Gerrit Code Review
parent ae28a12e31 22b0bdf526
commit dfb0ccdac6
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/Cite.php
View file

@ -198,7 +198,7 @@ class Cite {
* @return StatusValue
*/
private function validateRef( $text, $name, $group, $follow, $dir, $extends ) : StatusValue {
if ( ctype_digit( $name ) || ctype_digit( $follow ) ) {
if ( ctype_digit( $name ) || ctype_digit( $follow ) || ctype_digit( $extends ) ) {
// Numeric names mess up the resulting id's, potentially producing
// duplicate id's in the XHTML. The Right Thing To Do
// would be to mangle them, but it's not really high-priority