wikimedia/mediawiki-extensions-Cite
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Cite synced 2024-11-23 14:36:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "[refactor] Inline single-use variables"

Browse source
This commit is contained in:
jenkins-bot 2024-08-27 20:36:13 +00:00 committed by Gerrit Code Review
parent 6e6a7ebf2a 850586c625
commit de213b34d2
1 changed files with 2 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
modules/ve-cite/ve.ui.MWCitationDialog.js
View file

@ -151,8 +151,6 @@ ve.ui.MWCitationDialog.prototype.getActionProcess = function ( action ) {
this.checkRequiredParameters().done( () => {
const surfaceModel = this.getFragment().getSurface();
const doc = surfaceModel.getDocument();
const internalList = doc.getInternalList();
const obj = this.transclusionModel.getPlainObject();
// We had a reference, but no template node (or wrong kind of template node)
if ( this.referenceModel && !this.selectedNode ) {
@ -180,7 +178,7 @@ ve.ui.MWCitationDialog.prototype.getActionProcess = function ( action ) {
this.transclusionModel.updateTransclusionNode(
surfaceModel, this.selectedNode
);
} else if ( obj !== null ) {
} else if ( this.transclusionModel.getPlainObject() !== null ) {
this.transclusionModel.insertTransclusionNode(
// HACK: This is trying to place the cursor inside the first
// content branch node but this theoretically not a safe
@ -203,7 +201,7 @@ ve.ui.MWCitationDialog.prototype.getActionProcess = function ( action ) {
// someone fixes that
this.referenceModel.setDocument(
doc.cloneFromRange(
internalList.getItemNode( this.referenceModel.getListIndex() ).getRange()
doc.getInternalList().getItemNode( this.referenceModel.getListIndex() ).getRange()
)
);
this.referenceModel.updateInternalItem( surfaceModel );