wikimedia/mediawiki-extensions-Cite
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Cite synced 2024-11-27 16:30:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix broken deletion of non-existing <ref refGroup="…">

Browse source 
This can be quite confusing:
* A node does have attributes. One of the attributes is called
  "refGroup", another one "mw".
* mw contains a JSON structure with just a few elements, most
  notably a "body" and an "attrs" element. These reflect what was
  originally written in the wikitext.
* mw.attrs reflects the original properties a.k.a. attributes from
  the <ref …> or <references …> tag.

Deleting mw.refGroup doesn't do anything because the attribute is
called <ref group="…"> in the wikitext, not <ref refGroup="…">.

You can actually see this bug in action on all wikis: Go to a page
that uses references in non-standard groups, e.g.
https://en.wikipedia.org/wiki/Historic_Cherokee_settlements
Start VisualEditor. Find e.g. the [notes 1] reference. Edit it
and change the group from "notes" to "General references". Click
"Publish…" and "Review" your changes. The visual diff works because
it apparently uses other information. The wikitext diff is empty.
This is also what's saved: nothing. The edit is lost.

Bug: T359943
Change-Id: I798605d2fd60a6b8f317ec85a4e4d08fd245e084
This commit is contained in:
thiemowmde 2024-02-21 13:27:19 +01:00 committed by Thiemo Kreuz (WMDE)
parent 90dc52620c
commit ae786bc2ef
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
modules/ve-cite/ve.dm.MWReferenceNode.js
View file

@ -232,7 +232,7 @@ ve.dm.MWReferenceNode.static.toDomElements = function ( dataElement, doc, conver
if ( dataElement.attributes.refGroup !== '' ) {
ve.setProp( mwData, 'attrs', 'group', dataElement.attributes.refGroup );
} else if ( mwData.attrs ) {
delete mwData.attrs.refGroup;
delete mwData.attrs.group;
}
}

2
modules/ve-cite/ve.dm.MWReferencesListNode.js
View file

@ -174,7 +174,7 @@ ve.dm.MWReferencesListNode.static.toDomElements = function ( data, doc, converte
if ( attrs.refGroup ) {
ve.setProp( mwData, 'attrs', 'group', attrs.refGroup );
} else if ( mwData.attrs ) {
delete mwData.attrs.refGroup;
delete mwData.attrs.group;
}
const originalMw = attrs.originalMw;