wikimedia/mediawiki-extensions-Cite
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Cite synced 2024-11-27 16:30:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "Sanitize underscores as core does, to not create broken links"

Browse source
This commit is contained in:
jenkins-bot 2018-12-11 00:01:57 +00:00 committed by Gerrit Code Review
parent c4dc31b89e 2b34dede6c
commit 9e981d28b6
2 changed files with 16 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
includes/Cite.php
View file

@ -1080,6 +1080,7 @@ class Cite {
*/
private function normalizeKey( $key ) {
$key = Sanitizer::escapeIdForAttribute( $key );
$key = preg_replace( '/__+/', '_', $key );
$key = Sanitizer::safeEncodeAttribute( $key );
return $key;

15
tests/parser/citeParserTests.txt
View file

@ -271,6 +271,21 @@ Ref names containing a number
!! end
!! test
T184912: Consistent normalization of consecutive underscores
!! wikitext
<ref name="x__x">example</ref>
<references />
!! html
<p><sup id="cite_ref-x_x_1-0" class="reference"><a href="#cite_note-x_x-1">&#91;1&#93;</a></sup>
</p>
<div class="mw-references-wrap"><ol class="references">
<li id="cite_note-x_x-1"><span class="mw-cite-backlink"><a href="#cite_ref-x_x_1-0">↑</a></span> <span class="reference-text">example</span>
</li>
</ol></div>
!! end
!! test
Erroneous refs
!! wikitext