wikimedia/mediawiki-extensions-Cite
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Cite synced 2024-11-23 22:45:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "build: Resolve MediaWikiNoEmptyIfDefined suppression"

Browse source
This commit is contained in:
jenkins-bot 2024-02-16 23:25:32 +00:00 committed by Gerrit Code Review
parent 5bad2b183f 8580b73320
commit 90dc52620c
3 changed files with 3 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
.phan/config.php
View file

@ -5,9 +5,6 @@ $cfg = require __DIR__ . '/../vendor/mediawiki/mediawiki-phan-config/src/config.
// Due to creation of Parser::$extCite property // Due to creation of Parser::$extCite property
$cfg['suppress_issue_types'][] = 'PhanUndeclaredProperty'; $cfg['suppress_issue_types'][] = 'PhanUndeclaredProperty';
// To migrate later
$cfg['suppress_issue_types'][] = 'MediaWikiNoEmptyIfDefined';
/** /**
* Quick implementation of a recursive directory list. * Quick implementation of a recursive directory list.
* @param string $dir The directory to list * @param string $dir The directory to list

2
src/Parsoid/Ref.php
View file

@ -35,7 +35,7 @@ class Ref extends ExtensionTagHandler {
// function. However, we're overly permissive here since we can't // function. However, we're overly permissive here since we can't
// distinguish when that's nested in another template. // distinguish when that's nested in another template.
// The php preprocessor did our expansion. // The php preprocessor did our expansion.
$allowNestedRef = !empty( $extApi->inTemplate() ); $allowNestedRef = $extApi->inTemplate();
return $extApi->extTagToDOM( return $extApi->extTagToDOM(
$extArgs, $extArgs,

2
src/Parsoid/References.php
View file

@ -1,6 +1,8 @@
<?php <?php
declare( strict_types = 1 ); declare( strict_types = 1 );
// phpcs:disable MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment // phpcs:disable MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment
// @phan-file-suppress MediaWikiNoEmptyIfDefined Phan thinks the @property docs in the DataParsoid
// class are a guarantee, but they aren't
namespace Cite\Parsoid; namespace Cite\Parsoid;