From 8cb34b6a4c1fb6901e72e25e32a66280895c3543 Mon Sep 17 00:00:00 2001 From: sbailey Date: Thu, 25 Jun 2020 14:25:59 -0700 Subject: [PATCH] Add an html/parsoid section for "Error conditions on non-visible content" Also, FIXMEs for a follow up to 4438a72 that's exposed by this test. Nested refs in references aren't getting marked up for the "cite_error_ref_no_text" errors, where applicable. Change-Id: Ie6e461571402a96e47d3df26585d9a40f1038891 --- src/Parsoid/References.php | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/Parsoid/References.php b/src/Parsoid/References.php index 778fb91df..8ccd98eac 100644 --- a/src/Parsoid/References.php +++ b/src/Parsoid/References.php @@ -322,6 +322,9 @@ class References extends ExtensionTagHandler { // Iterate through the named ref list for refs without content and // back-patch typeof and data-mw error information into named ref // instances without content + // FIXME: Note this doesn't add errors to the content in + // $nestedRefsHTML since it's already serialized at this point. + // Captured in the test, "Error conditions on non-visible content" if ( $refGroup ) { foreach ( $refGroup->indexByName as $ref ) { if ( $ref->contentId === null ) {