wikimedia/mediawiki-extensions-Cite
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Cite synced 2024-11-12 09:10:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "Get rid of one nesting level in highlighting code"

Browse source
This commit is contained in:
jenkins-bot 2018-11-30 14:58:49 +00:00 committed by Gerrit Code Review
parent e353d36f3a 9ce4b959bc
commit 8ae3b13d1a
1 changed files with 21 additions and 21 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

42
modules/ext.cite.highlighting.js
View file

@ -45,28 +45,28 @@
textNode = textNode.firstChild; textNode = textNode.firstChild;
} }
if ( textNode.nodeType === Node.TEXT_NODE && if ( textNode.nodeType !== Node.TEXT_NODE || textNode.data.trim() === '' ) {
textNode.data.trim() !== '' return;
) {
accessibilityLabel = mw.msg( 'cite_references_link_accessibility_back_label' );
upArrow = textNode.data.trim();
// The text node typically contains "↑ ", and we need to keep the space.
textNode.data = textNode.data.replace( upArrow, '' );
// Create a plain text and a clickable "↑". CSS :target selectors make sure only
// one is visible at a time.
$upArrowLink = $( '<a>' )
.addClass( 'mw-cite-up-arrow-backlink' )
.attr( 'aria-label', accessibilityLabel )
.attr( 'title', accessibilityLabel )
.text( upArrow );
$backlinkWrapper.prepend(
$( '<span>' )
.addClass( 'mw-cite-up-arrow' )
.text( upArrow ),
$upArrowLink
);
} }
accessibilityLabel = mw.msg( 'cite_references_link_accessibility_back_label' );
upArrow = textNode.data.trim();
// The text node typically contains "↑ ", and we need to keep the space.
textNode.data = textNode.data.replace( upArrow, '' );
// Create a plain text and a clickable "↑". CSS :target selectors make sure only
// one is visible at a time.
$upArrowLink = $( '<a>' )
.addClass( 'mw-cite-up-arrow-backlink' )
.attr( 'aria-label', accessibilityLabel )
.attr( 'title', accessibilityLabel )
.text( upArrow );
$backlinkWrapper.prepend(
$( '<span>' )
.addClass( 'mw-cite-up-arrow' )
.text( upArrow ),
$upArrowLink
);
} }
$upArrowLink.attr( 'href', $backlink.attr( 'href' ) ); $upArrowLink.attr( 'href', $backlink.attr( 'href' ) );