wikimedia/mediawiki-extensions-Cite
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Cite synced 2024-11-24 06:54:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

Avoid indirect global access in unit tests

Browse source 
If a ResourceLoaderFileModule is constructed with no arguments, it
accesses global variables, so this is not allowed from a unit test.
(This is probably a bug in ResourceLoaderFileModule, but one thing at a
time.)

This blocks If005958c76bbfabba74def4215c48fe94f297797.

Change-Id: I84056024b0d3a9dcddb1ab4dc8596118bb3fe8ea
This commit is contained in:
Aryeh Gregor 2022-04-27 17:58:48 +03:00
parent 5b4cd3623b
commit 7bd68f0efa
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
tests/phpunit/unit/CiteDataModuleTest.php
View file

@ -14,7 +14,7 @@ use ResourceLoaderContext;
class CiteDataModuleTest extends \MediaWikiUnitTestCase {
public function testGetScript() {
$module = new CiteVisualEditorModule();
$module = new CiteVisualEditorModule( [], '', '' );
$context = $this->createResourceLoaderContext();
$this->assertSame(
@ -24,7 +24,7 @@ class CiteDataModuleTest extends \MediaWikiUnitTestCase {
}
public function testGetDefinitionSummary() {
$module = new CiteVisualEditorModule();
$module = new CiteVisualEditorModule( [], '', '' );
$context = $this->createResourceLoaderContext();
$summary = $module->getDefinitionSummary( $context );