From 798b4537712ea448b863eaf57800dfec685d6ff7 Mon Sep 17 00:00:00 2001
From: Alex Monk <krenair@wikimedia.org>
Date: Mon, 23 Jun 2014 22:42:17 +0100
Subject: [PATCH] If there's no main <references /> block on the page, show one
 automatically below the content

Rather than showing an error

Bug: 66860
Change-Id: I9c7c13269d5ec355ccb280402aa8c0cedd208883
---
 Cite_body.php       |  5 ++---
 citeParserTests.txt | 16 ++++++++++------
 i18n/core/en.json   |  3 +--
 3 files changed, 13 insertions(+), 11 deletions(-)

diff --git a/Cite_body.php b/Cite_body.php
index 8cb1cc0bd..d59c6780d 100644
--- a/Cite_body.php
+++ b/Cite_body.php
@@ -1071,11 +1071,10 @@ class Cite {
 			if ( count( $refs ) == 0 ) {
 				continue;
 			}
-			$text .= "\n<br />";
 			if ( $group == CITE_DEFAULT_GROUP ) {
-				$text .= $this->error( 'cite_error_refs_without_references' );
+				$text .= $this->referencesFormat( $group, '', '' );
 			} else {
-				$text .= $this->error( 'cite_error_group_refs_without_references', htmlspecialchars( $group ) );
+				$text .= "\n<br />" . $this->error( 'cite_error_group_refs_without_references', htmlspecialchars( $group ) );
 			}
 		}
 		return true;
diff --git a/citeParserTests.txt b/citeParserTests.txt
index 4d872d870..329806b50 100644
--- a/citeParserTests.txt
+++ b/citeParserTests.txt
@@ -9,9 +9,11 @@ Simple <ref>, no <references/>
 !! input
 Wikipedia rocks!<ref>Proceeds of Rockology, vol. XXI</ref>
 !! result
-<p>Wikipedia rocks!<sup id="cite_ref-1" class="reference"><a href="#cite_note-1">[1]</a></sup>
-<br /><strong class="error mw-ext-cite-error">Cite error: <code>&lt;ref&gt;</code> tags exist, but no <code>&lt;references/&gt;</code> tag was found</strong>
-</p>
+Wikipedia rocks!<sup id="cite_ref-1" class="reference"><a href="#cite_note-1">[1]</a></sup><ol class="references">
+<li id="cite_note-1"><span class="mw-cite-backlink"><a href="#cite_ref-1">↑</a></span> <span class="reference-text">Proceeds of Rockology, vol. XXI</span>
+</li>
+</ol>
+
 !! end
 
 !! test
@@ -141,9 +143,11 @@ Templating<ref>Text<!--comment--></ref>
 !! input
 {{REVISIONID}}<ref>elite</ref>
 !! result
-<p>1337<sup id="cite_ref-1" class="reference"><a href="#cite_note-1">[1]</a></sup>
-<br /><strong class="error mw-ext-cite-error">Cite error: <code>&lt;ref&gt;</code> tags exist, but no <code>&lt;references/&gt;</code> tag was found</strong>
-</p>
+1337<sup id="cite_ref-1" class="reference"><a href="#cite_note-1">[1]</a></sup><ol class="references">
+<li id="cite_note-1"><span class="mw-cite-backlink"><a href="#cite_ref-1">↑</a></span> <span class="reference-text">elite</span>
+</li>
+</ol>
+
 !! end
 
 !! test
diff --git a/i18n/core/en.json b/i18n/core/en.json
index 37a7bc36a..c5aa5bec1 100644
--- a/i18n/core/en.json
+++ b/i18n/core/en.json
@@ -14,7 +14,6 @@
     "cite_error_no_link_label_group": "Ran out of custom link labels for group \"$1\".\nDefine more in the <nowiki>[[MediaWiki:$2]]</nowiki> message.",
     "cite_error_references_no_text": "Invalid <code>&lt;ref&gt;</code> tag;\nno text was provided for refs named <code>$1</code>",
     "cite_error_included_ref": "Closing <code>&lt;/ref&gt;</code> missing for <code>&lt;ref&gt;</code> tag",
-    "cite_error_refs_without_references": "<code>&lt;ref&gt;</code> tags exist, but no <code>&lt;references/&gt;</code> tag was found",
     "cite_error_group_refs_without_references": "<code>&lt;ref&gt;</code> tags exist for a group named \"$1\", but no corresponding <code>&lt;references group=\"$1\"/&gt;</code> tag was found, or a closing <code>&lt;/ref&gt;</code> is missing",
     "cite_error_references_group_mismatch": "<code>&lt;ref&gt;</code> tag in <code>&lt;references&gt;</code> has conflicting group attribute \"$1\".",
     "cite_error_references_missing_group": "<code>&lt;ref&gt;</code> tag defined in <code>&lt;references&gt;</code> has group attribute \"$1\" which does not appear in prior text.",
@@ -38,4 +37,4 @@
     "cite_references_link_many_accessibility_label": "Jump up to:",
     "cite_references_prefix": "<ol class=\"references\">",
     "cite_references_suffix": "</ol>"
-}
\ No newline at end of file
+}