wikimedia/mediawiki-extensions-Cite
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Cite synced 2024-11-27 16:30:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

Cite tests: Update html/parsoid sections with output in integrated mode

Browse source 
These changes are a result of adding Parsoid integrated testing support
in core.

* Some tests got new html/parsoid sections.
* Some tests got their html/parsoid output upgraded to remove bogus HTML.
* Since we are not treating the test runs to be in integrated mode,
  I removed some comments that only pertained to a test run in
  standalone mode.
* There are 8 tests that are failing in integrated mode as well and
  I've tagged 5 known ones with T307741. The other 3 failing ones are
  the responsive reference tests that have a threshold value set.
  Those failures will need investigation and require additional changes
  to the core parser test runner to pass through the config to Parsoid.

Change-Id: I370d57d45cf126f71b3666fb493a887faf6b8e0d
This commit is contained in:
Subramanya Sastry 2022-04-22 13:54:58 +05:30 committed by jenkins-bot
parent 28d6a05c35
commit 74aa1ea647
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/Parsoid/References.php
View file

@ -213,8 +213,9 @@ class References extends ExtensionTagHandler {
$refContent = $extApi->getContentDOM( $ref->contentId )->firstChild; $refContent = $extApi->getContentDOM( $ref->contentId )->firstChild;
$ref->cachedHtml = $extApi->domToHtml( $refContent, true, false ); $ref->cachedHtml = $extApi->domToHtml( $refContent, true, false );
} }
// FIXME: Strip the mw:Cite/Follow wrappers
// See the test, "Forward-referenced ref with magical follow edge case" // See the test, "Forward-referenced ref with magical follow edge case"
// Ideally, we should strip the mw:Cite/Follow wrappers before comparing
// But, we are going to ignore this edge case as not worth the complexity.
$html = $extApi->domToHtml( $c, true, false ); $html = $extApi->domToHtml( $c, true, false );
$contentDiffers = ( $html !== $ref->cachedHtml ); $contentDiffers = ( $html !== $ref->cachedHtml );
} }