wikimedia/mediawiki-extensions-Cite
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Cite synced 2024-09-24 02:38:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "ve.ui.MWCitationDialog: Unbreak the logic to enable/disable actions"

Browse source
This commit is contained in:
jenkins-bot 2019-01-03 18:41:09 +00:00 committed by Gerrit Code Review
parent c23cd59a53 adc64b3002
commit 6a51ea98b3
1 changed files with 7 additions and 30 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

37
modules/ve-cite/ve.ui.MWCitationDialog.js
View file

@ -103,38 +103,15 @@ ve.ui.MWCitationDialog.prototype.getSetupProcess = function ( data ) {
}, this ); }, this );
}; };
ve.ui.MWCitationDialog.prototype.onTransclusionReady = function () {
// Parent method
ve.ui.MWCitationDialog.super.prototype.onTransclusionReady.call( this );
if ( !this.hasUsefulParameter() ) {
this.actions.setAbilities( { apply: false, insert: false } );
}
};
/** /**
* @inheritdoc * @inheritdoc
*/ */
ve.ui.MWCitationDialog.prototype.setPageByName = function ( param ) { ve.ui.MWCitationDialog.prototype.setApplicableStatus = function () {
var hasUsefulParameter = this.hasUsefulParameter(); ve.ui.MWCitationDialog.super.prototype.setApplicableStatus.call( this );
// Parent method disables 'apply' if no changes were made (this is okay for us), and
// Parent method // disables 'insert' if transclusion is empty (but it is never empty in our case).
ve.ui.MWCitationDialog.super.prototype.setPageByName.call( this, param ); // Instead, disable 'insert' if no parameters were added.
this.actions.setAbilities( { insert: this.hasUsefulParameter() } );
this.actions.setAbilities( { apply: hasUsefulParameter, insert: hasUsefulParameter } );
};
/**
* @inheritdoc
*/
ve.ui.MWCitationDialog.prototype.onAddParameterBeforeLoad = function ( page ) {
var dialog = this,
hasUsefulParameter = this.hasUsefulParameter();
page.preLoad = true;
page.valueInput.on( 'change', function () {
dialog.actions.setAbilities( { apply: hasUsefulParameter, insert: hasUsefulParameter } );
} );
}; };
/** /**
@ -149,7 +126,7 @@ ve.ui.MWCitationDialog.prototype.hasUsefulParameter = function () {
page = this.bookletLayout.pages[ name ]; page = this.bookletLayout.pages[ name ];
if ( if (
page instanceof ve.ui.MWParameterPage && page instanceof ve.ui.MWParameterPage &&
( !page.preLoad || page.valueInput.getValue() !== '' ) page.valueInput.getValue() !== ''
) { ) {
return true; return true;
} }