Fix all remaining PHPCS issues

Change-Id: I977a9f2efc5d95692341b17c6c2f41b7446d13e2
This commit is contained in:
Thiemo Kreuz 2020-01-20 11:13:31 +01:00
parent e555485825
commit 6472bdb369
3 changed files with 15 additions and 5 deletions

View file

@ -1,10 +1,6 @@
<?xml version="1.0"?> <?xml version="1.0"?>
<ruleset> <ruleset>
<rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki"> <rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki" />
<exclude name="MediaWiki.Commenting.FunctionComment.MissingDocumentationPrivate" />
<exclude name="MediaWiki.Commenting.FunctionComment.MissingParamTag" />
<exclude name="MediaWiki.Commenting.FunctionComment.ParamNameNoMatch" />
</rule>
<file>.</file> <file>.</file>
<arg name="extensions" value="php,php5,inc" /> <arg name="extensions" value="php,php5,inc" />
<arg name="encoding" value="UTF-8" /> <arg name="encoding" value="UTF-8" />

View file

@ -195,6 +195,12 @@ class Cite {
$this->validateRefInReferences( $text, $group, $name ); $this->validateRefInReferences( $text, $group, $name );
} }
/**
* @param ?string $text
* @param ?string $name
*
* @return StatusValue
*/
private function validateRefOutsideOfReferences( private function validateRefOutsideOfReferences(
?string $text, ?string $text,
?string $name ?string $name
@ -235,6 +241,13 @@ class Cite {
return StatusValue::newGood(); return StatusValue::newGood();
} }
/**
* @param ?string $text
* @param string $group
* @param ?string $name
*
* @return StatusValue
*/
private function validateRefInReferences( private function validateRefInReferences(
?string $text, ?string $text,
string $group, string $group,

View file

@ -228,6 +228,7 @@ class ReferencesFormatter {
} }
/** /**
* @param Parser $parser
* @param string|int $key * @param string|int $key
* @param ?string $text * @param ?string $text
* @param bool $isSectionPreview * @param bool $isSectionPreview