wikimedia/mediawiki-extensions-Cite
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Cite synced 2024-11-11 16:49:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Drop redundant fallbacks from parsoid-styles directory

Browse source 
These .less files are pointless because these languages have
fallbacks, and the .less file for the fallback is identical. The
behavior on the cluster will not change when we remove these
files. Another file with the same rules will be loaded instead.

I made this patch algorithmically by writing a piece of code that
iterates all existing .less files, checks if the language does
have fallbacks, and if one of the fallback .less files is
identical.

I also updated the existing test case to reflect what's going on.

Change-Id: Iab647956f7bf45e59da1af33ff2b3e81ad016b4c
This commit is contained in:
thiemowmde 2024-07-19 15:00:01 +02:00
parent f1bd3175fd
commit 5ef0ccdaa6
29 changed files with 2 additions and 100 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
modules/parsoid-styles/ext.cite.style.be_tarask.less
View file

@ -1 +0,0 @@
@import 'ext.cite.parsoid.comma-instead-of-dot.less';

11
modules/parsoid-styles/ext.cite.style.blk.less
View file

@ -1,11 +0,0 @@
.mw-ref > a[ style~='mw-Ref' ]::after {
content: '[' counter( mw-Ref, myanmar ) ']';
}
.mw-ref > a[ style~='mw-Ref' ][ data-mw-group ]::after {
content: '[' attr( data-mw-group ) ' ' counter( mw-Ref, myanmar ) ']';
}
span[ rel='mw:referencedBy' ] > a::before {
content: counter( mw-references, myanmar ) '.' counter( mw-ref-linkback, myanmar );
}

11
modules/parsoid-styles/ext.cite.style.bpy.less
View file

@ -1,11 +0,0 @@
.mw-ref > a[ style~='mw-Ref' ]::after {
content: '[' counter( mw-Ref, bengali ) ']';
}
.mw-ref > a[ style~='mw-Ref' ][ data-mw-group ]::after {
content: '[' attr( data-mw-group ) ' ' counter( mw-Ref, bengali ) ']';
}
span[ rel='mw:referencedBy' ] > a::before {
content: counter( mw-references, bengali ) '.' counter( mw-ref-linkback, bengali );
}

1
modules/parsoid-styles/ext.cite.style.ca.less
View file

@ -1 +0,0 @@
@import 'ext.cite.parsoid.comma-instead-of-dot.less';

1
modules/parsoid-styles/ext.cite.style.crh_cyrl.less
View file

@ -1 +0,0 @@
@import 'ext.cite.parsoid.comma-instead-of-dot.less';

1
modules/parsoid-styles/ext.cite.style.cs.less
View file

@ -1 +0,0 @@
@import 'ext.cite.parsoid.comma-instead-of-dot.less';

1
modules/parsoid-styles/ext.cite.style.de_ch.less
View file

@ -1 +0,0 @@
@import 'ext.cite.parsoid.comma-instead-of-dot.less';

1
modules/parsoid-styles/ext.cite.style.frp.less
View file

@ -1 +0,0 @@
@import 'ext.cite.parsoid.comma-instead-of-dot.less';

1
modules/parsoid-styles/ext.cite.style.fur.less
View file

@ -1 +0,0 @@
@import 'ext.cite.parsoid.comma-instead-of-dot.less';

1
modules/parsoid-styles/ext.cite.style.gl.less
View file

@ -1 +0,0 @@
@import 'ext.cite.parsoid.comma-instead-of-dot.less';

1
modules/parsoid-styles/ext.cite.style.kaa.less
View file

@ -1 +0,0 @@
@import 'ext.cite.parsoid.comma-instead-of-dot.less';

11
modules/parsoid-styles/ext.cite.style.kjp.less
View file

@ -1,11 +0,0 @@
.mw-ref > a[ style~='mw-Ref' ]::after {
content: '[' counter( mw-Ref, myanmar ) ']';
}
.mw-ref > a[ style~='mw-Ref' ][ data-mw-group ]::after {
content: '[' attr( data-mw-group ) ' ' counter( mw-Ref, myanmar ) ']';
}
span[ rel='mw:referencedBy' ] > a::before {
content: counter( mw-references, myanmar ) '.' counter( mw-ref-linkback, myanmar );
}

1
modules/parsoid-styles/ext.cite.style.kk_latn.less
View file

@ -1 +0,0 @@
@import 'ext.cite.parsoid.comma-instead-of-dot.less';

1
modules/parsoid-styles/ext.cite.style.ksh.less
View file

@ -1 +0,0 @@
@import 'ext.cite.parsoid.comma-instead-of-dot.less';

11
modules/parsoid-styles/ext.cite.style.ksw.less
View file

@ -1,11 +0,0 @@
.mw-ref > a[ style~='mw-Ref' ]::after {
content: '[' counter( mw-Ref, myanmar ) ']';
}
.mw-ref > a[ style~='mw-Ref' ][ data-mw-group ]::after {
content: '[' attr( data-mw-group ) ' ' counter( mw-Ref, myanmar ) ']';
}
span[ rel='mw:referencedBy' ] > a::before {
content: counter( mw-references, myanmar ) '.' counter( mw-ref-linkback, myanmar );
}

1
modules/parsoid-styles/ext.cite.style.lbe.less
View file

@ -1 +0,0 @@
@import 'ext.cite.parsoid.comma-instead-of-dot.less';

1
modules/parsoid-styles/ext.cite.style.ln.less
View file

@ -1 +0,0 @@
@import 'ext.cite.parsoid.comma-instead-of-dot.less';

11
modules/parsoid-styles/ext.cite.style.mag.less
View file

@ -1,11 +0,0 @@
.mw-ref > a[ style~='mw-Ref' ]::after {
content: '[' counter( mw-Ref, devanagari ) ']';
}
.mw-ref > a[ style~='mw-Ref' ][ data-mw-group ]::after {
content: '[' attr( data-mw-group ) ' ' counter( mw-Ref, devanagari ) ']';
}
span[ rel='mw:referencedBy' ] > a::before {
content: counter( mw-references, devanagari ) '.' counter( mw-ref-linkback, devanagari );
}

11
modules/parsoid-styles/ext.cite.style.mnw.less
View file

@ -1,11 +0,0 @@
.mw-ref > a[ style~='mw-Ref' ]::after {
content: '[' counter( mw-Ref, myanmar ) ']';
}
.mw-ref > a[ style~='mw-Ref' ][ data-mw-group ]::after {
content: '[' attr( data-mw-group ) ' ' counter( mw-Ref, myanmar ) ']';
}
span[ rel='mw:referencedBy' ] > a::before {
content: counter( mw-references, myanmar ) '.' counter( mw-ref-linkback, myanmar );
}

1
modules/parsoid-styles/ext.cite.style.nb.less
View file

@ -1 +0,0 @@
@import 'ext.cite.parsoid.comma-instead-of-dot.less';

1
modules/parsoid-styles/ext.cite.style.nds.less
View file

@ -1 +0,0 @@
@import 'ext.cite.parsoid.comma-instead-of-dot.less';

1
modules/parsoid-styles/ext.cite.style.oc.less
View file

@ -1 +0,0 @@
@import 'ext.cite.parsoid.comma-instead-of-dot.less';

1
modules/parsoid-styles/ext.cite.style.pt.less
View file

@ -1 +0,0 @@
@import 'ext.cite.parsoid.comma-instead-of-dot.less';

11
modules/parsoid-styles/ext.cite.style.sa.less
View file

@ -1,11 +0,0 @@
.mw-ref > a[ style~='mw-Ref' ]::after {
content: '[' counter( mw-Ref, devanagari ) ']';
}
.mw-ref > a[ style~='mw-Ref' ][ data-mw-group ]::after {
content: '[' attr( data-mw-group ) ' ' counter( mw-Ref, devanagari ) ']';
}
span[ rel='mw:referencedBy' ] > a::before {
content: counter( mw-references, devanagari ) '.' counter( mw-ref-linkback, devanagari );
}

1
modules/parsoid-styles/ext.cite.style.sah.less
View file

@ -1 +0,0 @@
@import 'ext.cite.parsoid.comma-instead-of-dot.less';

1
modules/parsoid-styles/ext.cite.style.se.less
View file

@ -1 +0,0 @@
@import 'ext.cite.parsoid.comma-instead-of-dot.less';

1
modules/parsoid-styles/ext.cite.style.udm.less
View file

@ -1 +0,0 @@
@import 'ext.cite.parsoid.comma-instead-of-dot.less';

1
modules/parsoid-styles/ext.cite.style.wa.less
View file

@ -1 +0,0 @@
@import 'ext.cite.parsoid.comma-instead-of-dot.less';

4
tests/phpunit/CiteCSSFileModuleTest.php
View file

@ -16,14 +16,14 @@ class CiteCSSFileModuleTest extends \MediaWikiIntegrationTestCase {
$this->setService(
'ContentLanguage',
$this->getServiceContainer()->getLanguageFactory()->getLanguage( 'fa' )
$this->getServiceContainer()->getLanguageFactory()->getLanguage( 'wa' )
);
}
public function testModule() {
$module = new CiteCSSFileModule( [], __DIR__ . '/../../modules/parsoid-styles' );
$styles = $module->getStyleFiles( $this->createMock( Context::class ) );
$this->assertSame( [ 'ext.cite.style.fa.less' ], $styles['all'] );
$this->assertSame( [ 'ext.cite.style.fr.less' ], $styles['all'] );
}
}