wikimedia/mediawiki-extensions-Cite
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Cite synced 2024-11-24 06:54:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

extapi: Stop leaking manager (an impl. detail) to extensions

Browse source 
* Extensions only need config info (env) and potentially abstract
  parsing context (frame).

* Added some FIXMEs about potential future improvements.

Change-Id: Ib4cec4a77ecb96c855798eeb06f7742c5efb0729
This commit is contained in:
Subramanya Sastry 2018-12-31 12:32:34 -06:00 committed by jenkins-bot
parent df161e78eb
commit 59b6621db3
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
lib/ext/Cite/index.js
View file

@ -382,7 +382,7 @@ References.prototype.toDOM = function(state, content, args) {
responsive: null,
}, TokenUtils.kvToHash(args, true));
var frag = createReferences(state.manager.env, doc.body, refsOpts, function(dp) {
var frag = createReferences(state.env, doc.body, refsOpts, function(dp) {
dp.src = state.extToken.getAttribute('source');
// Redundant - also present on doc.body.firstChild, but feels cumbersome to use
dp.selfClose = state.extToken.dataAttribs.selfClose;