From 52646d1a7c9645d2b61088c508c0c7520b8ef05f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bartosz=20Dziewo=C5=84ski?= Date: Sat, 4 Jan 2020 13:48:37 +0100 Subject: [PATCH] Make native selection over reference nodes visible Bug: T241880 Change-Id: Ie712d4edc2ef49dd3b1f4ca186b2e2d539ab8659 --- modules/ve-cite/ve.ce.MWReferenceNode.css | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/modules/ve-cite/ve.ce.MWReferenceNode.css b/modules/ve-cite/ve.ce.MWReferenceNode.css index df85398a5..fab219adf 100644 --- a/modules/ve-cite/ve.ce.MWReferenceNode.css +++ b/modules/ve-cite/ve.ce.MWReferenceNode.css @@ -15,11 +15,18 @@ display: inline-block; } -/* Use zero font size to hide the default rendering, rather than display:none, to - * work around T123608 (cursoring bug in Chromium). See that bug for a discussion - * of the effect this has on bidi text. */ +/* Use transparency to hide the default rendering, rather than display:none. + * This allows the browser to paint the native selection background over it. + * + * The real content is displayed using the :after pseudo-element, but browsers + * do not allow them to be selected, which makes for a poor editing experience. + * + * Previously this was also required to work around a cursoring bug in Chromium + * (T123608), but as of 2020 that bug seems to be fixed in the browser. + */ .ve-ce-mwReferenceNode span.mw-reflink-text { - font-size: 0; + color: transparent; + position: absolute; display: inline; }