wikimedia/mediawiki-extensions-Cite
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Cite synced 2024-11-13 17:53:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

Revert "Remove global for if previews are shown"

Browse source 
This reverts commit afdbf2d46d.

Causing some issues with the dependency. Will do this cleanup in a later step when most of the involved complexity is gone anyways.

Change-Id: I3f29d64503d5088d058bf87dd0448f5754d4c6fe
This commit is contained in:
WMDE-Fisch 2024-04-22 08:30:55 +00:00 committed by Gerrit Code Review
parent afdbf2d46d
commit 4f50d3b009
2 changed files with 18 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
modules/ext.cite.referencePreviews/index.js
View file

@ -13,6 +13,11 @@ const referencePreviewsState = isReferencePreviewsEnabled(
);
const gateway = createReferenceGateway();
// For tracking baseline stats in the Cite extension https://phabricator.wikimedia.org/T353798
// FIXME: This might be obsolete when the code moves to the Cite extension and the tracking there
// can check that state differently.
mw.config.set( 'wgPopupsReferencePreviewsVisible', !!referencePreviewsState );
mw.trackSubscribe( 'Popups.SettingChange', ( data ) => {
if ( data.previewType === TYPE_REFERENCE ) {
mw.track( LOGGING_SCHEMA, data );

22
modules/ext.cite.tracking.js
View file

@ -11,10 +11,10 @@
* @see https://meta.wikimedia.org/wiki/Schema:ReferencePreviewsCite
*/
const isReferencePreviewsEnabled =
require( './ext.cite.referencePreviews/isReferencePreviewsEnabled.js' );
const CITE_BASELINE_LOGGING_SCHEMA = 'ext.cite.baseline';
// Same as in the Popups extension
// FIXME: Could be an extension wide constant when Reference Previews is merged into this code base
const REFERENCE_PREVIEWS_LOGGING_SCHEMA = 'event.ReferencePreviewsPopups';
// EventLogging may not be installed
mw.loader.using( 'ext.eventLogging' ).then( function () {
@ -25,24 +25,28 @@ mw.loader.using( 'ext.eventLogging' ).then( function () {
return;
}
// FIXME: This might be obsolete when the code moves to the this extension
mw.trackSubscribe( REFERENCE_PREVIEWS_LOGGING_SCHEMA, function ( type, data ) {
if ( data.action.indexOf( 'anonymous' ) !== -1 ) {
mw.config.set( 'wgPopupsReferencePreviewsVisible', data.action === 'anonymousEnabled' );
}
} );
// eslint-disable-next-line no-jquery/no-global-selector
$( '#mw-content-text' ).on(
'click',
// Footnote links, references block in VisualEditor, and reference content links.
'.reference a[ href*="#" ], .mw-reference-text a, .reference-text a',
function () {
const referencePreviewsState = isReferencePreviewsEnabled(
mw.user,
mw.popups.isEnabled,
mw.config
);
const isInReferenceBlock = $( this ).parents( '.references' ).length > 0;
mw.eventLog.dispatch( CITE_BASELINE_LOGGING_SCHEMA, {
action: ( isInReferenceBlock ?
'clickedReferenceContentLink' :
'clickedFootnote' ),
// FIXME: This might be obsolete when the code moves to the this extension and
// we get state directly.
// eslint-disable-next-line camelcase
with_ref_previews: referencePreviewsState
with_ref_previews: mw.config.get( 'wgPopupsReferencePreviewsVisible' )
} );
}
);