wikimedia/mediawiki-extensions-Cite
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Cite synced 2024-11-23 22:45:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "Finish safety fallback for missing groups"

Browse source
This commit is contained in:
jenkins-bot 2024-09-03 12:52:24 +00:00 committed by Gerrit Code Review
parent 30b5fca6ee 5f888c98fa
commit 45e9e7a328
1 changed files with 7 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
modules/ve-cite/ve.dm.MWGroupReferences.js
View file

@ -44,7 +44,12 @@ ve.dm.MWGroupReferences = function VeDmMWGroupReferences() {
/** @private */ /** @private */
this.topLevelCounter = 1; this.topLevelCounter = 1;
/** @private */ /**
* InternalList node group, or null if no such group exists.
*
* @member {Object|null}
* @private
*/
this.nodeGroup = null; this.nodeGroup = null;
}; };
@ -166,7 +171,7 @@ ve.dm.MWGroupReferences.prototype.getTopLevelKeysInReflistOrder = function () {
* @return {ve.dm.MWReferenceNode|undefined} * @return {ve.dm.MWReferenceNode|undefined}
*/ */
ve.dm.MWGroupReferences.prototype.getRefNode = function ( key ) { ve.dm.MWGroupReferences.prototype.getRefNode = function ( key ) {
const keyedNodes = this.nodeGroup.keyedNodes[ key ]; const keyedNodes = this.nodeGroup && this.nodeGroup.keyedNodes[ key ];
return keyedNodes && keyedNodes[ 0 ]; return keyedNodes && keyedNodes[ 0 ];
}; };
@ -195,7 +200,6 @@ ve.dm.MWGroupReferences.prototype.getInternalModelNode = function ( key ) {
* @return {ve.dm.MWReferenceNode[]} * @return {ve.dm.MWReferenceNode[]}
*/ */
ve.dm.MWGroupReferences.prototype.getRefUsages = function ( key ) { ve.dm.MWGroupReferences.prototype.getRefUsages = function ( key ) {
// T373661: This might never have been set in source mode
return ( this.nodeGroup && this.nodeGroup.keyedNodes[ key ] || [] ) return ( this.nodeGroup && this.nodeGroup.keyedNodes[ key ] || [] )
.filter( ( node ) => !node.getAttribute( 'placeholder' ) && .filter( ( node ) => !node.getAttribute( 'placeholder' ) &&
!node.findParent( ve.dm.MWReferencesListNode ) !node.findParent( ve.dm.MWReferencesListNode )