From 8c1494e5bb7195fb114b888401838dfc893ada46 Mon Sep 17 00:00:00 2001 From: Kunal Mehta Date: Sun, 22 Jun 2014 19:36:19 -0700 Subject: [PATCH] SpecialCite: fix escaping of message Linker::link takes raw HTML, so use ->escaped(). Also use $skin->msg() instead of wfMessage. Change-Id: I56c0791d31897793b0e8cd8ac18ea337a96d1ff0 --- SpecialCite.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/SpecialCite.php b/SpecialCite.php index 60fd9671b..3dc897542 100644 --- a/SpecialCite.php +++ b/SpecialCite.php @@ -79,7 +79,7 @@ function wfSpecialCiteToolbox( &$skin ) { array( 'id' => 't-cite' ), Linker::link( SpecialPage::getTitleFor( 'Cite' ), - wfMessage( 'cite_article_link' )->text(), // @todo Should be escaped()? + $skin->msg( 'cite_article_link' )->escaped(), # Used message keys: 'tooltip-cite-article', 'accesskey-cite-article' Linker::tooltipAndAccessKeyAttribs( 'cite-article' ), $skin->data['nav_urls']['cite']['args']