From 373ed0112314588c4a45896cb88e6418f6ccab38 Mon Sep 17 00:00:00 2001
From: Adam Wight <adam.wight@wikimedia.de>
Date: Wed, 23 Oct 2024 13:03:01 +0200
Subject: [PATCH] Parsoid wiring for footnote mark formatting

After this patch, Parsoid-rendered pages will include the same
footnote markers as the legacy parser for custom group markers.

The divergent CSS implementation is left intact, for a soft migration.

Bug: T377454
Change-Id: I576dfff4155fb8c2f91ef0d28a65b319aa5bbb07
---
 src/Parsoid/References.php       |  7 ++++++-
 tests/parser/citeParserTests.txt | 12 +++---------
 2 files changed, 9 insertions(+), 10 deletions(-)

diff --git a/src/Parsoid/References.php b/src/Parsoid/References.php
index 122449896..49dae62b0 100644
--- a/src/Parsoid/References.php
+++ b/src/Parsoid/References.php
@@ -6,8 +6,10 @@ declare( strict_types = 1 );
 
 namespace Cite\Parsoid;
 
+use Cite\MarkSymbolRenderer;
 use Closure;
 use MediaWiki\Config\Config;
+use MediaWiki\MediaWikiServices;
 use stdClass;
 use Wikimedia\Parsoid\Core\DomSourceRange;
 use Wikimedia\Parsoid\DOM\DocumentFragment;
@@ -29,9 +31,12 @@ use Wikimedia\Parsoid\Utils\DOMCompat;
  */
 class References extends ExtensionTagHandler {
 	private Config $mainConfig;
+	private MarkSymbolRenderer $markSymbolRenderer;
 
 	public function __construct( Config $mainConfig ) {
 		$this->mainConfig = $mainConfig;
+
+		$this->markSymbolRenderer = MediaWikiServices::getInstance()->getService( 'Cite.MarkSymbolRenderer' );
 	}
 
 	private static function hasRef( Node $node ): bool {
@@ -411,7 +416,7 @@ class References extends ExtensionTagHandler {
 		$refLinkSpan = $doc->createElement( 'span' );
 		$refLinkSpan->setAttribute( 'class', 'mw-reflink-text' );
 		$refLinkSpan->appendChild( $doc->createTextNode(
-			'[' . ( $ref->group ? $ref->group . ' ' : '' ) . $ref->groupIndex . ']'
+			'[' . $this->markSymbolRenderer->makeLabel( $ref->group, $ref->groupIndex ) . ']'
 		) );
 
 		$refLink->appendChild( $refLinkSpan );
diff --git a/tests/parser/citeParserTests.txt b/tests/parser/citeParserTests.txt
index 495240b36..3874fe7d3 100644
--- a/tests/parser/citeParserTests.txt
+++ b/tests/parser/citeParserTests.txt
@@ -1039,11 +1039,6 @@ MediaWiki:cite_link_label_group-klingon
 wa'  cha' wej loS vagh jav Soch chorgh Hut wa'maH
 !! endarticle
 
-## Parsoid doesn't use messages for i18n. It relies on Cite-specific CSS rules
-## to localize. This CSS is expected to be added to a wiki's
-## MediaWiki:Common.css page.
-## As such, Parsoid's output will differ for klingon i18n label tests.
-## T308094: document this transition.
 !! test
 <ref> with custom group link with number names in Klingon
 !! wikitext
@@ -1058,12 +1053,11 @@ Wikipedia rocks!<ref group="klingon">Proceeds of Rockology, vol. XXI</ref>
 </li>
 </ol></div>
 !! html/parsoid
-<p>Wikipedia rocks!<sup about="#mwt2" class="mw-ref reference" id="cite_ref-1" rel="dc:references" typeof="mw:Extension/ref" data-mw='{"name":"ref","attrs":{"group":"klingon"},"body":{"id":"mw-reference-text-cite_note-1"}}'><a href="./Parser_test#cite_note-1" style="counter-reset: mw-Ref 1;" data-mw-group="klingon"><span class="mw-reflink-text">[klingon 1]</span></a></sup></p>
+<p>Wikipedia rocks!<sup class="mw-ref reference" id="cite_ref-1" rel="dc:references" typeof="mw:Extension/ref" data-mw='{"name":"ref","attrs":{"group":"klingon"},"body":{"id":"mw-reference-text-cite_note-1"}}'><a href="./Parser_test#cite_note-1" style="counter-reset: mw-Ref 1;" data-mw-group="klingon"><span class="mw-reflink-text">[wa']</span></a></sup></p>
 
 <div class="mw-references-wrap" typeof="mw:Extension/references" about="#mwt5" data-mw='{"name":"references","attrs":{"group":"klingon"}}'><ol class="mw-references references" data-mw-group="klingon"><li about="#cite_note-1" id="cite_note-1"><span class="mw-cite-backlink"><a href="./Parser_test#cite_ref-1" data-mw-group="klingon" rel="mw:referencedBy"><span class="mw-linkback-text">↑ </span></a></span> <span id="mw-reference-text-cite_note-1" class="mw-reference-text reference-text">Proceeds of Rockology, vol. XXI</span></li></ol></div>
 !! end
 
-# See above: Parsoid uses a different mechanism for custom link labels
 !! test
 Consecutive whitespace in custom link label message should not create empty []
 !! wikitext
@@ -1081,8 +1075,8 @@ Consecutive whitespace in custom link label message should not create empty []
 </li>
 </ol></div>
 !! html/parsoid
-<p><sup about="#mwt3" class="mw-ref reference" id="cite_ref-1" rel="dc:references" typeof="mw:Extension/ref" data-mw='{"name":"ref","attrs":{"group":"klingon"},"body":{"id":"mw-reference-text-cite_note-1"}}'><a href="./Parser_test#cite_note-1" style="counter-reset: mw-Ref 1;" data-mw-group="klingon"><span class="mw-reflink-text">[klingon 1]</span></a></sup>
-<sup about="#mwt6" class="mw-ref reference" id="cite_ref-2" rel="dc:references" typeof="mw:Extension/ref" data-mw='{"name":"ref","attrs":{"group":"klingon"},"body":{"id":"mw-reference-text-cite_note-2"}}'><a href="./Parser_test#cite_note-2" style="counter-reset: mw-Ref 2;" data-mw-group="klingon"><span class="mw-reflink-text">[klingon 2]</span></a></sup></p>
+<p><sup about="#mwt3" class="mw-ref reference" id="cite_ref-1" rel="dc:references" typeof="mw:Extension/ref" data-mw='{"name":"ref","attrs":{"group":"klingon"},"body":{"id":"mw-reference-text-cite_note-1"}}'><a href="./Parser_test#cite_note-1" style="counter-reset: mw-Ref 1;" data-mw-group="klingon"><span class="mw-reflink-text">[wa']</span></a></sup>
+<sup about="#mwt6" class="mw-ref reference" id="cite_ref-2" rel="dc:references" typeof="mw:Extension/ref" data-mw='{"name":"ref","attrs":{"group":"klingon"},"body":{"id":"mw-reference-text-cite_note-2"}}'><a href="./Parser_test#cite_note-2" style="counter-reset: mw-Ref 2;" data-mw-group="klingon"><span class="mw-reflink-text">[cha']</span></a></sup></p>
 <div class="mw-references-wrap" typeof="mw:Extension/references" about="#mwt9" data-mw='{"name":"references","attrs":{"group":"klingon"}}'><ol class="mw-references references" data-mw-group="klingon"><li about="#cite_note-1" id="cite_note-1"><span class="mw-cite-backlink"><a href="./Parser_test#cite_ref-1" data-mw-group="klingon" rel="mw:referencedBy"><span class="mw-linkback-text">↑ </span></a></span> <span id="mw-reference-text-cite_note-1" class="mw-reference-text reference-text">1st</span></li><li about="#cite_note-2" id="cite_note-2"><span class="mw-cite-backlink"><a href="./Parser_test#cite_ref-2" data-mw-group="klingon" rel="mw:referencedBy"><span class="mw-linkback-text">↑ </span></a></span> <span id="mw-reference-text-cite_note-2" class="mw-reference-text reference-text">2nd</span></li></ol></div>
 !! end