wikimedia/mediawiki-extensions-Cite
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Cite synced 2024-09-24 18:58:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

Elaborate comment on invalid keys

Browse source 
Change-Id: If8e800d69d4ff01ff6c9471e5324c7184e74c136
This commit is contained in:
WMDE-Fisch 2019-11-01 15:15:26 +01:00
parent c5fe31f806
commit 2ddae75d95
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
includes/Cite.php
View file

@ -319,7 +319,9 @@ class Cite {
} }
if ( $key === false ) { if ( $key === false ) {
# TODO: Comment this case; what does this condition mean? # Invalid attribute in the tag like <ref no_valid_attr="foo" />
# or name and follow attribute used both in one tag checked in
# Cite::refArg that returns false for the key then.
$this->mRefCallStack[] = false; $this->mRefCallStack[] = false;
return $this->error( 'cite_error_ref_too_many_keys' ); return $this->error( 'cite_error_ref_too_many_keys' );
} }
@ -438,7 +440,7 @@ class Cite {
} }
if ( $argv !== [] ) { if ( $argv !== [] ) {
// Invalid key // Unexpected invalid attribute.
return [ false, false, false, false ]; return [ false, false, false, false ];
} }