wikimedia/mediawiki-extensions-Cite
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Cite synced 2024-12-18 09:40:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "Preserve reflist CSS in dynamic mode"

Browse source
This commit is contained in:
jenkins-bot 2024-06-06 18:00:29 +00:00 committed by Gerrit Code Review
parent 5082101671 5ef2c13c48
commit 20c6967f76
1 changed files with 19 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

23
modules/ve-cite/ve.ce.MWReferencesListNode.js
View file

@ -187,6 +187,12 @@ ve.ce.MWReferencesListNode.prototype.update = function () {
emptyText = ve.msg( 'cite-ve-referenceslist-isempty-default' ); emptyText = ve.msg( 'cite-ve-referenceslist-isempty-default' );
} }
let originalDomElements;
if ( model.getElement().originalDomElementsHash ) {
originalDomElements = model.getStore().value(
model.getElement().originalDomElementsHash
);
}
// Use the Parsoid-provided DOM if: // Use the Parsoid-provided DOM if:
// //
// * There are no references in the model // * There are no references in the model
@ -196,13 +202,11 @@ ve.ce.MWReferencesListNode.prototype.update = function () {
if ( if (
!hasModelReferences && !hasModelReferences &&
!this.modified && !this.modified &&
model.getElement().originalDomElementsHash originalDomElements
) { ) {
// Create a copy when importing to the main document, as extensions may // Create a copy when importing to the main document, as extensions may
this.$originalRefList = $( ve.copyDomElements( originalDomElements, document ) );
// modify DOM nodes in the main doc. // modify DOM nodes in the main doc.
this.$originalRefList = $( ve.copyDomElements( model.getStore().value(
model.getElement().originalDomElementsHash
), document ) );
if ( this.$originalRefList.find( 'li' ).length ) { if ( this.$originalRefList.find( 'li' ).length ) {
this.$element.append( this.$originalRefList ); this.$element.append( this.$originalRefList );
} else { } else {
@ -216,6 +220,17 @@ ve.ce.MWReferencesListNode.prototype.update = function () {
this.$originalRefList.remove(); this.$originalRefList.remove();
this.$originalRefList = null; this.$originalRefList = null;
} }
// Copy CSS to dynamic ref list
if ( originalDomElements ) {
// Get first container, e.g. skipping TemplateStyles
const divs = originalDomElements.filter( ( element ) => element.tagName === 'DIV' );
if ( divs.length ) {
// eslint-disable-next-line mediawiki/class-doc
this.$element.addClass( divs[ 0 ].getAttribute( 'class' ) );
this.$element.attr( 'style', divs[ 0 ].getAttribute( 'style' ) );
}
}
this.$reflist.detach().empty().attr( 'data-mw-group', refGroup || null ); this.$reflist.detach().empty().attr( 'data-mw-group', refGroup || null );
this.$refmsg.detach(); this.$refmsg.detach();