wikimedia/mediawiki-extensions-Cite
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Cite synced 2024-11-27 16:30:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

Drop unused setters from MWReferenceModel class

Browse source 
These aren't used anywhere:
https://codesearch.wmcloud.org/search/?q=%5Cbset%28ExtendsRef%7CList%28Key%7CGroup%7CIndex%29%29%5Cb
These setters are reaching into internal details that currently
aren't ever modified from outside of the class, and shouldn't.
If it turns out we ever need to modify one of these we can easily
re-introduce setter functions, but probably give them more
meaningful names.

Bug: T363096
Change-Id: I2c9efc114bdc110a29b8d7fb48ea8c1814cdeb21
This commit is contained in:
thiemowmde 2024-04-24 13:52:00 +02:00
parent 14fe315c62
commit 1391f43d03
1 changed files with 8 additions and 48 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

56
modules/ve-cite/ve.dm.MWReferenceModel.js
View file

@ -47,11 +47,11 @@ ve.dm.MWReferenceModel.static.newFromReferenceNode = function ( node ) {
const attr = node.getAttributes();
const ref = new ve.dm.MWReferenceModel( doc );
ref.setExtendsRef( attr.extendsRef );
ref.setListKey( attr.listKey );
ref.setListGroup( attr.listGroup );
ref.setListIndex( attr.listIndex );
ref.setGroup( attr.refGroup );
ref.extendsRef = attr.extendsRef;
ref.listKey = attr.listKey;
ref.listGroup = attr.listGroup;
ref.listIndex = attr.listIndex;
ref.group = attr.refGroup;
ref.deferDoc = function () {
// cloneFromRange is very expensive, so lazy evaluate it
return doc.cloneFromRange( internalList.getItemNode( attr.listIndex ).getRange() );
@ -89,13 +89,13 @@ ve.dm.MWReferenceModel.prototype.insertInternalItem = function ( surfaceModel )
const internalList = doc.getInternalList();
// Fill in data
this.setListKey( 'auto/' + internalList.getNextUniqueNumber() );
this.setListGroup( 'mwReference/' + this.group );
this.listKey = 'auto/' + internalList.getNextUniqueNumber();
this.listGroup = 'mwReference/' + this.group;
// Insert internal reference item into document
const item = internalList.getItemInsertion( this.listGroup, this.listKey, [] );
surfaceModel.change( item.transaction );
this.setListIndex( item.index );
this.listIndex = item.index;
// Inject reference document into internal reference item
surfaceModel.change(
@ -242,46 +242,6 @@ ve.dm.MWReferenceModel.prototype.getDocument = function () {
return this.doc;
};
/**
* Set key of reference in list.
*
* @private
* @param {string} listKey Reference's list key
*/
ve.dm.MWReferenceModel.prototype.setListKey = function ( listKey ) {
this.listKey = listKey;
};
/**
* Set the name of the parent reference that is being extended by the current reference.
*
* @private
* @param {string} extendsRef References parent
*/
ve.dm.MWReferenceModel.prototype.setExtendsRef = function ( extendsRef ) {
this.extendsRef = extendsRef;
};
/**
* Set name of the group a references list is in.
*
* @private
* @param {string} listGroup References list's group
*/
ve.dm.MWReferenceModel.prototype.setListGroup = function ( listGroup ) {
this.listGroup = listGroup;
};
/**
* Set the index of reference in list.
*
* @private
* @param {string} listIndex Reference's list index
*/
ve.dm.MWReferenceModel.prototype.setListIndex = function ( listIndex ) {
this.listIndex = listIndex;
};
/**
* Set the name of the group a reference is in.
*