wikimedia/mediawiki-extensions-Cite
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Cite synced 2024-12-18 01:30:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

Adding check for illegal attributes in references tag

Browse source 
Bug: T51538
Change-Id: I7dbc577a61abb660d2bdb66ead0d7b71fd66cf47
This commit is contained in:
sbailey 2020-10-30 12:57:40 -07:00 committed by jenkins-bot
parent 4310b6a243
commit 01cf61ad67
1 changed files with 12 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/Parsoid/References.php
View file

@ -413,6 +413,18 @@ class References extends ExtensionTagHandler {
if ( !$isTplWrapper ) { if ( !$isTplWrapper ) {
$dataMw = DOMDataUtils::getDataMw( $refsNode ); $dataMw = DOMDataUtils::getDataMw( $refsNode );
// Detect invalid parameters on the references tag
$knownAttributes = [ 'group', 'responsive' ];
foreach ( $dataMw->attrs as $key => $value ) {
if ( !in_array( strtolower( $key ), $knownAttributes, true ) ) {
self::addErrorsToNode(
$refsNode, [ [ 'key' => 'cite_error_references_invalid_parameters' ] ]
);
break;
}
}
// Mark this auto-generated so that we can skip this during // Mark this auto-generated so that we can skip this during
// html -> wt and so that clients can strip it if necessary. // html -> wt and so that clients can strip it if necessary.
if ( $autoGenerated ) { if ( $autoGenerated ) {